sousa-gecko

Files

T

Ting-Yu Lin b4c09dcd55 Bug 2054166 - Force reflow floats when the last column is reflowed with an unconstrained block-size. r=layout-reviewers,dshin

`nsColumnSetFrame` may reflow the last column with an unconstrained block-size,
e.g. at the end of the last column balancing reflow [1]. When that happens,
i.e., `reflowLastColumnWithUnconstrainedAvailBSize=true`, we want to force
reflow all the floats to make sure they are fragmented correctly, by setting
`mMustReflowPlaceholders=true` to ensure the line containing floats is dirty
[2]. This edit alone (in nsColumnSetFrame.cpp) fixes
`column-balancing-with-floats-001.html`.

However, to fix all the assertions seen in bug 2054166 comment 1, we need to
generalize the fix in Bug 1441048 Part 2
https://hg-edge.mozilla.org/mozilla-central/rev/30e4adcd2dbd

This patch extends `ReflowInput::IsInFragmentedContext()` to catch more
scenarios and use the helper when marking lines dirty so that the above
`mMustReflowPlaceholders` trick works. Without this patch,
`column-balancing-with-floats-002.html` can trigger soft assertions in
nsColumnSetFrame [3] and nsFlexContainerFrame [4].

[1] https://searchfox.org/firefox-main/rev/aaf0207c409c5f6479cc92bc1bf407a453d63cdc/layout/generic/nsColumnSetFrame.cpp#1176-1188
[2] https://searchfox.org/firefox-main/rev/aaf0207c409c5f6479cc92bc1bf407a453d63cdc/layout/generic/nsBlockFrame.cpp#3417-3420
[3] https://searchfox.org/firefox-main/rev/7d5b291d2351f7d04c504b03fa22ec3dcdf81b54/layout/generic/nsColumnSetFrame.cpp#1313-1316
[4] https://searchfox.org/firefox-main/rev/7d5b291d2351f7d04c504b03fa22ec3dcdf81b54/layout/generic/nsFlexContainerFrame.cpp#6008-6011

Differential Revision: https://phabricator.services.mozilla.com/D312101

2026-07-14 21:05:55 +00:00

crashtests

Bug 2044844 - Don't call UpdateOverflow for frames that don't track it anyhow. r=layout-reviewers,emilio

2026-06-04 14:10:52 +00:00

test

Bug 2052026 - Treat the UA shadow for SVG <use> as a part of the flat tree for selection r=smaug,webidl

2026-07-05 23:40:44 +00:00

AbsoluteContainingBlock.cpp

Bug 2038072 Part 3 - Support abspos element fragmentation whose containing block is formed inline. r=layout-reviewers,dshin

2026-07-03 03:23:09 +00:00

AbsoluteContainingBlock.h

…

AnonymousContentKey.h

…

AspectRatio.cpp

…

AspectRatio.h

…

AutoCopyListener.h

…

BlockReflowState.cpp

Bug 2048427 - Add multi-column and block fragmentation support for text-box-trim. r=layout-reviewers,TYLin

2026-07-10 05:15:28 +00:00

BlockReflowState.h

Bug 2048427 - Add multi-column and block fragmentation support for text-box-trim. r=layout-reviewers,TYLin

2026-07-10 05:15:28 +00:00

BRFrame.cpp

Bug 2012637 - part 3: Add template nsINode API which can switch to call API from TreeKind r=smaug,dom-core-reviewers,webidl

2026-07-05 23:40:31 +00:00

broken-image.png

…

ColumnSetWrapperFrame.cpp

…

ColumnSetWrapperFrame.h

…

ColumnUtils.cpp

…

ColumnUtils.h

…

CSSAlignUtils.cpp

…

CSSAlignUtils.h

…

CSSOrderAwareFrameIterator.cpp

…

CSSOrderAwareFrameIterator.h

…

folder.png

…

frame-graph.py

…

FrameClass.py

…

FrameClasses.py

…

GenerateFrameLists.py

…

IntrinsicISizesCache.h

…

jar.mn

…

JustificationUtils.h

…

LayoutMessageUtils.h

Bug 2037623 p3 - Use macros for trivial ParamTraits implementations r=ipc-reviewers,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,permissions-reviewers,layout-reviewers,dom-worker-reviewers,chutten,farre,timhuang,jari,valentin,aosmond,asuth,nika,dcarver

2026-06-23 13:29:00 +00:00

MathMLTextRunFactory.cpp

Bug 2048930 - Move some of xpcom's UTF-16 utils to mfbt/Utf16.h. r=jfkthame,necko-reviewers,layout-reviewers

2026-06-23 01:14:55 +00:00

MathMLTextRunFactory.h

…

MiddleCroppingBlockFrame.cpp

Bug 2025968 - Don't allow fragmenting a MiddleCroppingBlockFrame. r=layout-reviewers,dshin

2026-03-28 16:38:35 +00:00

MiddleCroppingBlockFrame.h

…

moz.build

…

nsAtomicContainerFrame.h

…

nsBlockDebugFlags.h

…

nsBlockFrame.cpp

Bug 2054166 - Force reflow floats when the last column is reflowed with an unconstrained block-size. r=layout-reviewers,dshin

2026-07-14 21:05:55 +00:00

nsBlockFrame.h

Bug 2048427 - Add multi-column and block fragmentation support for text-box-trim. r=layout-reviewers,TYLin

2026-07-10 05:15:28 +00:00

nsBlockReflowContext.cpp

Bug 2048427 - Add multi-column and block fragmentation support for text-box-trim. r=layout-reviewers,TYLin

2026-07-10 05:15:28 +00:00

nsBlockReflowContext.h

…

nsCanvasFrame.cpp

Bug 2035992 - Add nsIFrame::GetEventTargetContent() to get proper event target from the given event r=smaug,emilio,layout-reviewers

2026-05-19 08:19:05 +00:00

nsCanvasFrame.h

Bug 2035992 - Add nsIFrame::GetEventTargetContent() to get proper event target from the given event r=smaug,emilio,layout-reviewers

2026-05-19 08:19:05 +00:00

nsColumnSetFrame.cpp

Bug 2054166 - Force reflow floats when the last column is reflowed with an unconstrained block-size. r=layout-reviewers,dshin

2026-07-14 21:05:55 +00:00

nsColumnSetFrame.h

Bug 2052589 - Properly trim multi-column containers with spanners. r=layout-reviewers,TYLin

2026-07-10 05:15:28 +00:00

nsContainerFrame.cpp

Bug 2041516 Part 1 - Assert fresh reflow status at the beginning of AbsoluteContainingBlock::Reflow(). r=layout-reviewers,emilio

2026-05-26 19:07:08 +00:00

nsContainerFrame.h

Bug 2047392 - Modernize InlineReflowInput. r=jfkthame

2026-06-15 18:24:55 +00:00

nsContainerFrameInlines.h

…

nsDirection.h

Bug 2045219 - Improve the debug print of nsINode r=smaug,dom-core-reviewers

2026-06-08 01:00:49 +00:00

nsFirstLetterFrame.cpp

Bug 2030235 - Decouple ServoStyleConsts from nsGkAtoms.h r=emilio,necko-reviewers,geckoview-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,kershaw,m_kato

2026-04-09 10:05:25 +00:00

nsFirstLetterFrame.h

Revert "Bug 2036400 - Initialize uninitialized scalar fields in layout to fix Coverity uninitialized-scalar defects r=layout-reviewers,emilio" for causing build bustages in SVGFilterInstance.h

2026-05-05 07:13:05 +00:00

nsFlexContainerFrame.cpp

Bug 2014220: Propagate up NS_FRAME_CONTAINS_RELATIVE_BSIZE from items in nested flex containers. r=layout-reviewers,TYLin

2026-07-02 21:20:39 +00:00

nsFlexContainerFrame.h

Bug 2014220: Propagate up NS_FRAME_CONTAINS_RELATIVE_BSIZE from items in nested flex containers. r=layout-reviewers,TYLin

2026-07-02 21:20:39 +00:00

nsFloatManager.cpp

Bug 2038767: Use GetOrCreateDeletableProperty in a few more places. r=layout-reviewers,firefox-svg-reviewers,longsonr,emilio

2026-05-11 21:56:17 +00:00

nsFloatManager.h

Bug 2034832 - Make layout/ headers compatible with current static analysis r=firefox-style-system-reviewers,layout-reviewers,dshin

2026-04-29 06:20:43 +00:00

nsFontInflationData.cpp

…

nsFontInflationData.h

Bug 2034832 - Make layout/ headers compatible with current static analysis r=firefox-style-system-reviewers,layout-reviewers,dshin

2026-04-29 06:20:43 +00:00

nsFrameList.cpp

Bug 2030235 - Decouple ServoStyleConsts from nsGkAtoms.h r=emilio,necko-reviewers,geckoview-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,kershaw,m_kato

2026-04-09 10:05:25 +00:00

nsFrameList.h

Bug 2047510 - Activate clang-tidy's modernize-type-traits check r=sylvestre,media-playback-reviewers,webrtc-reviewers,firefox-style-system-reviewers,layout-reviewers,janerik,aosmond,TYLin,bwc,emilio

2026-06-18 07:43:33 +00:00

nsFrameSelection.cpp

Bug 2052637 - Fix nsFrameSelection::GetPageToFrameSelect. r=layout-reviewers,dshin

2026-07-07 09:36:49 +00:00

nsFrameSelection.h

Bug 2045172 - Make ContentEventHandler ignore selection ranges outside the ancestor limiter r=jjaschke

2026-06-17 08:56:57 +00:00

nsFrameSetFrame.cpp

Bug 2045394 - Fix nsFrameSetFrame primary frame handling of children. r=layout-reviewers,dshin

2026-06-10 10:20:37 +00:00

nsFrameSetFrame.h

Bug 2041298 - Comply with clang-tidy's modernize-use-nullptr check for layout/ r=layout-reviewers,emilio

2026-05-26 14:31:53 +00:00

nsFrameState.cpp

Bug 2052092 - Fix -Wimplicit-int-enum-cast warning in nsCSSFrameConstructor.cpp. r=layout-reviewers,TYLin

2026-07-06 05:24:54 +00:00

nsFrameState.h

Bug 2052092 - Fix -Wimplicit-int-enum-cast warning in nsCSSFrameConstructor.cpp. r=layout-reviewers,TYLin

2026-07-06 05:24:54 +00:00

nsFrameStateBits.h

Bug 2046373: apply code formatting via Lando

2026-06-13 14:49:01 +00:00

nsGridContainerFrame.cpp

Bug 2053610 - Try not to crash if a placeholder frame's out-of-flow is null. r=layout-reviewers,firefox-style-system-reviewers,emilio,TYLin

2026-07-13 18:25:23 +00:00

nsGridContainerFrame.h

Bug 2045144 - Remove constructor for ComputedGridLineInfo. r=layout-reviewers,dholbert

2026-06-04 22:08:16 +00:00

nsHTMLCanvasFrame.cpp

Bug 2034406 - Preserve vector commands in MozPrintCallback. r=lsalzman

2026-05-26 11:08:38 +00:00

nsHTMLCanvasFrame.h

…

nsHTMLParts.h

Bug 2031757 - Rejigger text input / textarea rendering to make field-sizing easier. r=layout-reviewers,devtools-reviewers,fxview-reviewers,firefox-style-system-reviewers,ochameau,jsudiaman,dshin

2026-04-16 17:09:40 +00:00

nsIAnonymousContentCreator.h

…

nsIFrame.cpp

Bug 2053610 - Try not to crash if a placeholder frame's out-of-flow is null. r=layout-reviewers,firefox-style-system-reviewers,emilio,TYLin

2026-07-13 18:25:23 +00:00

nsIFrame.h

Bug 2039690: Prevent text selection from originating inside a button-like element for user-select: auto. r=layout-reviewers,emilio

2026-07-08 01:47:42 +00:00

nsIFrameInlines.h

…

nsILineIterator.cpp

…

nsILineIterator.h

…

nsImageFrame.cpp

Bug 2050819 - -moz-image-decoding property. r=tnikkel,layout-reviewers

2026-06-30 17:46:09 +00:00

nsImageFrame.h

Bug 2035992 - Add nsIFrame::GetEventTargetContent() to get proper event target from the given event r=smaug,emilio,layout-reviewers

2026-05-19 08:19:05 +00:00

nsImageMap.cpp

Bug 2045413 - Deal correctly with <area> element removals. r=layout-reviewers,dshin

2026-06-10 22:19:56 +00:00

nsImageMap.h

…

nsInlineFrame.cpp

Bug 2051345 - Remove line-height: -moz-block-height. r=layout-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,dshin

2026-06-29 17:11:08 +00:00

nsInlineFrame.h

Bug 2047392 - Modernize InlineReflowInput. r=jfkthame

2026-06-15 18:24:55 +00:00

nsIntervalSet.cpp

…

nsIntervalSet.h

…

nsIStatefulFrame.h

…

nsLeafFrame.cpp

…

nsLeafFrame.h

…

nsLineBox.cpp

Bug 2048425 - Implement text-box-trim for block containers. r=layout-reviewers,jfkthame,emilio

2026-06-25 04:36:31 +00:00

nsLineBox.h

Bug 2048427 - Add multi-column and block fragmentation support for text-box-trim. r=layout-reviewers,TYLin

2026-07-10 05:15:28 +00:00

nsLineLayout.cpp

Bug 2053288 - Prepare absolute frames before deleting inline's next-in-flows. r=layout-reviewers,dholbert

2026-07-10 20:44:33 +00:00

nsLineLayout.h

Bug 2048427 - Add multi-column and block fragmentation support for text-box-trim. r=layout-reviewers,TYLin

2026-07-10 05:15:28 +00:00

nsPageContentFrame.cpp

Bug 1650944 - Remove ReflowInput.h include from nsIFrame.h r=firefox-style-system-reviewers,layout-reviewers,emilio

2026-05-04 12:06:23 +00:00

nsPageContentFrame.h

…

nsPageFrame.cpp

Bug 1650944 - Remove ReflowInput.h include from nsIFrame.h r=firefox-style-system-reviewers,layout-reviewers,emilio

2026-05-04 12:06:23 +00:00

nsPageFrame.h

…

nsPageSequenceFrame.cpp

Bug 2034406 - Preserve vector commands in MozPrintCallback. r=lsalzman

2026-05-26 11:08:38 +00:00

nsPageSequenceFrame.h

Bug 2034406 - Preserve vector commands in MozPrintCallback. r=lsalzman

2026-05-26 11:08:38 +00:00

nsPlaceholderFrame.cpp

Bug 2053610 - Try not to crash if a placeholder frame's out-of-flow is null. r=layout-reviewers,firefox-style-system-reviewers,emilio,TYLin

2026-07-13 18:25:23 +00:00

nsPlaceholderFrame.h

Bug 2053610 - Try not to crash if a placeholder frame's out-of-flow is null. r=layout-reviewers,firefox-style-system-reviewers,emilio,TYLin

2026-07-13 18:25:23 +00:00

nsQueryFrame.h

…

nsRubyBaseContainerFrame.cpp

…

nsRubyBaseContainerFrame.h

Revert "Bug 2036400 - Initialize uninitialized scalar fields in layout to fix Coverity uninitialized-scalar defects r=layout-reviewers,emilio" for causing build bustages in SVGFilterInstance.h

2026-05-05 07:13:05 +00:00

nsRubyBaseFrame.cpp

…

nsRubyBaseFrame.h

…

nsRubyContentFrame.cpp

…

nsRubyContentFrame.h

…

nsRubyFrame.cpp

Bug 2046373 Part 2 - Skip calling ReflowAbsoluteDescendantsInInlineFrame() if there are no abspos descendants. r=dholbert,layout-reviewers

2026-06-13 14:48:51 +00:00

nsRubyFrame.h

…

nsRubyTextContainerFrame.cpp

…

nsRubyTextContainerFrame.h

…

nsRubyTextFrame.cpp

…

nsRubyTextFrame.h

…

nsSplittableFrame.cpp

Bug 1650944 - Remove ReflowInput.h include from nsIFrame.h r=firefox-style-system-reviewers,layout-reviewers,emilio

2026-05-04 12:06:23 +00:00

nsSplittableFrame.h

…

nsSubDocumentFrame.cpp

Bug 2037754: Use 'MakeAndAddRef' instead of 'new' when allocating runnable for nsContentUtils::AddScriptRunner. r=dom-core,smaug

2026-05-07 06:35:57 +00:00

nsSubDocumentFrame.h

Bug 2034897 - Fix aspect-ratio handling in ComputeSizeWithIntrinsicDimensions. r=boris,firefox-style-system-reviewers,layout-reviewers,firefox-svg-reviewers,longsonr

2026-04-29 22:03:12 +00:00

nsTextFrame.cpp

Bug 2051345 - Remove line-height: -moz-block-height. r=layout-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,dshin

2026-06-29 17:11:08 +00:00

nsTextFrame.h

Bug 1358555 - pass through imgDrawingParams to draw SVG glyphs r=layout-reviewers,emilio

2026-06-27 15:18:45 +00:00

nsTextFrameUtils.cpp

Bug 2048930 - Move some of xpcom's UTF-16 utils to mfbt/Utf16.h. r=jfkthame,necko-reviewers,layout-reviewers

2026-06-23 01:14:55 +00:00

nsTextFrameUtils.h

…

nsTextPaintStyle.cpp

Bug 2029839 - More consistent selection color drawing. r=jjaschke

2026-06-03 19:08:30 +00:00

nsTextPaintStyle.h

Bug 2019153: Round the selection highlight for the urlbar input field r=layout-reviewers,adw,emilio,desktop-theme-reviewers,firefox-style-system-reviewers

2026-04-07 09:38:29 +00:00

nsTextRunTransformations.cpp

Bug 2048930 - Move some of xpcom's UTF-16 utils to mfbt/Utf16.h. r=jfkthame,necko-reviewers,layout-reviewers

2026-06-23 01:14:55 +00:00

nsTextRunTransformations.h

Bug 2045733 - Check for font support before using the capital es-zet (U+1E9E) in uppercase transform. r=layout-reviewers,emilio

2026-06-10 14:08:55 +00:00

nsVideoFrame.cpp

Revert "Bug 2005072 - Implement proposed loading attribute for video and audio elements. r=dom-core-reviewers,media-playback-reviewers,webidl,layout-reviewers,smaug,emilio,pehrsons,alwu,keithamus" for causing wpt leaks @ SetCapacity

2026-07-10 18:22:03 +00:00

nsVideoFrame.h

2026-07-10 18:22:03 +00:00

PrintedSheetFrame.cpp

Bug 1650944 - Remove ReflowInput.h include from nsIFrame.h r=firefox-style-system-reviewers,layout-reviewers,emilio

2026-05-04 12:06:23 +00:00

PrintedSheetFrame.h

…

ReflowInput.cpp

Bug 2054166 - Force reflow floats when the last column is reflowed with an unconstrained block-size. r=layout-reviewers,dshin

2026-07-14 21:05:55 +00:00

ReflowInput.h

Bug 2054166 - Force reflow floats when the last column is reflowed with an unconstrained block-size. r=layout-reviewers,dshin

2026-07-14 21:05:55 +00:00

ReflowOutput.cpp

Bug 2025540: Don't add overflow for abspos if its area is zero. r=layout-reviewers,emilio

2026-03-30 19:34:18 +00:00

ReflowOutput.h

Bug 2048427 - Add multi-column and block fragmentation support for text-box-trim. r=layout-reviewers,TYLin

2026-07-10 05:15:28 +00:00

RubyUtils.cpp

…

RubyUtils.h

Bug 2030235 - Decouple ServoStyleConsts from nsGkAtoms.h r=emilio,necko-reviewers,geckoview-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,kershaw,m_kato

2026-04-09 10:05:25 +00:00

ScrollAnchorContainer.cpp

…

ScrollAnchorContainer.h

Bug 2044221. Save 24 bytes on ScrollContainerFrame. r=layout-reviewers,hiro

2026-06-02 04:09:42 +00:00

ScrollAnimationBezierPhysics.cpp

…

ScrollAnimationBezierPhysics.h

…

ScrollAnimationMSDPhysics.cpp

…

ScrollAnimationMSDPhysics.h

…

ScrollAnimationPhysics.h

…

ScrollbarActivity.cpp

Bug 2026293: Block scripts when initiating async scrollbar activity. r=hiro,layout-reviewers

2026-03-30 20:35:48 +00:00

ScrollbarActivity.h

…

ScrollbarPreferences.h

…

ScrollContainerFrame.cpp

Bug 2035957 - Ignore zero delta smooth script scroll operation if there's no user triggered animation. r=botond

2026-07-13 23:59:58 +00:00

ScrollContainerFrame.h

Bug 2048760 - Reflect APZ scroll generation via ScrollToCSSPixelsForApz rather than ResetScrollInfoIfNeeded. r=botond

2026-06-29 08:02:57 +00:00

ScrollGeneration.cpp

…

ScrollGeneration.h

…

ScrollOrigin.h

…

ScrollPositionUpdate.cpp

Bug 2035957 - Ignore zero delta smooth script scroll operation if there's no user triggered animation. r=botond

2026-07-13 23:59:58 +00:00

ScrollPositionUpdate.h

Bug 2035957 - Ignore zero delta smooth script scroll operation if there's no user triggered animation. r=botond

2026-07-13 23:59:58 +00:00

ScrollSnap.cpp

Bug 1942692 - Choose the scroll offset nearest to the scroll destination for large snap areas. r=ajakobi

2026-06-14 20:35:36 +00:00

ScrollSnap.h

Bug 2037224 - Use operator<< to print an array of snap targets. r=ajakobi

2026-05-06 22:30:26 +00:00

ScrollSnapInfo.cpp

Bug 1942692, 1971979: apply code formatting via Lando

2026-06-14 20:35:48 +00:00

ScrollSnapInfo.h

Bug 1942692 - Choose the scroll offset nearest to the scroll destination for large snap areas. r=ajakobi

2026-06-14 20:35:36 +00:00

ScrollSnapTargetId.h

Bug 2034426 - Remove IsEnumCase. r=gfx-reviewers,lsalzman

2026-04-28 15:22:27 +00:00

ScrollVelocityQueue.cpp

…

ScrollVelocityQueue.h

…

SelectionMovementUtils.cpp

Bug 2038366 - Add a child frame iterator for nsLineBox, and adapt callers. r=layout-reviewers,emilio

2026-05-09 13:56:59 +00:00

SelectionMovementUtils.h

Bug 103422 - Add support for paragraph movement commands on macOS, including their selection variants. r=bradwerth,masayuki

2026-04-21 13:09:47 +00:00

StickyScrollContainer.cpp

…

StickyScrollContainer.h

…

TextDrawTarget.h

Bug 2045407 - Validate surface format properly. r=gfx-reviewers,bradwerth

2026-07-06 10:00:36 +00:00

TextOverflow.cpp

Bug 1358555 - pass through imgDrawingParams to draw SVG glyphs r=layout-reviewers,emilio

2026-06-27 15:18:45 +00:00

TextOverflow.h

Bug 2034989. Use UniquePtr to manage TextOverflow objects in nsBlockFrame::BuildDisplayList to save some stack space. r=layout-reviewers,emilio

2026-04-25 15:41:01 +00:00

ViewportFrame.cpp

Bug 2041516 Part 1 - Assert fresh reflow status at the beginning of AbsoluteContainingBlock::Reflow(). r=layout-reviewers,emilio

2026-05-26 19:07:08 +00:00

ViewportFrame.h

…

Visibility.h

…

WBRFrame.cpp

…

WritingModes.h

…