Tom Ritter 73160a2005 Bug 2046791 - Make Unpremultiply_SSE2 bit-exact to the scalar/NEON un-premultiply r=gfx-reviewers,lsalzman ...

getImageData() on a canvas with non-opaque pixels returned
CPU-architecture-dependent bytes: Unpremultiply_SSE2 used a 16-bit *scaled*
reciprocal (UNPREMULQ_SSE2 + _mm_mulhi_epu16) that rounds down by 1 LSB on a
subset of anti-aliased / alpha pixels, whereas the scalar fallback and NEON
paths use the full 8.16 reciprocal and agree with each other. The result was a
100%-clean x86-vs-ARM split in canvas readback.

Use the full 0xFF00FF/alpha reciprocal (same table as the scalar fallback) and
compute an exact (channel * reciprocal) >> 16 in 16-bit lanes by splitting the
reciprocal into high/low halves:
  (channel*Q)>>16 = mullo(channel, Q>>16) + mulhi(channel, Q&0xFFFF).
This is bit-identical to the scalar/NEON output for all 256x256 (channel,alpha)
pairs (verified exhaustively) and keeps the SIMD path (two 16-bit multiplies +
an add per channel group). Both UnpremultiplyData and UnpremultiplyRow go
through UnpremultiplyVector_SSE2, so this fixes every getImageData caller.

Differential Revision: https://phabricator.services.mozilla.com/D306170

2026-07-13 11:06:27 +00:00

..

unittest

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

2D.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

AutoHelpersWin.h

…

BaseCoord.h

Bug 2037623 p3 - Use macros for trivial ParamTraits implementations r=ipc-reviewers,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,permissions-reviewers,layout-reviewers,dom-worker-reviewers,chutten,farre,timhuang,jari,valentin,aosmond,asuth,nika,dcarver

2026-06-23 13:29:00 +00:00

BaseMargin.h

Bug 2037623 p3 - Use macros for trivial ParamTraits implementations r=ipc-reviewers,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,permissions-reviewers,layout-reviewers,dom-worker-reviewers,chutten,farre,timhuang,jari,valentin,aosmond,asuth,nika,dcarver

2026-06-23 13:29:00 +00:00

BasePoint3D.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

BasePoint4D.h

…

BasePoint.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

BaseRect.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

BaseSize.h

Bug 2037623 p3 - Use macros for trivial ParamTraits implementations r=ipc-reviewers,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,permissions-reviewers,layout-reviewers,dom-worker-reviewers,chutten,farre,timhuang,jari,valentin,aosmond,asuth,nika,dcarver

2026-06-23 13:29:00 +00:00

BezierUtils.cpp

…

BezierUtils.h

…

BigEndianInts.h

…

Blur.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

Blur.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

BorrowedContext.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

BufferEdgePad.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

BufferEdgePad.h

…

BufferUnrotate.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

BufferUnrotate.h

…

ConvolutionFilter.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ConvolutionFilter.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ConvolutionFilterAVX2.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ConvolutionFilterNEON.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ConvolutionFilterSSE2.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

Coord.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

CriticalSection.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

DataSourceSurface.cpp

…

DataSourceSurfaceWrapper.h

…

DataSurfaceHelpers.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

DataSurfaceHelpers.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

DrawEventRecorder.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

DrawEventRecorder.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

DrawEventRecorderTypes.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

DrawTarget.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

DrawTargetCairo.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

DrawTargetCairo.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

DrawTargetOffset.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

DrawTargetOffset.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

DrawTargetRecording.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

DrawTargetRecording.h

Bug 2034406 - Preserve vector commands in MozPrintCallback. r=lsalzman

2026-05-26 11:08:38 +00:00

DrawTargetSkia.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

DrawTargetSkia.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

DWriteSettings.cpp

…

DWriteSettings.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

Factory.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

FilterNodeSoftware.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

FilterNodeSoftware.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

FilterProcessing.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

FilterProcessing.h

…

FilterProcessingScalar.cpp

…

FilterProcessingSIMD-inl.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

FilterProcessingSSE2.cpp

…

Filters.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

FontFeature.h

…

FontVariation.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

GenericRefCounted.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

gfx2d.sln

…

gfx2d.vcxproj

…

Helpers.h

…

HelpersCairo.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

HelpersSkia.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

HelpersWin.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

HelpersWinFonts.h

…

ImageScaling.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ImageScaling.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ImageScalingSSE2.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

InlineTranslator.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

InlineTranslator.h

…

IterableArena.h

…

Logging.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

LoggingConstants.h

…

LuminanceNEON.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

LuminanceNEON.h

…

MacIOSurface.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

MacIOSurface.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

Matrix.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

Matrix.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

MatrixFwd.h

…

MMIHelpers.h

…

moz.build

…

NativeFontResource.cpp

…

NativeFontResourceDWrite.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

NativeFontResourceDWrite.h

…

NativeFontResourceFreeType.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

NativeFontResourceFreeType.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

NativeFontResourceGDI.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

NativeFontResourceGDI.h

…

NativeFontResourceMac.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

NativeFontResourceMac.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

NumericTools.h

…

Path.cpp

…

PathAnalysis.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

PathCairo.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

PathCairo.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

PathHelpers.cpp

…

PathHelpers.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

PathRecording.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

PathRecording.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

PathSkia.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

PathSkia.h

Bug 2042256 - Fix Moz2D for Skia m149. r=gfx-reviewers,nical

2026-05-30 02:22:37 +00:00

PatternHelpers.h

…

Point.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

Polygon.h

…

Quaternion.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

Quaternion.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

RecordedEvent.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

RecordedEvent.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

RecordedEventImpl.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

RecordingTypes.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

Rect.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

RectAbsolute.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

Scale.h

…

ScaledFontBase.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ScaledFontBase.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ScaledFontDWrite.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ScaledFontDWrite.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ScaledFontFontconfig.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ScaledFontFontconfig.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ScaledFontFreeType.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ScaledFontFreeType.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ScaledFontMac.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ScaledFontMac.h

…

ScaledFontWin.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ScaledFontWin.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

ScaleFactor.h

Bug 2037623 p3 - Use macros for trivial ParamTraits implementations r=ipc-reviewers,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,permissions-reviewers,layout-reviewers,dom-worker-reviewers,chutten,farre,timhuang,jari,valentin,aosmond,asuth,nika,dcarver

2026-06-23 13:29:00 +00:00

ScaleFactors2D.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

SFNTData.cpp

…

SFNTData.h

…

SIMD.h

…

SkConvolver.cpp

Bug 2045626: Compute range of convolve filter in integer domain. r=gfx-reviewers,lsalzman

2026-06-22 19:42:49 +00:00

SkConvolver.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

SourceSurfaceCairo.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

SourceSurfaceCairo.h

…

SourceSurfaceD3D11.cpp

…

SourceSurfaceD3D11.h

…

SourceSurfaceRawData.cpp

…

SourceSurfaceRawData.h

Bug 2041298 - Comply with clang-tidy's modernize-use-nullptr check for gfx/ r=gfx-reviewers,aosmond

2026-05-25 15:20:15 +00:00

SourceSurfaceSkia.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

SourceSurfaceSkia.h

…

SSEHelpers.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

StackArray.h

…

SVGTurbulenceRenderer-inl.h

…

Swizzle.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

Swizzle.h

…

SwizzleAVX2.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

SwizzleNEON.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

SwizzleSSE2.cpp

Bug 2046791 - Make Unpremultiply_SSE2 bit-exact to the scalar/NEON un-premultiply r=gfx-reviewers,lsalzman

2026-07-13 11:06:27 +00:00

SwizzleSSSE3.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

Tools.h

…

Triangle.h

…

Types.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

Types.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

UnscaledFontDWrite.h

…

UnscaledFontFreeType.cpp

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

UnscaledFontFreeType.h

…

UnscaledFontGDI.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00

UnscaledFontMac.h

…

UserData.h

Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

2026-07-13 09:51:18 +00:00