Commit Graph
365 Commits
Author SHA1 Message Date
94590e6e4c Bug 506645 nsTypedSelection::AddItem doesn't always null check aOutIndex
r=smaug
2009-08-12 11:49:55 +02:00
6d008046f5 Bug 506258 nsFrameSelection::ConstrainFrameAndPointToAnchorSubtree doesn't seem to use anchorFrame or anchorFrameOffset
r=roc
2009-08-12 11:49:54 +02:00
Robert O'Callahan 460661ab30 Bug 506874. Don't temporarily remove ranges from the selection while we alter the frame state. Also adds a bunch of selection tests. r=smaug 2009-08-03 14:12:57 +12:00
Michael Kohler 64897ba879 Bug 106386 - Correct misspellings in source code (old); Part 2; r=timeless 2009-07-27 10:47:02 +02:00
Robert O'Callahan 4c8901bcd6 Bug 371839. Simplify SetSelected signature and semantics, and reimplement it in nsTextFrame much more efficiently. r=bzbarsky 2009-07-27 10:05:41 +12:00
Graeme McCutcheon b3199d96ba Bug 348681 follow-up comment fix. 2009-05-09 22:36:17 +01:00
Graeme McCutcheon e6be8bd8f1 Bug 348681 - Don't allow overlapping ranges in the selection. r+sr=roc 2009-05-09 22:30:19 +01:00
L. David Baron eec1c608d2 Traverse and unlink selection listeners. (Bug 490071) r+sr=peterv 2009-05-08 21:59:26 -07:00
Masayuki Nakano ec1b9e13de Bug 482138 [TSF] nsTextFrame has to draw composition string by TIP specified style r+sr=roc 2009-04-23 12:27:12 +09:00
Boris Zbarsky af20b69833 Bug 488417. Need to hold strong refs to ranges across calling RemoveRange. r+sr=roc 2009-04-21 15:57:40 -04:00
Boris Zbarsky 3e243b70a7 Bug 486547. Fix build bustage on Windows 2009-04-06 14:39:02 -04:00
Boris Zbarsky 3e49316625 Bug 486547 part 7. Simplify some more of the table code in nsFrameSelection. r+sr=smaug 2009-04-06 13:21:30 -04:00
Boris Zbarsky 3848d40645 Bug 486547 part 6. Simplify some cell-related code in nsFrameSelection. r+sr=smaug 2009-04-06 13:20:32 -04:00
Boris Zbarsky a3d4d12819 Bug 486547 part 5. Switch various table cell selection stuff off nsIDOMRange. r+sr=smaug 2009-04-06 13:20:30 -04:00
Boris Zbarsky a139f74f21 Bug 486547 part 4. Switch some more code off nsIDOMNode/nsIDOMRange r+sr=smaug 2009-04-06 13:17:38 -04:00
Boris Zbarsky eb7348f77b Bug 486547 part 3. Eliminate the Fetch*Node methods of nsTypedSelection. r+sr=smaug 2009-04-06 13:17:38 -04:00
Boris Zbarsky 5643d10223 Bug 486547 part 2. Switch nsFrameSelection::mMaintainRange to storing nsIRange, not nsIDOMRange. r+sr=smaug 2009-04-06 13:17:38 -04:00
Boris Zbarsky 8345246709 Bug 486547 part 1. Switch nsTypedSelection to storing nsIRange, not nsIDOMRange, objects. r+sr=smaug 2009-04-06 13:17:37 -04:00
Olli Pettay 0b3823aa3b Bug 478245 - Crash [@ nsEventStateManager::PreHandleEvent], r+sr=dbaron 2009-03-11 17:43:08 +02:00
Olli Pettay 606e57d58a Bug 466856 - Crash [@ nsTypedSelection::CopyRangeToAnchorFocus], r+sr=roc 2009-02-26 18:36:34 +02:00
Peter Van der Beken 30d54eb9a7 Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles). r=bent, sr=bz. 2009-01-14 13:24:10 +01:00
Peter Van der Beken 4c7b70dbc9 Back out changeset 9fd8740decb8 (Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles).) to try to fix orange. 2009-01-14 15:12:37 +01:00
Peter Van der Beken a638221f4a Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles). r=bent, sr=bz. 2009-01-14 13:24:10 +01:00
Benjamin Smedberg 0f95227641 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
2009-01-12 14:20:59 -05:00
Benjamin Smedberg 7a084ac404 Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg 991a16d8bc Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Uri Bernstein f07bc84d72 Set mMaintainRange to null when there is no selection. b=470212 r=mats sr=roc 2009-01-08 22:17:49 +01:00
Mats Palmgren 0eb7b02ef8 Don't crash if views were destroyed while flushing notifications. b=421839 r+sr=roc 2008-12-08 00:11:37 +01:00
Vladimir Vukicevic 42e5c567b6 b=461813, crash in nsFrameSelection::HandleDrag; r+sr=roc 2008-11-04 11:29:13 -08:00
Markus Stange 615b3a4ee1 Bug 462793 - Changing listbox selection with keyboard no longer scrolls to make the newly selected item visible, r+sr=roc 2008-11-04 15:38:16 +01:00
Benjamin Smedberg 91a3d948e0 Bug 461212 - deCOM frame traversal (relanding) r=mats.palmgren sr=roc 2008-10-30 10:15:22 -07:00
Benjamin Smedberg f4133116e4 Backed out changeset affcc1c08bc0 (deCOM frame enumerator) due to regression from it or bug 461410. 2008-10-28 02:47:40 -04:00
Benjamin Smedberg e6bf9e93fd Bug 461212 - deCOM frame enumerator, r=mats.palmgren sr=roc 2008-10-28 00:47:19 -04:00
Uri Bernstein ab84639432 Bug 459921 - Double-click-and-drag selects previous word when dragging to left half of first letter of a word. r+sr=roc. 2008-10-21 11:52:52 +02:00
Uri Bernstein c72ab700ee Bug 415707 - multiple text selection improvement doesn't work with double-click "word-by-word" or triple-click "paragraph" modes. r+sr=roc. 2008-10-17 21:46:33 +02:00
Theppitak Karoonboonyanan 1703d4c904 Bug 157546. The 'delete' key should delete an entire cluster. r=peterv,r+sr=roc 2008-10-16 20:44:32 +13:00
Olli Pettay e4345417cd bug 302775 - extractContents doesn't work if start and end node of a Range object is an attribute node, r=peterv, sr=sicking 2008-10-15 12:40:28 +03:00
Uri Bernstein bd1f6dba4a Bug 459660: Remove two unused members of nsTypedSelection and their accessors. r+sr=roc. 2008-10-13 23:25:21 +02:00
Uri Bernstein 760fdefd8c Bug 459588: Kill OLD_SELECTION code. r+sr=roc. 2008-10-13 00:11:51 +02:00
Uri Bernstein fc382ab3d0 Bug 426766: Cursor keys behave weirdly in "view source" window. r+sr=roc. 2008-10-09 12:07:16 +02:00
Uri Bernstein 45724fce6e Bug 458089: Kill VISUALSELECTION code. r=smontagu, sr=roc. 2008-10-09 12:05:30 +02:00
Alexander Surkov b50bd7e887 Bug 456944 - Crash when spell checking selection changes, r=smaug, sr=roc 2008-10-08 20:53:14 +08:00
Graeme McCutcheon 93b55448a4 Bug 451252 - "Highlight All" find selection not visible in elements that have -moz-user-select: none set; r+sr=roc 2008-09-07 16:12:50 +02:00
Uri Bernstein 8c618073ad Merge commit for bug 210197 2008-08-09 19:34:08 +03:00
Uri Bernstein b5db30ef38 Unconditionally reset mDragSelectingCells to false on mouse-up, so that the system doesn't remain in table selection mode when dragging outside a table. bug=210197. r+sr=mats.palmgren 2008-08-09 18:09:37 +03:00
Asaf Romano 95767c850b Bug 263683 - Findbar's Highlight feature should not manipulate the DOM. Patch by Graeme McCutcheon <graememcc_firefox@graeme-online.co.uk>, r=me,roc. sr=roc. 2008-07-30 23:48:56 +03:00
b78179b566 bug 345759 - Spell as you type not accessible, r=aaronlev, r=Olli.Pettay, sr=neil 2008-07-17 14:06:24 +02:00
John Daniels 2aef16c1bf Bug 419532 – deCOMtaminate nsICaret. r+sr=roc 2008-07-16 12:52:01 +02:00
Benjamin Smedberg 8886216dff Bug 442729 - Annotate stack-only classes in layout, r+sr=roc 2008-07-01 15:16:45 -04:00
6971cc0752 Bug 423523: Caret can leave div w/ contenteditable = true with repeated arrow keys, patch by Chris Pearce <chris@pearce.org.nz>, r+sr=peterv, a=beltzner 2008-04-23 15:33:14 -07:00