- mozac_ic_arrow_trending_up_24 was renamed to mozac_ic_arrow_trending_24 in the acorn-icons upstream repo and mozac_ic_arrow_trending_24 already exists in ui-icons component. This is a de-duplication change.
Differential Revision: https://phabricator.services.mozilla.com/D311868
This is the same limit we already apply for multiple other scenarios in the app.
Capping the query bounds every path that feeds the toolbar: tap-to-edit prefill,
the toolbar's "Paste" action (PasteFromClipboardClicked → SearchQueryUpdated → query),
voice, QR, and Lens.
All of them are now ≤ 25k before they reach rememberTextFieldState/BasicTextField.
Differential Revision: https://phabricator.services.mozilla.com/D309534
While the page is loaded the site info button is not actionable.
Waiting in UI tests until the page is loaded and the info button becomes
actionable was hard.
Until now.
Differential Revision: https://phabricator.services.mozilla.com/D309820
AndroidX Core 1.19 folds the core-ktx artifact into core, so drop the androidx-core-ktx catalog
alias and move consumers from libs.androidx.core.ktx to libs.androidx.core.
Differential Revision: https://phabricator.services.mozilla.com/D309650
These `import org.jetbrains.kotlin.gradle.tasks.KotlinCompile` statements are not referenced by any
build script; the type is unused, so drop the dead imports.
Differential Revision: https://phabricator.services.mozilla.com/D309478
Move the kotlinx-serialization, parcelize, safeargs, KSP, jacoco, and maven-publish plugins from
imperative apply syntax to the plugins {} block, using version-catalog aliases. Plugins supplied via
the buildscript classpath (parcelize, safeargs) use versionless catalog entries so the plugins DSL
does not attempt a compatibility check against their unknown classpath version.
Applying kotlinx-serialization through the plugins DSL also makes its dedicated buildscript classpath
dependency redundant, so drop the now-vestigial buildscript blocks from the affected modules.
Differential Revision: https://phabricator.services.mozilla.com/D309477
Updates android-gradle-plugin to 9.2.1 (lint 32.2.1) and migrates off the
org.jetbrains.kotlin.android plugin to AGP's built-in Kotlin, pinning the Kotlin version on each
root's buildscript classpath and applying the com.android.library/application plugins through the
plugins DSL.
Differential Revision: https://phabricator.services.mozilla.com/D309476
After the recent Compose update, currentWindowAdaptiveInfo()'s reported
window size lags behind onConfigurationChange following a rotation
(https://issuetracker.google.com/issues/515098186), leaving the toolbar
with portrait padding while in landscape and vice versa.
Read the available width synchronously at measure time instead, via a
small layout modifier that picks the horizontal padding from the incoming
constraints. This keeps the toolbar's content in the normal composition
pass while reacting to the actual measured width.
Differential Revision: https://phabricator.services.mozilla.com/D303998
The autocomplete suggestion is rendered via an OutputTransformation and is
not part of the real editable text, so keyboards cannot move the cursor into
it through normal cursor-control.
Will wrap the IME's InputConnection so that the setSelection patterns those
gestures emit are translated into a suggestion accept:
- cursor moves from inside the real query to its end,
- redundant setSelection(text.length, text.length) (Gboard spacebar swipe),
- request for a cursor position inside the visible suggestion suffix.
DPAD_RIGHT routed through sendKeyEvent is handled the same way.
The heuristic for whether to commit the current suggestion or not is extracted
as shouldAcceptSuggestionOnSelectionUpdate to be unit tested.
The functionality was tested with GBoard, Heliboard, Swiftkey and Fcitx5.
Differential Revision: https://phabricator.services.mozilla.com/D301501
This reverts commit 4d401f74e3.
Revert "Bug 2033713 - Force hiding the IME when the editable address bar looses focus or leaves composition r=android-reviewers,mcarare"
This reverts commit 02882569c6.
Revert "Bug 2042361 - Derive the toolbar's adaptive padding from the measured width r=android-reviewers,Roger"
This reverts commit 7edd10f5b8.
Revert "Bug 2036586 - Confirm URL suggestion on spacebar swipe right in the new Compose toolbar r=android-reviewers,mcarare"
This reverts commit 3e8397a0aa.
Revert "Bug 2044610 - Remove autocomplete suggestion state when search ends r=android-reviewers,Roger"
This reverts commit aebf738da6.
Revert "Bug 2044584 - Have toolbar's contextual menu hide when the query is edited r=android-reviewers,mcarare"
This reverts commit 2479bf776a.
After the recent Compose update, currentWindowAdaptiveInfo()'s reported
window size lags behind onConfigurationChange following a rotation
(https://issuetracker.google.com/issues/515098186), leaving the toolbar
with portrait padding while in landscape and vice versa.
Read the available width synchronously at measure time instead, via a
small layout modifier that picks the horizontal padding from the incoming
constraints. This keeps the toolbar's content in the normal composition
pass while reacting to the actual measured width.
Differential Revision: https://phabricator.services.mozilla.com/D303998
The autocomplete suggestion is rendered via an OutputTransformation and is
not part of the real editable text, so keyboards cannot move the cursor into
it through normal cursor-control.
Will wrap the IME's InputConnection so that the setSelection patterns those
gestures emit are translated into a suggestion accept:
- cursor moves from inside the real query to its end,
- redundant setSelection(text.length, text.length) (Gboard spacebar swipe),
- request for a cursor position inside the visible suggestion suffix.
DPAD_RIGHT routed through sendKeyEvent is handled the same way.
The heuristic for whether to commit the current suggestion or not is extracted
as shouldAcceptSuggestionOnSelectionUpdate to be unit tested.
The functionality was tested with GBoard, Heliboard, Swiftkey and Fcitx5.
Differential Revision: https://phabricator.services.mozilla.com/D301501
Gabriel Luong