Bug 2031661 - Part 6: Add missing cycle collection entries in dom/(misc) r=dom-core,smaug
The intent is that cycle collectible members should be cycle collected unless there's a good reason not to. Differential Revision: https://phabricator.services.mozilla.com/D299784
This commit is contained in:
committed by
krosylight@mozilla.com
parent
d0409cf06a
commit
defccdbbac
@@ -1054,13 +1054,13 @@ NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE_CLASS(Geolocation)
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN(Geolocation)
|
||||
tmp->Shutdown();
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK(mPendingCallbacks, mWatchingCallbacks,
|
||||
mPendingRequests)
|
||||
mBrowsingContext, mPendingRequests)
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK_PRESERVED_WRAPPER
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK_WEAK_PTR
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK_END
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN(Geolocation)
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mPendingCallbacks, mWatchingCallbacks,
|
||||
mPendingRequests)
|
||||
mBrowsingContext, mPendingRequests)
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END
|
||||
|
||||
Geolocation::Geolocation()
|
||||
|
||||
@@ -114,7 +114,8 @@ class GetPermissionRunnable final : public WorkerMainThreadRunnable {
|
||||
} // anonymous namespace
|
||||
|
||||
NS_IMPL_CYCLE_COLLECTION_INHERITED(NotificationPermissionRequest,
|
||||
ContentPermissionRequestBase, mCallback)
|
||||
ContentPermissionRequestBase, mCallback,
|
||||
mPromise)
|
||||
NS_IMPL_ADDREF_INHERITED(NotificationPermissionRequest,
|
||||
ContentPermissionRequestBase)
|
||||
NS_IMPL_RELEASE_INHERITED(NotificationPermissionRequest,
|
||||
|
||||
@@ -30,6 +30,7 @@ NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INHERITED(PaymentResponse,
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mRequest)
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mShippingAddress)
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mPromise)
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mRetryPromise)
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mTimer)
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END
|
||||
|
||||
@@ -38,6 +39,7 @@ NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED(PaymentResponse,
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK(mRequest)
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK(mShippingAddress)
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK(mPromise)
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK(mRetryPromise)
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK(mTimer)
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK_END
|
||||
|
||||
|
||||
@@ -18,12 +18,14 @@ NS_IMPL_ADDREF_INHERITED(VRDisplayEvent, Event)
|
||||
NS_IMPL_RELEASE_INHERITED(VRDisplayEvent, Event)
|
||||
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INHERITED(VRDisplayEvent, Event)
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mDisplay)
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END
|
||||
|
||||
NS_IMPL_CYCLE_COLLECTION_TRACE_BEGIN_INHERITED(VRDisplayEvent, Event)
|
||||
NS_IMPL_CYCLE_COLLECTION_TRACE_END
|
||||
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED(VRDisplayEvent, Event)
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK(mDisplay)
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK_END
|
||||
|
||||
NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(VRDisplayEvent)
|
||||
|
||||
@@ -29,10 +29,12 @@ NS_IMPL_CYCLE_COLLECTION_CLASS(Buffer)
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN(Buffer)
|
||||
tmp->Cleanup();
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK(mParent)
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK(mMapRequest)
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK_PRESERVED_WRAPPER
|
||||
NS_IMPL_CYCLE_COLLECTION_UNLINK_END
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN(Buffer)
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mParent)
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mMapRequest)
|
||||
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END
|
||||
NS_IMPL_CYCLE_COLLECTION_TRACE_BEGIN(Buffer)
|
||||
NS_IMPL_CYCLE_COLLECTION_TRACE_PRESERVED_WRAPPER
|
||||
|
||||
Reference in New Issue
Block a user