Bug 2067994 - Cleanup some webrender pref usage. r=nical,gfx-reviewers

Makes it more obvious where they're used.

Differential Revision: https://phabricator.services.mozilla.com/D322871

gfx/config/gfxConfigManager.cpp

@@ -47,8 +47,7 @@ void gfxConfigManager::Init() {
                   mWrAngleEnabled);
 #ifdef XP_WIN
   mWrRequireAngle = StaticPrefs::gfx_webrender_require_angle_AtStartup();
-  mWrDCompWinEnabled =
-      Preferences::GetBool("gfx.webrender.dcomp-win.enabled", false);
+  mWrDCompWinEnabled = StaticPrefs::gfx_webrender_dcomp_win_enabled_AtStartup();
 #endif
 
   mWrEnvForceEnabled = gfxPlatform::WebRenderEnvvarEnabled();

gfx/thebes/gfxPlatform.cpp

@@ -565,9 +565,7 @@ static void WebRenderDebugPrefChangeCallback(const char* aPrefName, void*) {
 #undef GFX_WEBRENDER_DEBUG
   gfx::gfxVars::SetWebRenderDebugFlags(flags._0);
 
-  uint32_t threshold = Preferences::GetFloat(
-      StaticPrefs::GetPrefName_gfx_webrender_debug_slow_cpu_frame_threshold(),
-      10.0);
+  float threshold = StaticPrefs::gfx_webrender_debug_slow_cpu_frame_threshold();
   gfx::gfxVars::SetWebRenderSlowCpuFrameThreshold(threshold);
 }
 
@@ -576,25 +574,19 @@ static void WebRenderQualityPrefChangeCallback(const char* aPref, void*) {
 }
 
 static void WebRenderBatchingPrefChangeCallback(const char* aPrefName, void*) {
-  uint32_t count = Preferences::GetUint(
-      StaticPrefs::GetPrefName_gfx_webrender_batching_lookback(), 10);
-
+  uint32_t count = StaticPrefs::gfx_webrender_batching_lookback();
   gfx::gfxVars::SetWebRenderBatchingLookback(count);
 }
 
 static void WebRenderBlobTileSizePrefChangeCallback(const char* aPrefName,
                                                     void*) {
-  uint32_t tileSize = Preferences::GetUint(
-      StaticPrefs::GetPrefName_gfx_webrender_blob_tile_size(), 256);
+  uint32_t tileSize = StaticPrefs::gfx_webrender_blob_tile_size();
   gfx::gfxVars::SetWebRenderBlobTileSize(tileSize);
 }
 
 static void WebRenderUploadThresholdPrefChangeCallback(const char* aPrefName,
                                                        void*) {
-  int value = Preferences::GetInt(
-      StaticPrefs::GetPrefName_gfx_webrender_batched_upload_threshold(),
-      512 * 512);
-
+  int value = StaticPrefs::gfx_webrender_batched_upload_threshold();
   gfxVars::SetWebRenderBatchedUploadThreshold(value);
 }
 
@@ -2883,16 +2875,14 @@ void gfxPlatform::InitWebRenderConfig() {
     gfxVars::SetReuseDecoderDevice(true);
   }
 
-  if (Preferences::GetBool("gfx.webrender.flip-sequential", false)) {
-    if (gfxVars::UseWebRenderANGLE()) {
-      gfxVars::SetUseWebRenderFlipSequentialWin(true);
-    }
+  if (StaticPrefs::gfx_webrender_flip_sequential_AtStartup() &&
+      gfxVars::UseWebRenderANGLE()) {
+    gfxVars::SetUseWebRenderFlipSequentialWin(true);
   }
-  if (Preferences::GetBool("gfx.webrender.triple-buffering.enabled", false)) {
-    if (gfxVars::UseWebRenderDCompWin() ||
-        gfxVars::UseWebRenderFlipSequentialWin()) {
-      gfxVars::SetUseWebRenderTripleBufferingWin(true);
-    }
+  if (StaticPrefs::gfx_webrender_triple_buffering_enabled_AtStartup() &&
+      (gfxVars::UseWebRenderDCompWin() ||
+       gfxVars::UseWebRenderFlipSequentialWin())) {
+    gfxVars::SetUseWebRenderTripleBufferingWin(true);
   }
 
   if (StaticPrefs::

modules/libpref/init/StaticPrefList.yaml

@@ -8160,6 +8160,21 @@
   type: bool
   value: true
   mirror: once
+
+- name: gfx.webrender.flip-sequential
+  type: bool
+  value: false
+  mirror: once
+
+- name: gfx.webrender.dcomp-win.enabled
+  type: bool
+  value: false
+  mirror: once
+
+- name: gfx.webrender.triple-buffering.enabled
+  type: bool
+  value: true
+  mirror: once
 #endif
 
 - name: gfx.webrender.svg-filter-effects

modules/libpref/init/all.js

@@ -398,12 +398,6 @@ pref("gfx.downloadable_fonts.fallback_delay_short", 100);
 pref("gfx.canvas.azure.backends", "skia");
 pref("gfx.content.azure.backends", "skia");
 
-#ifdef XP_WIN
-  pref("gfx.webrender.flip-sequential", false);
-  pref("gfx.webrender.dcomp-win.enabled", true);
-  pref("gfx.webrender.triple-buffering.enabled", true);
-#endif
-
 // WebRender debugging utilities.
 pref("gfx.webrender.debug.texture-cache", false);
 pref("gfx.webrender.debug.texture-cache.clear-evicted", true);