Bug 2062487 - Refresh the Android lint baselines. r=android-reviewers,adhingra

The growth is the findings whose suppressions came off earlier in this stack, recorded here so that the
work they were hiding is visible somewhere, plus the single finding Focus picks up from the shared
configuration.

One entry is not ours: a JUnitAssertNotNull warning that has been in the tree for a while without ever
reaching a baseline, and which the refresh picks up along the way.

Differential Revision: https://phabricator.services.mozilla.com/D317707

mobile/android/android-components/components/browser/menu/lint-baseline.xml

@@ -1,4 +1,20 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <issues format="6" by="lint 9.2.1" type="baseline" client="gradle" dependencies="false" name="AGP (9.2.1)" variant="all" version="9.2.1">
 
+    <issue
+        id="RtlCompat"
+        message="Inconsistent alignment specification between `textAlignment` and `gravity` attributes: was `center_vertical`, expected `start`"
+        errorLine1="        android:textAlignment=&quot;viewStart&quot;"
+        errorLine2="                               ~~~~~~~~~">
+        <location
+            file="src/main/res/layout/mozac_browser_menu_web_extension.xml"
+            line="30"
+            column="32"/>
+        <location
+            file="src/main/res/layout/mozac_browser_menu_web_extension.xml"
+            line="29"
+            column="26"
+            message="Incompatible direction here"/>
+    </issue>
+
 </issues>

mobile/android/android-components/components/browser/toolbar/lint-baseline.xml

@@ -1,4 +1,26 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <issues format="6" by="lint 9.2.1" type="baseline" client="gradle" dependencies="false" name="AGP (9.2.1)" variant="all" version="9.2.1">
 
+    <issue
+        id="ContentDescription"
+        message="Missing `contentDescription` attribute on image"
+        errorLine1="    &lt;ImageView"
+        errorLine2="     ~~~~~~~~~">
+        <location
+            file="src/main/res/layout/mozac_browser_toolbar_displaytoolbar.xml"
+            line="42"
+            column="6"/>
+    </issue>
+
+    <issue
+        id="ContentDescription"
+        message="Missing `contentDescription` attribute on image"
+        errorLine1="    &lt;ImageView"
+        errorLine2="     ~~~~~~~~~">
+        <location
+            file="src/main/res/layout/mozac_browser_toolbar_edittoolbar.xml"
+            line="27"
+            column="6"/>
+    </issue>
+
 </issues>

mobile/android/android-components/components/feature/ipprotection/lint-baseline.xml

@@ -1,4 +1,15 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <issues format="6" by="lint 9.2.1" type="baseline" client="gradle" dependencies="false" name="AGP (9.2.1)" variant="all" version="9.2.1">
 
+    <issue
+        id="JUnitAssertNotNull"
+        message="Use kotlin.test.assertNotNull instead of JUnit assertNotNull"
+        errorLine1="            assertNotNull(resultState.locationState.locations.find { it.countryCode == country.code })"
+        errorLine2="            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/test/java/mozilla/components/feature/ipprotection/store/IPProtectionReducerTest.kt"
+            line="662"
+            column="13"/>
+    </issue>
+
 </issues>

mobile/android/android-components/components/feature/prompts/lint-baseline.xml

@@ -23,4 +23,15 @@
             column="6"/>
     </issue>
 
+    <issue
+        id="Autofill"
+        message="Missing `autofillHints` attribute"
+        errorLine1="        &lt;EditText"
+        errorLine2="         ~~~~~~~~">
+        <location
+            file="src/main/res/layout/mozac_feature_text_prompt.xml"
+            line="29"
+            column="10"/>
+    </issue>
+
 </issues>

mobile/android/android-components/samples/browser/lint-baseline.xml

@@ -1,4 +1,15 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <issues format="6" by="lint 9.2.1" type="baseline" client="gradle" dependencies="false" name="AGP (9.2.1)" variant="all" version="9.2.1">
 
+    <issue
+        id="ContentDescription"
+        message="Missing `contentDescription` attribute on image"
+        errorLine1="        &lt;com.google.android.material.floatingactionbutton.FloatingActionButton"
+        errorLine2="         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/res/layout/fragment_browser.xml"
+            line="68"
+            column="10"/>
+    </issue>
+
 </issues>

mobile/android/android-components/samples/compose-browser/lint-baseline.xml

@@ -1,4 +1,15 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <issues format="6" by="lint 9.2.1" type="baseline" client="gradle" dependencies="false" name="AGP (9.2.1)" variant="all" version="9.2.1">
 
+    <issue
+        id="DataExtractionRules"
+        message="The attribute `android:dataExtractionRules` only applies for Android 12 and higher; since `minSdkVersion` is API 26 you should also set `android:fullBackupContent`"
+        errorLine1="        android:dataExtractionRules=&quot;@xml/data_extraction_rules&quot;>"
+        errorLine2="                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/AndroidManifest.xml"
+            line="43"
+            column="38"/>
+    </issue>
+
 </issues>

mobile/android/android-components/samples/dataprotect/lint-baseline.xml

@@ -1,4 +1,15 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <issues format="6" by="lint 9.2.1" type="baseline" client="gradle" dependencies="false" name="AGP (9.2.1)" variant="all" version="9.2.1">
 
+    <issue
+        id="DataExtractionRules"
+        message="The attribute `android:dataExtractionRules` only applies for Android 12 and higher; since `minSdkVersion` is API 26 you should also set `android:fullBackupContent`"
+        errorLine1="        android:dataExtractionRules=&quot;@xml/data_extraction_rules&quot;"
+        errorLine2="                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/AndroidManifest.xml"
+            line="15"
+            column="38"/>
+    </issue>
+
 </issues>

mobile/android/android-components/samples/sync-logins/lint-baseline.xml

@@ -1,4 +1,15 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <issues format="6" by="lint 9.2.1" type="baseline" client="gradle" dependencies="false" name="AGP (9.2.1)" variant="all" version="9.2.1">
 
+    <issue
+        id="UselessParent"
+        message="This `LinearLayout` layout or its `RelativeLayout` parent is possibly unnecessary"
+        errorLine1="    &lt;LinearLayout"
+        errorLine2="     ~~~~~~~~~~~~">
+        <location
+            file="src/main/res/layout/activity_main.xml"
+            line="15"
+            column="6"/>
+    </issue>
+
 </issues>

mobile/android/android-components/samples/sync/lint-baseline.xml

@@ -1,4 +1,15 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <issues format="6" by="lint 9.2.1" type="baseline" client="gradle" dependencies="false" name="AGP (9.2.1)" variant="all" version="9.2.1">
 
+    <issue
+        id="UselessParent"
+        message="This `ScrollView` layout or its `RelativeLayout` parent is unnecessary"
+        errorLine1="    &lt;ScrollView"
+        errorLine2="     ~~~~~~~~~~">
+        <location
+            file="src/main/res/layout/activity_main.xml"
+            line="14"
+            column="6"/>
+    </issue>
+
 </issues>

mobile/android/fenix/app/lint-baseline.xml

@@ -30,7 +30,7 @@
         errorLine2="~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
         <location
             file="src/main/java/org/mozilla/fenix/browser/tabstrip/TabStrip.kt"
-            line="34"
+            line="33"
             column="1"/>
     </issue>
 
@@ -52,7 +52,7 @@
         errorLine2="               ~~~~~~~~~~~">
         <location
             file="src/main/java/org/mozilla/fenix/components/lens/LensCameraFragment.kt"
-            line="209"
+            line="211"
             column="16"/>
     </issue>
 
@@ -96,7 +96,7 @@
         errorLine2="        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
         <location
             file="src/main/java/org/mozilla/fenix/ext/Context.kt"
-            line="80"
+            line="78"
             column="9"/>
     </issue>
 
@@ -217,7 +217,7 @@
         errorLine2="             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
         <location
             file="src/main/res/layout/fragment_browser.xml"
-            line="48"
+            line="47"
             column="14"/>
     </issue>
 

mobile/android/focus-android/app/lint-baseline.xml

@@ -144,6 +144,13 @@
             column="21"/>
     </issue>
 
+    <issue
+        id="ConvertToWebp"
+        message="One or more images in this project can be converted to the WebP format which typically results in smaller file sizes, even for lossless conversion">
+        <location
+            file="src/main/res/drawable-nodpi/onboarding_second_screen_icon.png"/>
+    </issue>
+
     <issue
         id="MonochromeLauncherIcon"
         message="The application adaptive icon is missing a monochrome tag"

mobile/android/geckoview/lint-baseline.xml

@@ -63,7 +63,7 @@
         errorLine2="          ~~~~~~">
         <location
             file="src/main/java/org/mozilla/gecko/GeckoNetworkManager.java"
-            line="48"
+            line="50"
             column="11"/>
     </issue>