Bug 2061968 - Remove some legacy GC/CC/Editor/XHR telemetry probes which have glean counterparts, r=chutten

This is not trying to fix the rather major issue with many glean probes that they don't report content and parent process numbers separately. The old probes used to report that automatically. Differential Revision: https://phabricator.services.mozilla.com/D317258
2026-08-10 14:33:25 +00:00
parent 8e0c8d5be8
commit 310178e08e
6 changed files with 8 additions and 187 deletions
@@ -219,12 +219,12 @@ void CCGCScheduler::NoteGCSliceEnd(TimeStamp aStart, TimeStamp aEnd) {
  PerfStats::RecordMeasurement(PerfStats::Metric::NonIdleMajorGC,
                               nonIdleDuration);

-  // Note the GC_SLICE_DURING_IDLE previously had a different definition: it was
-  // a histogram of percentages of externally-triggered slices. It is now a
-  // histogram of percentages of all slices. That means that now you might have
-  // a 4ms internal slice (0% during idle) followed by a 16ms external slice
-  // (15ms during idle), whereas before this would show up as a single record of
-  // a single slice with 75% of its time during idle (15 of 20ms).
+  // Note the dom.gc_slice_during_idle previously had a different definition:
+  // it was a histogram of percentages of externally-triggered slices. It is now
+  // a histogram of percentages of all slices. That means that now you might
+  // have a 4ms internal slice (0% during idle) followed by a 16ms external
+  // slice (15ms during idle), whereas before this would show up as a single
+  // record of a single slice with 75% of its time during idle (15 of 20ms).
  TimeDuration idleDuration = sliceDuration - nonIdleDuration;
  uint32_t percent =
      uint32_t(idleDuration.ToSeconds() / sliceDuration.ToSeconds() * 100);
@@ -1036,7 +1036,6 @@ dom:
    notification_emails:
      - dev-telemetry-gc-alerts@mozilla.org
    expires: never
-    telemetry_mirror: GC_SLICE_DURING_IDLE

  xmlhttprequest_async_or_sync:
    type: labeled_counter
@@ -1055,7 +1054,6 @@ dom:
    notification_emails:
      - dom-core@mozilla.com
    expires: never
-    telemetry_mirror: h#XMLHTTPREQUEST_ASYNC_OR_SYNC

  storage_access_api_ui:
    type: labeled_counter
@@ -31,7 +31,6 @@ htmleditors:
    notification_emails:
      - mnakano.birchill@mozilla.com
    expires: never
-    telemetry_mirror: h#HTMLEDITORS_WITH_BEFOREINPUT_LISTENERS

  overridden_by_beforeinput_listeners:
    type: labeled_counter
@@ -52,7 +51,6 @@ htmleditors:
    notification_emails:
      - mnakano.birchill@mozilla.com
    expires: never
-    telemetry_mirror: h#HTMLEDITORS_OVERRIDDEN_BY_BEFOREINPUT_LISTENERS

  with_mutation_observers_without_beforeinput_listeners:
    type: labeled_counter
@@ -75,4 +73,3 @@ htmleditors:
    notification_emails:
      - mnakano.birchill@mozilla.com
    expires: never
-    telemetry_mirror: h#HTMLEDITORS_WITH_MUTATION_OBSERVERS_WITHOUT_BEFOREINPUT_LISTENERS
@@ -274,109 +274,6 @@
    "releaseChannelCollection": "opt-out",
    "description": "Whether a content process was launched synchronously (unnecessarily delaying UI response)."
  },
-  "CYCLE_COLLECTOR_FINISH_IGC": {
-    "record_in_processes": ["main", "content"],
-    "products": ["firefox", "fennec"],
-    "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"],
-    "expires_in_version": "never",
-    "kind": "boolean",
-    "description": "Cycle collection finished an incremental GC"
-  },
-  "CYCLE_COLLECTOR_SYNC_SKIPPABLE": {
-    "record_in_processes": ["main", "content"],
-    "products": ["firefox", "fennec"],
-    "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"],
-    "expires_in_version": "never",
-    "kind": "boolean",
-    "description": "Cycle collection synchronously ran forget skippable"
-  },
-  "CYCLE_COLLECTOR_VISITED_REF_COUNTED": {
-    "record_in_processes": ["main", "content"],
-    "products": ["firefox", "fennec"],
-    "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"],
-    "expires_in_version": "never",
-    "kind": "exponential",
-    "high": 300000,
-    "n_buckets": 50,
-    "description": "Number of ref counted objects visited by the cycle collector"
-  },
-  "CYCLE_COLLECTOR_WORKER_VISITED_REF_COUNTED": {
-    "record_in_processes": ["main", "content"],
-    "products": ["firefox", "fennec"],
-    "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"],
-    "expires_in_version": "never",
-    "kind": "exponential",
-    "high": 300000,
-    "n_buckets": 50,
-    "description": "Number of ref counted objects visited by the cycle collector in a worker"
-  },
-  "CYCLE_COLLECTOR_VISITED_GCED": {
-    "record_in_processes": ["main", "content"],
-    "products": ["firefox", "fennec"],
-    "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"],
-    "expires_in_version": "never",
-    "kind": "exponential",
-    "high": 300000,
-    "n_buckets": 50,
-    "description": "Number of JS objects visited by the cycle collector"
-  },
-  "CYCLE_COLLECTOR_WORKER_VISITED_GCED": {
-    "record_in_processes": ["main", "content"],
-    "products": ["firefox", "fennec"],
-    "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"],
-    "expires_in_version": "never",
-    "kind": "exponential",
-    "high": 300000,
-    "n_buckets": 50,
-    "description": "Number of JS objects visited by the cycle collector in a worker"
-  },
-  "CYCLE_COLLECTOR_COLLECTED": {
-    "record_in_processes": ["main", "content"],
-    "products": ["firefox", "fennec"],
-    "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"],
-    "expires_in_version": "never",
-    "kind": "exponential",
-    "high": 100000,
-    "n_buckets": 50,
-    "description": "Number of objects collected by the cycle collector"
-  },
-  "CYCLE_COLLECTOR_WORKER_COLLECTED": {
-    "record_in_processes": ["main", "content"],
-    "products": ["firefox", "fennec"],
-    "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"],
-    "expires_in_version": "never",
-    "kind": "exponential",
-    "high": 100000,
-    "n_buckets": 50,
-    "description": "Number of objects collected by the cycle collector in a worker"
-  },
-  "CYCLE_COLLECTOR_NEED_GC": {
-    "record_in_processes": ["main", "content"],
-    "products": ["firefox", "fennec"],
-    "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"],
-    "expires_in_version": "never",
-    "kind": "boolean",
-    "description": "Needed garbage collection before cycle collection."
-  },
-  "CYCLE_COLLECTOR_WORKER_NEED_GC": {
-    "record_in_processes": ["main", "content"],
-    "products": ["firefox", "fennec"],
-    "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"],
-    "expires_in_version": "never",
-    "kind": "boolean",
-    "description": "Needed garbage collection before cycle collection in a worker."
-  },
-  "CYCLE_COLLECTOR_SLICE_DURING_IDLE": {
-    "record_in_processes": ["main", "content"],
-    "products": ["firefox", "fennec"],
-    "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"],
-    "expires_in_version": "never",
-    "kind": "linear",
-    "high": 100,
-    "n_buckets": 50,
-    "bug_numbers": [1372042],
-    "description": "Percent of cycle collector slice done during idle time"
-  },
  "DEVICE_RESET_REASON": {
    "record_in_processes": ["main", "content", "gpu"],
    "products": ["firefox", "fennec"],
@@ -448,17 +345,6 @@
    "bug_numbers": [1271160],
    "description": "The time content uses to enter/exit fullscreen regardless of fullscreen transition timeout"
  },
-  "GC_SLICE_DURING_IDLE": {
-    "record_in_processes": ["main", "content"],
-    "products": ["firefox"],
-    "alert_emails": ["dev-telemetry-gc-alerts@mozilla.org"],
-    "expires_in_version": "never",
-    "kind": "linear",
-    "high": 100,
-    "n_buckets": 50,
-    "bug_numbers": [1372042],
-    "description": "Percent of GC slice done during idle time"
-  },
  "GPU_PROCESS_LAUNCH_TIME_MS_2": {
    "record_in_processes": ["main", "content"],
    "products": ["firefox", "fennec"],
@@ -2776,43 +2662,6 @@
    "bug_numbers": [1334615],
    "description": "The input method the user used to select a result in the searchbar. 'enter' => The user hit the Enter key without choosing a result in the popup. 'enterSelection' => The user chose a result and then hit the Enter key. 'click' => The user clicked a result with the mouse."
  },
-  "HTMLEDITORS_WITH_BEFOREINPUT_LISTENERS": {
-    "record_in_processes": ["content"],
-    "products": ["firefox", "fennec"],
-    "alert_emails": ["mnakano.birchill@mozilla.com"],
-    "bug_numbers": [1668134, 1665530],
-    "expires_in_version": "never",
-    "kind": "boolean",
-    "releaseChannelCollection": "opt-out",
-    "description": "Number of HTML editors whose window or a node in it has had beforeinput event listeners"
-  },
-  "HTMLEDITORS_OVERRIDDEN_BY_BEFOREINPUT_LISTENERS": {
-    "record_in_processes": ["content"],
-    "products": ["firefox", "fennec"],
-    "alert_emails": ["mnakano.birchill@mozilla.com"],
-    "bug_numbers": [1668134, 1665530],
-    "expires_in_version": "never",
-    "kind": "boolean",
-    "releaseChannelCollection": "opt-out",
-    "description": "Number of HTML editors whose dispatching beforeinput events are canceled"
-  },
-  "HTMLEDITORS_WITH_MUTATION_OBSERVERS_WITHOUT_BEFOREINPUT_LISTENERS": {
-    "record_in_processes": ["content"],
-    "products": ["firefox", "fennec"],
-    "alert_emails": ["mnakano.birchill@mozilla.com"],
-    "bug_numbers": [1668134, 1665530],
-    "expires_in_version": "never",
-    "kind": "boolean",
-    "releaseChannelCollection": "opt-out",
-    "description": "Number of HTML editors a node in the window has been observed by mutation observers, but has not had beforeinput event listeners"
-  },
-  "XMLHTTPREQUEST_ASYNC_OR_SYNC": {
-    "record_in_processes": ["main", "content"],
-    "products": ["firefox", "fennec"],
-    "expires_in_version": "never",
-    "kind": "boolean",
-    "description": "Type of XMLHttpRequest, async or sync"
-  },
  "TELEMETRY_TEST_COUNT": {
    "record_in_processes": ["main", "content"],
    "products": ["firefox", "fennec", "thunderbird"],
@@ -54,8 +54,7 @@
    "SUBPROCESS_ABNORMAL_ABORT",
    "SUBPROCESS_CRASHES_WITH_DUMP",
    "SYSTEM_FONT_FALLBACK",
-    "SYSTEM_FONT_FALLBACK_FIRST",
-    "XMLHTTPREQUEST_ASYNC_OR_SYNC"
+    "SYSTEM_FONT_FALLBACK_FIRST"
  ],
  "bug_numbers": [
    "APPLICATION_REPUTATION_LOCAL",
@@ -71,16 +70,6 @@
    "CANVAS_2D_USED",
    "CANVAS_WEBGL_USED",
    "CRASH_STORE_COMPRESSED_BYTES",
-    "CYCLE_COLLECTOR_COLLECTED",
-    "CYCLE_COLLECTOR_FINISH_IGC",
-    "CYCLE_COLLECTOR_NEED_GC",
-    "CYCLE_COLLECTOR_SYNC_SKIPPABLE",
-    "CYCLE_COLLECTOR_VISITED_GCED",
-    "CYCLE_COLLECTOR_VISITED_REF_COUNTED",
-    "CYCLE_COLLECTOR_WORKER_COLLECTED",
-    "CYCLE_COLLECTOR_WORKER_NEED_GC",
-    "CYCLE_COLLECTOR_WORKER_VISITED_GCED",
-    "CYCLE_COLLECTOR_WORKER_VISITED_REF_COUNTED",
    "DEFECTIVE_PERMISSIONS_SQL_REMOVED",
    "DNS_CLEANUP_AGE",
    "DWRITEFONT_DELAYEDINITFONTLIST_COLLECT",
@@ -203,8 +192,7 @@
    "WEBRTC_VIDEO_QUALITY_INBOUND_PACKETLOSS_RATE",
    "WEBRTC_VIDEO_QUALITY_OUTBOUND_JITTER",
    "WEBRTC_VIDEO_QUALITY_OUTBOUND_PACKETLOSS_RATE",
-    "WEBRTC_VIDEO_QUALITY_OUTBOUND_RTT",
-    "XMLHTTPREQUEST_ASYNC_OR_SYNC"
+    "WEBRTC_VIDEO_QUALITY_OUTBOUND_RTT"
  ],
  "n_buckets": [
    "UPDATE_PREF_UPDATE_CANCELATIONS_EXTERNAL",
@@ -235,7 +235,6 @@ cycle_collector:
    notification_emails:
      - dev-telemetry-gc-alerts@mozilla.org
    expires: never
-    telemetry_mirror: CYCLE_COLLECTOR_VISITED_REF_COUNTED

  worker_visited_ref_counted:
    type: custom_distribution
@@ -256,7 +255,6 @@ cycle_collector:
    notification_emails:
      - dev-telemetry-gc-alerts@mozilla.org
    expires: never
-    telemetry_mirror: CYCLE_COLLECTOR_WORKER_VISITED_REF_COUNTED

  visited_gced:
    type: custom_distribution
@@ -277,7 +275,6 @@ cycle_collector:
    notification_emails:
      - dev-telemetry-gc-alerts@mozilla.org
    expires: never
-    telemetry_mirror: CYCLE_COLLECTOR_VISITED_GCED

  worker_visited_gced:
    type: custom_distribution
@@ -298,7 +295,6 @@ cycle_collector:
    notification_emails:
      - dev-telemetry-gc-alerts@mozilla.org
    expires: never
-    telemetry_mirror: CYCLE_COLLECTOR_WORKER_VISITED_GCED

  collected:
    type: custom_distribution
@@ -319,7 +315,6 @@ cycle_collector:
    notification_emails:
      - dev-telemetry-gc-alerts@mozilla.org
    expires: never
-    telemetry_mirror: CYCLE_COLLECTOR_COLLECTED

  worker_collected:
    type: custom_distribution
@@ -340,7 +335,6 @@ cycle_collector:
    notification_emails:
      - dev-telemetry-gc-alerts@mozilla.org
    expires: never
-    telemetry_mirror: CYCLE_COLLECTOR_WORKER_COLLECTED

  need_gc:
    type: labeled_counter
@@ -359,7 +353,6 @@ cycle_collector:
    notification_emails:
      - dev-telemetry-gc-alerts@mozilla.org
    expires: never
-    telemetry_mirror: h#CYCLE_COLLECTOR_NEED_GC

  worker_need_gc:
    type: labeled_counter
@@ -378,7 +371,6 @@ cycle_collector:
    notification_emails:
      - dev-telemetry-gc-alerts@mozilla.org
    expires: never
-    telemetry_mirror: h#CYCLE_COLLECTOR_WORKER_NEED_GC

  full:
    type: labeled_timing_distribution
@@ -427,7 +419,6 @@ cycle_collector:
    notification_emails:
      - dev-telemetry-gc-alerts@mozilla.org
    expires: never
-    telemetry_mirror: h#CYCLE_COLLECTOR_FINISH_IGC

  sync_skippable:
    type: labeled_counter
@@ -446,7 +437,6 @@ cycle_collector:
    notification_emails:
      - dev-telemetry-gc-alerts@mozilla.org
    expires: never
-    telemetry_mirror: h#CYCLE_COLLECTOR_SYNC_SKIPPABLE

  time_between:
    type: labeled_timing_distribution
@@ -481,7 +471,6 @@ cycle_collector:
    notification_emails:
      - dev-telemetry-gc-alerts@mozilla.org
    expires: never
-    telemetry_mirror: CYCLE_COLLECTOR_SLICE_DURING_IDLE

  async_snow_white_freeing:
    type: labeled_timing_distribution