Ryan VanderMeulen
47fd6ce131
- Re-vendored protobuf at v35.0 alongside third_party/utf8_range, a build-time dependency pulled in by extension_set_inl.h. Expanded moz.yaml excludes to cover the reorganized upstream layout (json/, util/, bridge/, compiler/, plus test/build-config files leaked past the default exclude pattern), and dropped the now-upstreamed remove_iostream_header.patch. - Added /third_party/abseil-cpp to chromium-config.mozbuild's LOCAL_INCLUDES so transitive absl/* includes resolve in every protobuf consumer that includes chromium-config; added direct LOCAL_INCLUDES on the few that don't. - Added a pragma to abseil's check_op.h to suppress sign-compare in CHECK_OP macros, scoping the suppression to translation units that include this header rather than globally. - Added USE_LIBS += ["abseil"] to the content_analysis_sdk_agent Program() so it can link absl symbols. - Audited moz.build SOURCES and EXPORTS against actual usage and removed full-runtime files (well-known type .pb.cc/.pb.h, reflection_ops, dynamic_message, text_format, descriptor, etc.) that our lite-mode generated code doesn't reach. - Taught generate_files.py to update gradle/libs.versions.toml's `protobuf` (Java/Maven) value to match the vendored C++ revision on future re-vendors. - Suppressed nodiscard warnings on pre-existing SerializeToString calls in url-classifier with (void) casts. Differential Revision: https://phabricator.services.mozilla.com/D300213
27 lines
1.2 KiB
Diff
27 lines
1.2 KiB
Diff
From: Ryan VanderMeulen <rvandermeulen@mozilla.com>
|
|
Date: Tue, 13 May 2026 00:00:00 +0000
|
|
Subject: Bug 1989886 - Suppress sign-compare in abseil CHECK_OP macros. r?#firefox-build-system-reviewers
|
|
|
|
---
|
|
abseil-cpp/absl/log/internal/check_op.h | 7 +++++++
|
|
1 file changed, 7 insertions(+)
|
|
|
|
diff --git a/abseil-cpp/absl/log/internal/check_op.h b/abseil-cpp/absl/log/internal/check_op.h
|
|
index 8d7ade4427e5..ba8a02aeb566 100644
|
|
--- a/abseil-cpp/absl/log/internal/check_op.h
|
|
+++ b/abseil-cpp/absl/log/internal/check_op.h
|
|
@@ -398,6 +398,13 @@ ABSL_LOG_INTERNAL_DEFINE_MAKE_CHECK_OP_STRING_EXTERN(const void*);
|
|
MakeCheckOpString<U1, U2>(v1, v2, exprtext)
|
|
#endif
|
|
|
|
+// Comparing mixed signed/unsigned values is intentional in CHECK_OP. A
|
|
+// push/pop pragma does not interact correctly with macro definitions, so
|
|
+// suppress without restoring. This header is transitively included by all
|
|
+// protobuf-generated headers, so this pragma affects entire translation
|
|
+// units that include any .pb.h file.
|
|
+#pragma GCC diagnostic ignored "-Wsign-compare"
|
|
+
|
|
// Helper functions for `ABSL_LOG_INTERNAL_CHECK_OP` macro family. The
|
|
// `(int, int)` override works around the issue that the compiler will not
|
|
// instantiate the template version of the function on values of unnamed enum
|