Stephen A Pohl
baeabedf94
Default resizable titled top-level windows to FullScreenPrimary + FullScreenAllowsTiling so the green window-control button keeps its fullscreen-enter arrows; non-resizable titled windows default to FullScreenAuxiliary + FullScreenDisallowsTiling. SetSupportsNativeFullscreen sets all four bits consistently so AppKit never falls back to the non-deterministic _implicitlyAllowsFullScreenPrimary heuristic that caused the bug 2031249 crash. In AppWindow.cpp, only call SetSupportsNativeFullscreen when the XUL macnativefullscreen attribute is actually present, and read its value as a boolean. With HasAttribute as the previous gate, windows without the attribute were forced to FullScreenAuxiliary, which would regress the zoom button to '+' on every XHTML window that doesn't carry the attribute (only two do today). Leaving them at the creation-time default preserves the existing fullscreen UX without requiring per-window XHTML edits. Differential Revision: https://phabricator.services.mozilla.com/D301471
91 lines
3.3 KiB
HTML
91 lines
3.3 KiB
HTML
<?xml version="1.0"?>
|
|
<?xml-stylesheet href="chrome://global/skin" type="text/css"?>
|
|
<window title="Mozilla Bug 522217"
|
|
onload="start();"
|
|
xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
|
|
|
|
<script src="chrome://mochikit/content/tests/SimpleTest/EventUtils.js" />
|
|
|
|
<body xmlns="http://www.w3.org/1999/xhtml" id="body">
|
|
</body>
|
|
|
|
<script class="testbody" type="application/javascript">
|
|
<![CDATA[
|
|
|
|
function ok(aCondition, aMessage)
|
|
{
|
|
window.arguments[0].SimpleTest.ok(aCondition, aMessage);
|
|
}
|
|
|
|
function is(aLeft, aRight, aMessage)
|
|
{
|
|
window.arguments[0].SimpleTest.is(aLeft, aRight, aMessage);
|
|
}
|
|
|
|
function isnot(aLeft, aRight, aMessage)
|
|
{
|
|
window.arguments[0].SimpleTest.isnot(aLeft, aRight, aMessage);
|
|
}
|
|
|
|
function executeSoon() {
|
|
return new Promise(resolve => {
|
|
window.arguments[0].SimpleTest.executeSoon(resolve);
|
|
});
|
|
}
|
|
|
|
function waitForEvent(obj, name) {
|
|
return new Promise(resolve => {
|
|
obj.addEventListener(name, resolve, { once: true });
|
|
});
|
|
}
|
|
|
|
function waitForAnimationFrame() {
|
|
return new Promise(resolve => window.requestAnimationFrame(resolve));
|
|
}
|
|
|
|
async function start() {
|
|
await waitForEvent(window, "focus");
|
|
var oldOuterWidth = window.outerWidth, oldOuterHeight = window.outerHeight;
|
|
var oldInnerWidth = window.innerWidth, oldInnerHeight = window.innerHeight;
|
|
document.documentElement.setAttribute("customtitlebar", "true");
|
|
|
|
await executeSoon();
|
|
is(window.outerWidth, oldOuterWidth, "customtitlebar shouldn't change the window's outerWidth");
|
|
is(window.outerHeight, oldOuterHeight, "customtitlebar shouldn't change the window's outerHeight");
|
|
is(window.innerWidth, oldOuterWidth, "if customtitlebar is set, innerWidth and outerWidth should be the same");
|
|
is(window.innerHeight, oldOuterHeight, "if customtitlebar is set, innerHeight and outerHeight should be the same");
|
|
|
|
// Wait for going full screen and back.
|
|
let sizemodeChange = waitForEvent(window, "sizemodechange");
|
|
window.fullScreen = true;
|
|
await sizemodeChange;
|
|
sizemodeChange = waitForEvent(window, "sizemodechange");
|
|
window.fullScreen = false;
|
|
await sizemodeChange;
|
|
// sizemodechange fires when the OS reports the window state change. On
|
|
// macOS with native fullscreen, the document layout may not have reflowed
|
|
// to the restored window size yet (bug 2038980), so wait two animation
|
|
// frames before reading innerWidth/innerHeight.
|
|
await waitForAnimationFrame();
|
|
await waitForAnimationFrame();
|
|
is(window.outerWidth, oldOuterWidth, "wrong outerWidth after fullscreen mode");
|
|
is(window.outerHeight, oldOuterHeight, "wrong outerHeight after fullscreen mode");
|
|
is(window.innerWidth, oldOuterWidth, "wrong innerWidth after fullscreen mode");
|
|
is(window.innerHeight, oldOuterHeight, "wrong innerHeight after fullscreen mode");
|
|
document.documentElement.removeAttribute("customtitlebar");
|
|
|
|
await executeSoon();
|
|
is(window.outerWidth, oldOuterWidth, "wrong outerWidth after removing customtitlebar");
|
|
is(window.outerHeight, oldOuterHeight, "wrong outerHeight after removing customtitlebar");
|
|
is(window.innerWidth, oldInnerWidth, "wrong innerWidth after removing customtitlebar");
|
|
is(window.innerHeight, oldInnerHeight, "wrong innerHeight after removing customtitlebar");
|
|
window.arguments[0].SimpleTest.finish();
|
|
window.close();
|
|
}
|
|
|
|
|
|
]]>
|
|
</script>
|
|
|
|
</window>
|