Benjamin Beurdouche
098a954a49
Instead of opting these storage/toolkit tests out of SQLite encryption, assert the correct behavior in BOTH the encrypted and plaintext configurations (detected via the security.storage.encryption.sqlite.enabled pref): - test_storage_service: a directory-as-database open surfaces NS_ERROR_FAILURE through obfsvfs (and records no open telemetry) vs NS_ERROR_FILE_ACCESS_DENIED / Glean "access" on the plain VFS. - test_vacuum: obfsvfs forces a fixed page size, so a VACUUM cannot change it (expect unchanged vs 1024); and an encrypted database keeps full auto_vacuum (1) rather than switching to incremental (2). - test_sqlite_autoVacuum: a fresh encrypted database reports full auto_vacuum (1), which reclaims freed pages at commit, so there is no freelist for an idle VACUUM to reclaim; assert that auto-reclaim behavior instead. - test_cache_size: the requested page size is ignored under encryption (cache size is KiB-based and unchanged). - test_sqlite_secure_delete: an encrypted database never stores the plaintext on disk, so the pre-delete "string is present" check only applies unencrypted; the post-delete absence check holds in both modes. Add test_encryption_rejects_plaintext, asserting the fail-closed contract directly: with encryption on, an in-profile database that is not encrypted (a foreign plaintext database) is refused rather than opened as plaintext; with encryption off it opens normally. Finally, the places, IndexedDB and dom/cache migration/upgrade tests ship pre-built PLAINTEXT profile/database fixtures and migrate them to the current schema. An encrypting build cannot read those plaintext databases (obfsvfs requires its own page format and there is no plaintext->encrypted migration by design), and never legitimately encounters a foreign plaintext profile. Their schema-migration logic is VFS-agnostic and is covered with encryption off, so run those fixture tests with encryption disabled, each manifest entry carrying a short comment. Verified passing both with and without SQLite encryption. Differential Revision: https://phabricator.services.mozilla.com/D305033
114 lines
3.4 KiB
JavaScript
114 lines
3.4 KiB
JavaScript
"use strict";
|
|
|
|
/**
|
|
* Sends a fake idle-daily notification to the VACUUM Manager.
|
|
*/
|
|
function synthesize_idle_daily() {
|
|
Cc["@mozilla.org/storage/vacuum;1"]
|
|
.getService(Ci.nsIObserver)
|
|
.observe(null, "idle-daily", null);
|
|
}
|
|
|
|
function unregister_vacuum_participants() {
|
|
// First unregister other participants.
|
|
for (let { data: entry } of Services.catMan.enumerateCategory(
|
|
"vacuum-participant"
|
|
)) {
|
|
Services.catMan.deleteCategoryEntry("vacuum-participant", entry, false);
|
|
}
|
|
}
|
|
|
|
function reset_vacuum_date(dbname) {
|
|
let date = parseInt(Date.now() / 1000 - 31 * 86400);
|
|
// Set last VACUUM to a date in the past.
|
|
Services.prefs.setIntPref(`storage.vacuum.last.${dbname}`, date);
|
|
return date;
|
|
}
|
|
|
|
function get_vacuum_date(dbname) {
|
|
return Services.prefs.getIntPref(`storage.vacuum.last.${dbname}`, 0);
|
|
}
|
|
|
|
async function get_freelist_count(conn) {
|
|
return (await conn.execute("PRAGMA freelist_count"))[0].getResultByIndex(0);
|
|
}
|
|
|
|
async function get_auto_vacuum(conn) {
|
|
return (await conn.execute("PRAGMA auto_vacuum"))[0].getResultByIndex(0);
|
|
}
|
|
|
|
async function test_vacuum(options = {}) {
|
|
unregister_vacuum_participants();
|
|
const dbName = "testVacuum.sqlite";
|
|
const dbFile = PathUtils.join(PathUtils.profileDir, dbName);
|
|
let lastVacuumDate = reset_vacuum_date(dbName);
|
|
let conn = await Sqlite.openConnection(
|
|
Object.assign(
|
|
{
|
|
path: dbFile,
|
|
vacuumOnIdle: true,
|
|
},
|
|
options
|
|
)
|
|
);
|
|
// Ensure the category manager is up-to-date.
|
|
await TestUtils.waitForTick();
|
|
|
|
// obfsvfs (the default VFS under SQLite encryption) creates databases with
|
|
// full auto_vacuum -- its synthetic page-1 header sets a non-zero
|
|
// largest-root-page -- so a fresh encrypted database reports auto_vacuum=1
|
|
// rather than 0 unless incremental vacuum (2) was requested at open. Full
|
|
// auto_vacuum reclaims freed pages at commit, so no freelist accumulates and
|
|
// the idle VACUUM has nothing to do (a non-auto_vacuum encrypted database is
|
|
// not possible); the encrypted branch below checks that auto-reclaim instead
|
|
// of the plaintext "idle VACUUM clears the freelist" path.
|
|
let encrypted = Services.prefs.getBoolPref(
|
|
"security.storage.encryption.sqlite.enabled",
|
|
false
|
|
);
|
|
let autoVacuum = await get_auto_vacuum(conn);
|
|
let expectedAutoVacuum = 0;
|
|
if (options.incrementalVacuum) {
|
|
expectedAutoVacuum = 2;
|
|
} else if (encrypted) {
|
|
expectedAutoVacuum = 1;
|
|
}
|
|
Assert.equal(autoVacuum, expectedAutoVacuum, "Check auto_vacuum");
|
|
|
|
// Generate some freelist page.
|
|
await conn.execute("CREATE TABLE test (id INTEGER)");
|
|
await conn.execute("DROP TABLE test");
|
|
|
|
if (autoVacuum == 1) {
|
|
Assert.equal(
|
|
await get_freelist_count(conn),
|
|
0,
|
|
"Full auto_vacuum reclaims freed pages without an idle VACUUM"
|
|
);
|
|
} else {
|
|
Assert.greater(await get_freelist_count(conn), 0, "Check freelist_count");
|
|
|
|
let promiseVacuumEnd = TestUtils.topicObserved(
|
|
"vacuum-end",
|
|
(_, d) => d == dbName
|
|
);
|
|
synthesize_idle_daily();
|
|
info("Await vacuum end");
|
|
await promiseVacuumEnd;
|
|
|
|
Assert.greater(get_vacuum_date(dbName), lastVacuumDate);
|
|
|
|
Assert.equal(await get_freelist_count(conn), 0, "Check freelist_count");
|
|
}
|
|
|
|
await conn.close();
|
|
await IOUtils.remove(dbFile);
|
|
}
|
|
|
|
add_task(async function test_vacuumOnIdle() {
|
|
info("Test full vacuum");
|
|
await test_vacuum();
|
|
info("Test incremental vacuum");
|
|
await test_vacuum({ incrementalVacuum: true });
|
|
});
|