Nico Grunbaum
6b9b11552e
Upstream commit: https://webrtc.googlesource.com/src/+/0c4a6baddcdd425fe233f28bf91193106b568fcb Reland "Remove stringstream fallback from MakeVal in logging.h" This is a reland of commit 4ccdad97fcb69489aa4c77593dbc382bbd532997 Before relanding, the RTC_LOG macro will be updated to support std::string_view explicitly to avoid previous implicit conversion problems between absl::string_view, std::string and std::string_view. Original change's description: > Remove stringstream fallback from MakeVal in logging.h > > This change removes the generic MakeVal fallback in logging.h that > relied on std::ostringstream. This hasn't been used in webrtc for years > but now known downstream dependencies have been removed in favor of more > efficient alternatives like StringBuilder and Abseil's string utilities. > > Existing call sites and related code in tests and tools have similarly > been migrated: > > * Replaced std::ostringstream and std::stringstream with StringBuilder > in SDP, Opus, and OpenSSL unit tests. > * Refactored string parsing in neteq_quality_test and bwe_rtp to use > absl::StrSplit and Abseil's numeric conversion functions. > * Updated RTC_LOG calls in cross_traffic_unittest to explicitly load > atomic counters (and not rely on stringstream to do it). > * Updated BUILD.gn and DEPS to include required Abseil and string > utility dependencies. > > Bug: webrtc:42234461 > Change-Id: I7fbe4b68478fb1aca08c6126979ae577ef5418da > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/466441 > Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> > Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#47577} Bug: webrtc:42234461 Change-Id: I2ff763f1ae1c08499396ad97767375392af6c7c3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/469260 Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#47616}
58 lines
2.7 KiB
Diff
58 lines
2.7 KiB
Diff
From: Nico Grunbaum <na-g@nostrum.com>
|
|
Date: Tue, 6 Jun 2023 16:37:00 -0700
|
|
Subject: Bug 1833237 - (fix-f0be3bee1f) remove reference to
|
|
portal:pipewire_base;r?pehrsons
|
|
|
|
Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/8ff886a4d366b4be35b329d1ef733a6df542067c
|
|
---
|
|
modules/video_capture/BUILD.gn | 4 ++++
|
|
modules/video_capture/linux/device_info_pipewire.cc | 4 ++--
|
|
modules/video_capture/linux/device_info_pipewire.h | 3 ++-
|
|
3 files changed, 8 insertions(+), 3 deletions(-)
|
|
|
|
diff --git a/modules/video_capture/BUILD.gn b/modules/video_capture/BUILD.gn
|
|
index 22cafadb45..23574d2bda 100644
|
|
--- a/modules/video_capture/BUILD.gn
|
|
+++ b/modules/video_capture/BUILD.gn
|
|
@@ -116,6 +116,10 @@ if (!build_with_chromium || is_linux || is_chromeos) {
|
|
"../../media:rtc_media_base",
|
|
"../portal",
|
|
]
|
|
+ if (build_with_mozilla) {
|
|
+ configs -= [ "../portal:pipewire_base" ]
|
|
+ public_deps = [ "//third_party/pipewire" ]
|
|
+ }
|
|
}
|
|
}
|
|
if (is_win) {
|
|
diff --git a/modules/video_capture/linux/device_info_pipewire.cc b/modules/video_capture/linux/device_info_pipewire.cc
|
|
index 7eaf5fbd70..7748fcf08f 100644
|
|
--- a/modules/video_capture/linux/device_info_pipewire.cc
|
|
+++ b/modules/video_capture/linux/device_info_pipewire.cc
|
|
@@ -43,9 +43,9 @@ int32_t DeviceInfoPipeWire::GetDeviceName(uint32_t deviceNumber,
|
|
char* deviceUniqueIdUTF8,
|
|
uint32_t deviceUniqueIdUTF8Length,
|
|
char* productUniqueIdUTF8,
|
|
- uint32_t productUniqueIdUTF8Length) {
|
|
+ uint32_t productUniqueIdUTF8Length,
|
|
+ pid_t* pid) {
|
|
RTC_CHECK(pipewire_session_);
|
|
-
|
|
if (deviceNumber >= NumberOfDevices())
|
|
return -1;
|
|
|
|
diff --git a/modules/video_capture/linux/device_info_pipewire.h b/modules/video_capture/linux/device_info_pipewire.h
|
|
index 5d0fc6740a..b3e6de6fee 100644
|
|
--- a/modules/video_capture/linux/device_info_pipewire.h
|
|
+++ b/modules/video_capture/linux/device_info_pipewire.h
|
|
@@ -31,7 +31,8 @@ class DeviceInfoPipeWire : public DeviceInfoImpl {
|
|
char* deviceUniqueIdUTF8,
|
|
uint32_t deviceUniqueIdUTF8Length,
|
|
char* productUniqueIdUTF8 = nullptr,
|
|
- uint32_t productUniqueIdUTF8Length = 0) override;
|
|
+ uint32_t productUniqueIdUTF8Length = 0,
|
|
+ pid_t* pid = 0) override;
|
|
/*
|
|
* Fills the membervariable _captureCapabilities with capabilites for the
|
|
* given device name.
|