Nico Grunbaum
8b0923cd8a
Upstream commit: https://webrtc.googlesource.com/src/+/2a6b39446a2d7c470a44eb1365061d77a64f5001 Refactor ChannelReceive to accept PacketRouter in constructor Passes PacketRouter directly during construction of voe::ChannelReceive, allowing the pointer member to be const and managing congestion control objects' lifetime automatically via RAII. This simplifies the ChannelReceiveInterface by removing the RegisterReceiverCongestionControlObjects and ResetReceiverCongestionControlObjects methods. Bug: none Change-Id: Ibddae158314fb7e461c47b0f72e163feb87a663c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/474840 Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#47804}
30 lines
1.1 KiB
Diff
30 lines
1.1 KiB
Diff
From: Andreas Pehrson <apehrson@mozilla.com>
|
|
Date: Fri, 20 Aug 2021 13:52:00 +0200
|
|
Subject: Bug 1654112 - Don't check the calling thread in
|
|
webrtc::AudioReceiveStream::GetSources. r=ng
|
|
|
|
source_tracker_ is thread safe with its own internal mutex, so this call is safe
|
|
as long as the caller has a guarantee for the lifetime of the
|
|
AudioReceiveStream. This is similar to webrtc::VideoReceiveStream.
|
|
|
|
Upliftable.
|
|
|
|
Differential Revision: https://phabricator.services.mozilla.com/D123226
|
|
Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/c186df8a088e46285a15e40149182daa34cc6805
|
|
---
|
|
audio/audio_receive_stream.cc | 1 -
|
|
1 file changed, 1 deletion(-)
|
|
|
|
diff --git a/audio/audio_receive_stream.cc b/audio/audio_receive_stream.cc
|
|
index e8a23bdd39..248a3e14bb 100644
|
|
--- a/audio/audio_receive_stream.cc
|
|
+++ b/audio/audio_receive_stream.cc
|
|
@@ -373,7 +373,6 @@ int AudioReceiveStreamImpl::GetBaseMinimumPlayoutDelayMs() const {
|
|
}
|
|
|
|
std::vector<RtpSource> AudioReceiveStreamImpl::GetSources() const {
|
|
- RTC_DCHECK_RUN_ON(&worker_thread_checker_);
|
|
return channel_receive_->GetSources();
|
|
}
|
|
|