Ryan VanderMeulen
1582b2b94e
Differential Revision: https://phabricator.services.mozilla.com/D309451
28 lines
1.3 KiB
Diff
28 lines
1.3 KiB
Diff
From: Ryan VanderMeulen <rvandermeulen@mozilla.com>
|
|
Date: Wed, 13 May 2026 00:00:00 +0000
|
|
Subject: Bug 1989886 - Suppress sign-compare in abseil CHECK_OP macros.
|
|
r?#firefox-build-system-reviewers
|
|
|
|
---
|
|
abseil-cpp/absl/log/internal/check_op.h | 7 +++++++
|
|
1 file changed, 7 insertions(+)
|
|
|
|
diff --git a/abseil-cpp/absl/log/internal/check_op.h b/abseil-cpp/absl/log/internal/check_op.h
|
|
index 9bf908e834d..b2b47d0b861 100644
|
|
--- a/abseil-cpp/absl/log/internal/check_op.h
|
|
+++ b/abseil-cpp/absl/log/internal/check_op.h
|
|
@@ -479,6 +479,13 @@ ABSL_LOG_INTERNAL_DEFINE_MAKE_CHECK_OP_STRING_EXTERN(const void* absl_nonnull);
|
|
MakeCheckOpString<U1, U2>(v1, v2, exprtext)
|
|
#endif
|
|
|
|
+// Comparing mixed signed/unsigned values is intentional in CHECK_OP. A
|
|
+// push/pop pragma does not interact correctly with macro definitions, so
|
|
+// suppress without restoring. This header is transitively included by all
|
|
+// protobuf-generated headers, so this pragma affects entire translation
|
|
+// units that include any .pb.h file.
|
|
+#pragma GCC diagnostic ignored "-Wsign-compare"
|
|
+
|
|
// Helper functions for `ABSL_LOG_INTERNAL_CHECK_OP` macro family. The
|
|
// `(int, int)` override works around the issue that the compiler will not
|
|
// instantiate the template version of the function on values of unnamed enum
|