Jean-Philippe Gravel
5635e0491a
Automatic update from web-platform-tests Remove expected PNG files for generated OffscreenCanvas tests These expected images have very limited value. They are only used for testharness tests and are not used for automatically validating the test results. These tests are instead validated using assertions. Thus, the expected image is only useful for manual verifications. For element tests, test result pages include both the canvas test result and the expected image, and thus, we can manually validate the test result visually. For offscreen and worker tests however, the test result is never captured from the OffscreenCanvas and never displayed in any way. It's therefore impossible to use the expected image for verification, making it entirely useless. Originally, the expected images almost only existed for element tests (see the state of the tests in https://crrev.com/c/2240038 for instance). As we merged the test definition for element and offscreen, lots of offscreen tests mistakenly inherited the element's expected image (see https://crrev.com/c/4562936 for instance). It's time to clean this up. Bug: 40207206 Change-Id: I97a483ce929f7e346c8062f5ab6b6efdd6c5449d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6172745 Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Reviewed-by: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/main@{#1406971} -- Remove deleted PNGs from blocklist -- wpt-commits: 3b77b60493c5c73b711d9ab3c8bb883e7209f2e4, 5585eb3d9b63fac7c4bb6db488194be6e7060d70 wpt-pr: 50110
27 lines
746 B
Bash
Executable File
27 lines
746 B
Bash
Executable File
#!/bin/bash
|
||
set -ex
|
||
|
||
SCRIPT_DIR=$(cd $(dirname "$0") && pwd -P)
|
||
WPT_ROOT=$SCRIPT_DIR/../..
|
||
cd $WPT_ROOT
|
||
|
||
main() {
|
||
# Diff PNGs based on pixel-for-pixel identity
|
||
echo -e '[diff "img"]\n textconv = identify -quiet -format "%#"' >> .git/config
|
||
echo -e '*.png diff=img' >> .git/info/attributes
|
||
|
||
# Exclude tests that rely on font rendering
|
||
excluded=(
|
||
'html/canvas/element/text/2d.text.draw.fill.basic.png'
|
||
'html/canvas/element/text/2d.text.draw.fill.maxWidth.large.png'
|
||
'html/canvas/element/text/2d.text.draw.fill.rtl.png'
|
||
'html/canvas/element/text/2d.text.draw.stroke.basic.png'
|
||
)
|
||
|
||
./wpt update-built
|
||
git update-index --assume-unchanged ${excluded[*]}
|
||
git diff --exit-code
|
||
}
|
||
|
||
main
|