Javier Contreras Tenorio (from Dev Box)
e4d57e6d99
Automatic update from web-platform-tests [gap-decorations] Mark GapDecorations flag as experimental This CL marks the GapDecorations feature flag as experimental, in order for us to have dev trials on the feature, and we fix test expectation files accordingly. List of non-obvious fixes: * computed_style_test.cc: This had to be updated to now take into account that `ColumnRuleWidth` is now a CSSValueList, so we keep the spirit of the test, we just make sure to special case the new types. *flexbox-columns: this test was deleted in this CL because it is testing that there are no column rules in a flexbox container, which is not true now with GapDecorations, so the test no longer makes sense. * column-height-009-ref: as discussed and resolved here https://github.com/w3c/csswg-drafts/issues/2309 column rules should be drawn to the height of the container * column-rule-*-invalid: These are changed because with GapDecorations we do accept lists of values. * column-rule-*.html: These were changed to account for the fact that these rules we no longer treat as CSSKeywordValue and instead are now CSSStyleValues. With GapDecorations we fail in the set up since now ruleWidth is a CSSStyleValue rather than a CSSUnitValue, which makes the test fail before we even get to the asserts. All we can test here now is whether or not we are a CSSStyleValue. We follow the example of other properties that are of this type too. * column-rule invalidation tests rebaseline: the invalidation rect is bigger now with gap decorations enabled. * Lastly, we have added interpolation/animation tests as failing to the test expectations to account for the fact that this does not yet work with gap decorations. We are aware of this, but we wanted to get the feature out for dev trials as soon as possible. We have made a tracking bug for this. Bug: 357648037, 419066541, 420959039, 421053112 Change-Id: Ie1df2c4987f76008dee872e87db7ca65649b8654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6514569 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Sam Davis Omekara <samomekarajr@microsoft.com> Commit-Queue: Javier Contreras <javiercon@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1467585} -- wpt-commits: 8f937883af326007f0711a245de8d9039d74d548 wpt-pr: 52873 Differential Revision: https://phabricator.services.mozilla.com/D252105
24 lines
839 B
HTML
24 lines
839 B
HTML
<!DOCTYPE html>
|
|
<html>
|
|
<head>
|
|
<meta charset="utf-8">
|
|
<title>CSS Multi-column Layout: parsing column-rule-width with invalid values</title>
|
|
<link rel="help" href="https://drafts.csswg.org/css-multicol/#propdef-column-rule-width">
|
|
<meta name="assert" content="column-rule-width supports only the <line-width> grammar '<length> | thin | medium | thick'.">
|
|
<meta name="assert" content="column-rule-width rejects negative lengths.">
|
|
<script src="/resources/testharness.js"></script>
|
|
<script src="/resources/testharnessreport.js"></script>
|
|
<script src="/css/support/parsing-testcommon.js"></script>
|
|
</head>
|
|
<body>
|
|
<script>
|
|
test_invalid_value("column-rule-width", "auto");
|
|
|
|
test_invalid_value("column-rule-width", "10");
|
|
test_invalid_value("column-rule-width", "-20px");
|
|
test_invalid_value("column-rule-width", "30%");
|
|
|
|
</script>
|
|
</body>
|
|
</html>
|