Daniel Holbert
47014eccd5
The paint ordering in these tests (of the highlight-background vs. ink of adjacent glyphs) is different in the testcase and reference case, at least in Gecko and WebKit (though not in Chromium[1]). This creates the potential for spurious failures in Gecko and WebKit, if the chosen font happens to have glyphs that draw close together (such that one glyph might have a piece that protrudes to overlap the bounding-box of the next glyph). This patch avoids these spurious failures by explicitly using a monospace font; this reduces the likelihood of glyphs drawing close together and experiencing the sort of overlap that would reveal the paint-order differences between the testcase & reference case. This patch also adds some letter-spacing to one of the testscases; this is needed to fully avoid overlap in the case of an "O" glyph that's adjacent to a highlight and is wide enough in the Windows monospace font to still trigger this problematic overlap (if it weren't for this added letter-spacing). [1] https://issues.chromium.org/issues/465531995 Differential Revision: https://phabricator.services.mozilla.com/D274954
38 lines
1.6 KiB
HTML
38 lines
1.6 KiB
HTML
<!DOCTYPE html>
|
|
<html>
|
|
<head>
|
|
<meta charset="utf-8">
|
|
<title>Multiple custom highlight pseudo elements.</title>
|
|
<link rel="help" href="https://drafts.csswg.org/css-highlight-api-1/#creating-highlights">
|
|
<link rel="match" href="highlight-text-replace-ref.html">
|
|
<meta name="assert" content="Multiple highlights should be able to be specified.">
|
|
<style>
|
|
:root {
|
|
/* This reduces the likelihood that a highlight background-area
|
|
will overlap with the previous glyph. That overlap is worth
|
|
avoiding, because the previous glyph's overlapping part will get
|
|
clipped in the reference case, but might not in the testcase. */
|
|
font-family: monospace;
|
|
}
|
|
::highlight(example-highlight) {
|
|
background-color: yellow;
|
|
color:green;
|
|
}
|
|
</style>
|
|
</head>
|
|
<body>
|
|
<span id="text1">One two three</span>
|
|
|
|
<script>
|
|
let textElement = document.getElementById('text1');
|
|
let highlight1 = new Highlight(new StaticRange({startContainer: textElement.childNodes[0], startOffset: 1, endContainer: textElement.childNodes[0], endOffset: 2}));
|
|
|
|
let highlight2 = new Highlight(new StaticRange({startContainer: textElement.childNodes[0], startOffset: 3, endContainer: textElement.childNodes[0], endOffset: 4}));
|
|
highlight2.add(new StaticRange({startContainer: textElement.childNodes[0], startOffset: 5, endContainer: textElement.childNodes[0], endOffset: 6}));
|
|
|
|
CSS.highlights.set("example-highlight", highlight1);
|
|
CSS.highlights.set("example-highlight", highlight2);
|
|
</script>
|
|
</body>
|
|
</html>
|