Files
sousa-gecko/testing/tools/minidumpwriter/minidumpwriter.cpp
T
Gabriele Svelto a805e95c66 Bug 1998231 - [mozcrash] Fix a race when terminating a process that had already shut down on Windows r=afranchuk
This handles the scenario when mozcrash attempts to terminate a process,
but the process has already shut down, which is a possible race within
this code. It also changes the minidumpwriter helper so that it won't
report an error when trying to capture a minidump of a process that has
already stopped running.

Differential Revision: https://phabricator.services.mozilla.com/D271387
2025-11-10 13:41:18 +00:00

64 lines
1.9 KiB
C++

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
/*
* Given a PID and a path to a target file, write a minidump of the
* corresponding process in that file. This is taken more or less
* verbatim from mozcrash and translated to C++ to avoid problems
* writing a minidump of 64 bit Firefox from a 32 bit python.
*/
#include <stdio.h>
#include <stdlib.h>
#include <windows.h>
#include <dbghelp.h>
int wmain(int argc, wchar_t** argv) {
if (argc != 3) {
fprintf(stderr, "Usage: minidumpwriter <PID> <DUMP_FILE>\n");
return 1;
}
DWORD pid = (DWORD)_wtoi(argv[1]);
if (pid <= 0) {
fprintf(stderr, "Usage: minidumpwriter <PID> <DUMP_FILE>\n");
return 1;
}
wchar_t* dumpfile = argv[2];
int rv = 1;
HANDLE hProcess =
OpenProcess(PROCESS_QUERY_INFORMATION | PROCESS_VM_READ, 0, pid);
if (!hProcess) {
fprintf(stderr, "Couldn't get handle for %lu\n", pid);
return rv;
}
HANDLE file = CreateFileW(dumpfile, GENERIC_WRITE, 0, nullptr, CREATE_ALWAYS,
FILE_ATTRIBUTE_NORMAL, nullptr);
if (file == INVALID_HANDLE_VALUE) {
fprintf(stderr, "Couldn't open dump file at %S\n", dumpfile);
CloseHandle(hProcess);
return rv;
}
rv = 0;
if (!MiniDumpWriteDump(hProcess, pid, file, MiniDumpNormal, nullptr, nullptr,
nullptr)) {
fprintf(stderr, "Error 0x%lX in MiniDumpWriteDump\n", GetLastError());
DWORD status = 0;
if (!GetExitCodeProcess(hProcess, &status) || (status == STILL_ACTIVE)) {
// We return an error only if the process was still running. If we failed
// because the process had already been terminated then don't consider it
// an actual error.
rv = 1;
}
}
CloseHandle(file);
CloseHandle(hProcess);
return rv;
}