Ryan VanderMeulen
6f2b9e55f3
The sample apps' layouts used unstyled buttons. Apply the shared Mozac.Widgets.NeutralButton style (adding the ui-widgets dependency where needed) and drop the ButtonStyleXmlDetector baseline entries. Differential Revision: https://phabricator.services.mozilla.com/D310438
27 lines
1.3 KiB
XML
27 lines
1.3 KiB
XML
<?xml version="1.0" encoding="UTF-8"?>
|
|
<issues format="6" by="lint 9.2.1" type="baseline" client="gradle" dependencies="false" name="AGP (9.2.1)" variant="all" version="9.2.1">
|
|
|
|
<issue
|
|
id="NoSystemCurrentTimeMillis"
|
|
message="`System.currentTimeMillis()` must be injectable. Only permitted as a default value of a parameter on a top-level function or on a class."
|
|
errorLine1=" components.webAppManifestStorage.warmUpScopes(System.currentTimeMillis())"
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/java/org/mozilla/samples/browser/SampleApplication.kt"
|
|
line="85"
|
|
column="59"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="MozMultipleConstraintLayoutsAndCustomViews"
|
|
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
|
|
errorLine1=" <mozilla.components.feature.readerview.view.ReaderViewControlsBar"
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/layout/fragment_browser.xml"
|
|
line="58"
|
|
column="10"/>
|
|
</issue>
|
|
|
|
</issues>
|