There's still a ton of things that can be cleaned up after this, but this setup is nicer. For now, editor keeps getting set-up / torn down on BindToFrame. Seems all that could be untangled, but step by step. The preview stuff and placeholder can just be created on demand now, rather than requiring frame reconstruction. Also, nsSearchControlFrame and co no longer do anything of interest, so move the still relevant bits elsewhere and remove them. test_bug1248459.html is removed because it messes with the editor selection using SpecialPowers, in a way such that it crosses shadow boundaries, and messes up the selected state triggering debug asserts. test_focus_docnav.xhtml now triggers a different code-path because of the shadow root (rather than the frame tree traversal). Keep it working for now by replacing it with something that isn't a shadow root. Differential Revision: https://phabricator.services.mozilla.com/D282953
46 lines
1.4 KiB
HTML
46 lines
1.4 KiB
HTML
<!doctype html>
|
|
<meta charset="utf-8">
|
|
<title>Test for bug 1658302: We don't reframe for placeholder attribute value changes.</title>
|
|
<link rel="author" href="mailto:emilio@crisal.io" title="Emilio Cobos Álvarez">
|
|
<script src="/tests/SimpleTest/SimpleTest.js"></script>
|
|
<input id="input">
|
|
<textarea id="textarea"></textarea>
|
|
<script>
|
|
SimpleTest.waitForExplicitFinish();
|
|
const utils = SpecialPowers.DOMWindowUtils;
|
|
|
|
function expectReframe(shouldHaveReframed, callback) {
|
|
document.documentElement.offsetTop;
|
|
const previousConstructCount = utils.framesConstructed;
|
|
const previousReflowCount = utils.framesReflowed;
|
|
|
|
callback();
|
|
|
|
document.documentElement.offsetTop;
|
|
isnot(previousReflowCount, utils.framesReflowed, "We should have reflowed");
|
|
(shouldHaveReframed ? isnot : is)(previousConstructCount,
|
|
utils.framesConstructed,
|
|
`We should ${shouldHaveReframed ? "" : "not"} have reframed`);
|
|
}
|
|
|
|
for (const control of document.querySelectorAll("input, textarea")) {
|
|
// Creating the placeholder attribute reframes right now.
|
|
//
|
|
// TODO: Could be avoided with some more work.
|
|
expectReframe(true, () => {
|
|
control.placeholder = "foo";
|
|
});
|
|
|
|
// Incrementally changing it should not reframe, just reflow.
|
|
expectReframe(false, () => {
|
|
control.placeholder = "bar";
|
|
});
|
|
|
|
expectReframe(false, () => {
|
|
control.removeAttribute("placeholder");
|
|
});
|
|
}
|
|
|
|
SimpleTest.finish();
|
|
</script>
|