Instead of opting these storage/toolkit tests out of SQLite encryption, assert
the correct behavior in BOTH the encrypted and plaintext configurations
(detected via the security.storage.encryption.sqlite.enabled pref):
- test_storage_service: a directory-as-database open surfaces NS_ERROR_FAILURE
through obfsvfs (and records no open telemetry) vs NS_ERROR_FILE_ACCESS_DENIED
/ Glean "access" on the plain VFS.
- test_vacuum: obfsvfs forces a fixed page size, so a VACUUM cannot change it
(expect unchanged vs 1024); and an encrypted database keeps full auto_vacuum
(1) rather than switching to incremental (2).
- test_sqlite_autoVacuum: a fresh encrypted database reports full auto_vacuum
(1), which reclaims freed pages at commit, so there is no freelist for an idle
VACUUM to reclaim; assert that auto-reclaim behavior instead.
- test_cache_size: the requested page size is ignored under encryption (cache
size is KiB-based and unchanged).
- test_sqlite_secure_delete: an encrypted database never stores the plaintext on
disk, so the pre-delete "string is present" check only applies unencrypted;
the post-delete absence check holds in both modes.
Add test_encryption_rejects_plaintext, asserting the fail-closed contract
directly: with encryption on, an in-profile database that is not encrypted (a
foreign plaintext database) is refused rather than opened as plaintext; with
encryption off it opens normally.
Finally, the places, IndexedDB and dom/cache migration/upgrade tests ship
pre-built PLAINTEXT profile/database fixtures and migrate them to the current
schema. An encrypting build cannot read those plaintext databases (obfsvfs
requires its own page format and there is no plaintext->encrypted migration by
design), and never legitimately encounters a foreign plaintext profile. Their
schema-migration logic is VFS-agnostic and is covered with encryption off, so
run those fixture tests with encryption disabled, each manifest entry carrying a
short comment.
Verified passing both with and without SQLite encryption.
Differential Revision: https://phabricator.services.mozilla.com/D305033
Benjamin Beurdouche
098a954a49