Files
sousa-gecko/devtools/client/inspector/rules/test/browser_rules_edit-property-commit.js
T
Alexandre Poirot e34b3d9044 Bug 2032221 - [devtools] Avoid triggerring rule view updates when previewing the same value. r=devtools-reviewers,nchevobbe
Any code asking for a declaration change preview will trigger unecessary
updates if the value is the same as the current value.
Because of this we were awaiting for more than one rule-view-changed
event in a couple of tests.

It looks like we can also get rid of `flushCount` workaround.

Shapes highlighter are now doing full updates instead of light preview+commit.

Differential Revision: https://phabricator.services.mozilla.com/D294905
2026-06-08 12:55:04 +00:00

102 lines
2.4 KiB
JavaScript

/* Any copyright is dedicated to the Public Domain.
http://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
// Test original value is correctly displayed when ESCaping out of the
// inplace editor in the style inspector.
const TEST_URI = `
<style type='text/css'>
#testid {
color: #00F;
}
</style>
<div id='testid'>Styled Node</div>
`;
// Test data format
// {
// value: what char sequence to type,
// commitKey: what key to type to "commit" the change,
// modifiers: commitKey modifiers,
// expected: what value is expected as a result
// }
const testData = [
{
value: "red",
commitKey: "VK_ESCAPE",
modifiers: {},
expected: "#00F",
},
{
value: "red",
commitKey: "VK_RETURN",
modifiers: {},
expected: "red",
},
{
value: "invalid",
commitKey: "VK_RETURN",
modifiers: {},
expected: "invalid",
},
{
value: "blue",
commitKey: "VK_TAB",
modifiers: { shiftKey: true },
expected: "blue",
},
];
add_task(async function () {
await addTab("data:text/html;charset=utf-8," + encodeURIComponent(TEST_URI));
const { inspector, view } = await openRuleView();
await selectNode("#testid", inspector);
for (const data of testData) {
await runTestData(view, data);
}
});
async function runTestData(view, { value, commitKey, modifiers, expected }) {
const idRuleEditor = getRuleViewRuleEditorAt(view, 1);
const propEditor = idRuleEditor.rule.textProps[0].editor;
info("Focusing the inplace editor field");
const editor = await focusEditableField(view, propEditor.valueSpan);
is(
inplaceEditor(propEditor.valueSpan),
editor,
"Focused editor should be the value span."
);
info("Entering test data " + value);
const onRuleViewChanged = view.once("ruleview-changed");
EventUtils.sendString(value, view.styleWindow);
view.debounce.flush();
await onRuleViewChanged;
info("Entering the commit key " + commitKey + " " + modifiers);
const onModifications = view.once("property-value-updated");
const onBlur = once(editor.input, "blur");
EventUtils.synthesizeKey(commitKey, modifiers);
await onBlur;
await onModifications;
if (commitKey === "VK_ESCAPE") {
is(
propEditor.valueSpan.textContent,
expected,
"Value is as expected: " + expected
);
} else {
is(
propEditor.valueSpan.textContent,
expected,
"Value is as expected: " + expected
);
}
}