UrlbarProviderGlobalActions.onEngagement closed the view after a pick, but the
content-side pick handling (UrlbarInput.pickResult) already closes it. On the
message path that hook runs parent-side and its close round-trips back
asynchronously, arriving after a freshly-typed query has started and cancelling
it, so the view never opened. Dropping the redundant close is behavior-neutral
on the direct path: every global-action pick is where=current (they open no
URL), so pickResult always closes.
The rest is test-only. A provider engagement hook runs parent-side, so on the
message path a pick's side effect -- the action firing, a page opening, a tab
refocus -- lands asynchronously; tests that asserted it synchronously now await
it. Unchanged on the direct path, where it stays synchronous.
Differential Revision: https://phabricator.services.mozilla.com/D311135
Dão Gottwald
94a6ac7a5d