Chris Peterson
a39a4321b0
xpcom/base/MacStringHelpers.mm:21:11: warning: result of comparison 'NSUInteger' (aka 'unsigned long') > 18446744073709551615 is always false [-Wtautological-type-limit-compare]
21 | if (len > std::numeric_limits<nsAString::size_type>::max()) {
Remove an always-false length check in CopyNSStringToXPCOMString(). The
function checked len > std::numeric_limits<nsAString::size_type>::max(),
but both types are 64-bits because we no longer compile for 32-bit macOS.
The check was also unnecessary because nsTString::SetLength() is
infallible and MOZ_RELEASE_ASSERTs if a caller exceeds kMaxCapacity
(0x3FFFFFFE for char16_t nsTStrings, much smaller then size_t max).
Differential Revision: https://phabricator.services.mozilla.com/D309817
45 lines
1.3 KiB
Plaintext
45 lines
1.3 KiB
Plaintext
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "MacStringHelpers.h"
|
|
#include "nsObjCExceptions.h"
|
|
|
|
namespace mozilla {
|
|
|
|
void CopyNSStringToXPCOMString(const NSString* aFrom, nsAString& aTo) {
|
|
NS_OBJC_BEGIN_TRY_IGNORE_BLOCK;
|
|
|
|
if (!aFrom) {
|
|
aTo.Truncate();
|
|
return;
|
|
}
|
|
|
|
NSUInteger len = [aFrom length];
|
|
aTo.SetLength(len);
|
|
[aFrom getCharacters:reinterpret_cast<unichar*>(aTo.BeginWriting())
|
|
range:NSMakeRange(0, len)];
|
|
|
|
NS_OBJC_END_TRY_IGNORE_BLOCK;
|
|
}
|
|
|
|
NSString* XPCOMStringToNSString(const nsAString& aFrom) {
|
|
if (aFrom.IsEmpty()) {
|
|
return [NSString string];
|
|
}
|
|
return [NSString stringWithCharacters:reinterpret_cast<const unichar*>(
|
|
aFrom.BeginReading())
|
|
length:aFrom.Length()];
|
|
}
|
|
|
|
NSString* XPCOMStringToNSString(const nsACString& aFrom) {
|
|
if (aFrom.IsEmpty()) {
|
|
return [NSString string];
|
|
}
|
|
return [[[NSString alloc] initWithBytes:aFrom.BeginReading()
|
|
length:aFrom.Length()
|
|
encoding:NSUTF8StringEncoding] autorelease];
|
|
}
|
|
|
|
} // namespace mozilla
|