Files
Eden Chuang 7f45911100 Bug 2039452 - Validate file:// URIs in PExternalHelperApp against the sending process's remote type. r=dom-core-reviewers,sfarre
The parent derived the native helper-launch decision from a
content-process supplied aWasFileChannel flag and URI rather than
binding it to the sending process's capabilities.

Stop sending aWasFileChannel over IPC and derive it on the parent from
the actual URI, and reject a file:// URI in PExternalHelperApp from a
process that is not allowed to load local files (mirrors the file://
policy in ValidatePrincipalCouldPotentiallyBeLoadedBy).

Differential Revision: https://phabricator.services.mozilla.com/D309577
2026-07-08 07:59:28 +00:00

107 lines
3.1 KiB
C++

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef mozilla_dom_ExternalHelperAppParent_h
#define mozilla_dom_ExternalHelperAppParent_h
#include "mozilla/dom/PExternalHelperAppParent.h"
#include "mozilla/ipc/BackgroundUtils.h"
#include "nsIChannel.h"
#include "nsIMultiPartChannel.h"
#include "nsIResumableChannel.h"
#include "nsIStreamListener.h"
#include "nsHashPropertyBag.h"
#include "mozilla/net/PrivateBrowsingChannel.h"
namespace IPC {
class URI;
} // namespace IPC
class nsExternalAppHandler;
namespace mozilla {
namespace net {
class PChannelDiverterParent;
} // namespace net
namespace dom {
#define NS_IEXTERNALHELPERAPPPARENT_IID \
{0x127a01bc, 0x2a49, 0x46a8, {0x8c, 0x63, 0x4b, 0x5d, 0x3c, 0xa4, 0x07, 0x9c}}
class nsIExternalHelperAppParent : public nsISupports {
public:
NS_INLINE_DECL_STATIC_IID(NS_IEXTERNALHELPERAPPPARENT_IID)
/**
* Returns true if this fake channel represented a file channel in the child.
*/
virtual bool WasFileChannel() = 0;
};
class ContentParent;
class PBrowserParent;
class ExternalHelperAppParent
: public PExternalHelperAppParent,
public nsHashPropertyBag,
public nsIChannel,
public nsIMultiPartChannel,
public nsIResumableChannel,
public nsIStreamListener,
public net::PrivateBrowsingChannel<ExternalHelperAppParent>,
public nsIExternalHelperAppParent {
public:
NS_DECL_ISUPPORTS_INHERITED
NS_DECL_NSIREQUEST
NS_DECL_NSICHANNEL
NS_DECL_NSIMULTIPARTCHANNEL
NS_DECL_NSIRESUMABLECHANNEL
NS_DECL_NSISTREAMLISTENER
NS_DECL_NSIREQUESTOBSERVER
mozilla::ipc::IPCResult RecvOnStartRequest(
const nsACString& entityID) override;
mozilla::ipc::IPCResult RecvOnDataAvailable(const nsACString& data,
const uint64_t& offset) override;
mozilla::ipc::IPCResult RecvOnStopRequest(const nsresult& code) override;
bool WasFileChannel() override { return mWasFileChannel; }
ExternalHelperAppParent(nsIURI* uri, const int64_t& contentLength,
const nsACString& aContentDispositionHeader,
const uint32_t& aContentDispositionHint,
const nsAString& aContentDispositionFilename);
bool Init(const mozilla::net::LoadInfoArgs& aLoadInfoArgs,
const nsACString& aMimeContentType, const bool& aForceSave,
nsIURI* aReferrer, BrowsingContext* aContext);
protected:
virtual ~ExternalHelperAppParent();
virtual void ActorDestroy(ActorDestroyReason why) override;
void Delete();
private:
RefPtr<nsIStreamListener> mListener;
nsCOMPtr<nsIURI> mURI;
nsCOMPtr<nsILoadInfo> mLoadInfo;
bool mPending;
bool mIPCClosed;
nsLoadFlags mLoadFlags;
nsresult mStatus;
bool mCanceled;
int64_t mContentLength;
bool mWasFileChannel;
uint32_t mContentDisposition;
nsString mContentDispositionFilename;
nsCString mContentDispositionHeader;
nsCString mEntityID;
};
} // namespace dom
} // namespace mozilla
#endif