Michael Froman
5b11b5bd6a
Upstream commit: https://webrtc.googlesource.com/src/+/93173ec4f5fdf71a9249e56e87707ccae750ad52 Restrict rtc_event_log.proto to offline tools + add documentation 1. Remove the legacy rtc_event_log_proto dependency from the production libwebrtc static library GN target in root BUILD.gn. 2. Restrict proto_library("rtc_event_log_proto") visibility in logging/BUILD.gn exclusively to offline parsers, neteq tools, and test suites to prevent accidental linking into production runtimes. 3. Add a deprecation banner and usage instruction to rtc_event_log.proto, update doc comments in rtc_event_log.h, and add a dedicated section in logging/g3doc/rtc_event_log.md guiding humans and AI agents on format rules. CONV=ac69de71-4eeb-4b00-b142-f66d9edf397b Bug: webrtc:144833892 Change-Id: I91f19d1f9664ecf17e38e0fa44a46b854361d6bd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/493540 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org> Cr-Commit-Position: refs/heads/main@{#48287}
32 lines
1.1 KiB
Diff
32 lines
1.1 KiB
Diff
From: Michael Froman <mfroman@mozilla.com>
|
|
Date: Tue, 29 Oct 2024 18:20:00 +0000
|
|
Subject: Bug 1925119 - add dcsctp to libwebrtc build. r=bwc,webrtc-reviewers
|
|
|
|
Differential Revision: https://phabricator.services.mozilla.com/D225892
|
|
Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/90a33b06e51017d25542a95c2a460bfed41c553b
|
|
---
|
|
BUILD.gn | 3 ++-
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/BUILD.gn b/BUILD.gn
|
|
index 4eb65649cd..4f97d8df91 100644
|
|
--- a/BUILD.gn
|
|
+++ b/BUILD.gn
|
|
@@ -579,6 +579,7 @@ if (!build_with_chromium) {
|
|
"call",
|
|
"common_audio",
|
|
"common_video",
|
|
+ ":dcsctp",
|
|
"logging:rtc_event_log_api",
|
|
"media",
|
|
"modules",
|
|
@@ -853,7 +854,7 @@ if (rtc_include_tests && !build_with_chromium) {
|
|
# Build target for standalone dcsctp
|
|
rtc_static_library("dcsctp") {
|
|
# Only the root target should depend on this.
|
|
- visibility = [ "//:default" ]
|
|
+ visibility = [ "//:default", "//libwebrtc:webrtc" ]
|
|
sources = []
|
|
complete_static_lib = true
|
|
suppressed_configs += [ "//chromium/build/config/compiler:thin_archive" ]
|