Michael Froman
6d038c44c4
We cherry-picked this in bug 2056029. Upstream commit: https://webrtc.googlesource.com/src/+/5da5a6e4e00c69ef60c7643e99ef34f65f7af51a video_capture: Implement buffer stride support for Pipewire Add optional buffer stride support to VideoCaptureImpl and use it in VideoCaptureModulePipeWire, allowing us to drop the requirement for unpadded buffers. This notably improves compatibility with libcamera, which supports a wider range of devices than the V4L2 backend - some having hardware requirements for stride-alignment. Extending `ConvertToI420()` in libyuv was rejected on the grounds that there are various approaches to stride handling - using a single stride value for multiple planes, having explicit values for each one etc. - as well as the fact that we might well want to extend the helper further in the future - e.g. in order to better handle color spaces such as BT709 (instead of always assuming BT601). Thus this patch now adds a local copy of `ConvertToI420()`, supporting implicit and a single explicit stride value for now. libyuv CL for context: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/8146821 Bug: chromium:538875176 Change-Id: Ic5781709cf5f20e8c75b9ad09d7052a355fcbec7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/491680 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Jan Grulich <grulja@gmail.com> Commit-Queue: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/main@{#48353}
42 lines
1.5 KiB
Diff
42 lines
1.5 KiB
Diff
From: Andreas Pehrson <apehrson@mozilla.com>
|
|
Date: Wed, 18 Oct 2023 17:21:00 +0000
|
|
Subject: Bug 1859786 - Fix lock annotation warning in Mozilla-specific edit on
|
|
top of video_capture_impl.cc. r=webrtc-reviewers,mjf
|
|
|
|
The annotations were added in M116:
|
|
https://hg.mozilla.org/mozilla-central/rev/9cd372df013948ad822ae936752d725d77474fb5
|
|
|
|
Note that this was never unsafe, since _dataCallbacks is only written on the
|
|
same thread that we are patching here. This patch however, adds helpful static
|
|
analysis.
|
|
|
|
Differential Revision: https://phabricator.services.mozilla.com/D191301
|
|
Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/56ff441b644400f09d2d0453dbd8991ea25db7b1
|
|
---
|
|
modules/video_capture/video_capture_impl.cc | 11 +++++++----
|
|
1 file changed, 7 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/modules/video_capture/video_capture_impl.cc b/modules/video_capture/video_capture_impl.cc
|
|
index 55ac30bab2..aca2b1a03c 100644
|
|
--- a/modules/video_capture/video_capture_impl.cc
|
|
+++ b/modules/video_capture/video_capture_impl.cc
|
|
@@ -132,11 +132,14 @@ void VideoCaptureImpl::DeRegisterCaptureDataCallback(
|
|
}
|
|
|
|
int32_t VideoCaptureImpl::StopCaptureIfAllClientsClose() {
|
|
- if (_dataCallBacks.empty()) {
|
|
- return StopCapture();
|
|
- } else {
|
|
- return 0;
|
|
+ RTC_DCHECK_RUN_ON(&api_checker_);
|
|
+ {
|
|
+ MutexLock lock(&api_lock_);
|
|
+ if (!_dataCallBacks.empty()) {
|
|
+ return 0;
|
|
+ }
|
|
}
|
|
+ return StopCapture();
|
|
}
|
|
|
|
int32_t VideoCaptureImpl::DeliverCapturedFrame(VideoFrame& captureFrame) {
|