Upstream commit: https://webrtc.googlesource.com/src/+/cd5f3c19d89dce8189bde370f2141a76ca7fed80 [pipewire] Followups from CL 487880. - Use RTC_CHECK when possible. - Check that the global tracking boolean is correct in ctor/dtor. - Explicitly delete move operators. Bug: chromium:40236752 Change-Id: I4f3fc3a64ae442367a23c0f8312f836864bde3fb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/494800 Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org> Auto-Submit: Mark Foltz <mfoltz@chromium.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#48314}
36 lines
1.3 KiB
Diff
36 lines
1.3 KiB
Diff
From: stransky <stransky@redhat.com>
|
|
Date: Tue, 29 Aug 2023 12:43:00 +0000
|
|
Subject: Bug 1821629 [Pipewire/DMABuf] Don't create dmabuf backend if it's
|
|
disabled r=ng,webrtc-reviewers
|
|
|
|
Depends on D172224
|
|
|
|
Differential Revision: https://phabricator.services.mozilla.com/D172229
|
|
Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/237d19fe96dd7d25b6a817415ee4e6854678d648
|
|
---
|
|
.../desktop_capture/linux/wayland/shared_screencast_stream.cc | 4 ++--
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/modules/desktop_capture/linux/wayland/shared_screencast_stream.cc b/modules/desktop_capture/linux/wayland/shared_screencast_stream.cc
|
|
index 44daf1fe03..de73bc5412 100644
|
|
--- a/modules/desktop_capture/linux/wayland/shared_screencast_stream.cc
|
|
+++ b/modules/desktop_capture/linux/wayland/shared_screencast_stream.cc
|
|
@@ -565,7 +565,7 @@ bool SharedScreenCastStreamPrivate::StartScreenCastStream(
|
|
RTC_LOG(LS_ERROR) << "Unable to open PipeWire library";
|
|
return false;
|
|
}
|
|
- if (!egl_dmabuf_) {
|
|
+ if (!egl_dmabuf_ && mozilla::gfx::IsDMABufEnabled()) {
|
|
egl_dmabuf_ = EglDmaBuf::CreateDefault();
|
|
}
|
|
|
|
@@ -1117,7 +1117,7 @@ bool SharedScreenCastStreamPrivate::ProcessDMABuffer(
|
|
|
|
const uint n_planes = spa_buffer->n_datas;
|
|
|
|
- if (!n_planes) {
|
|
+ if (!n_planes || !egl_dmabuf_) {
|
|
return false;
|
|
}
|
|
|