Michael Froman
6d038c44c4
We cherry-picked this in bug 2056029. Upstream commit: https://webrtc.googlesource.com/src/+/5da5a6e4e00c69ef60c7643e99ef34f65f7af51a video_capture: Implement buffer stride support for Pipewire Add optional buffer stride support to VideoCaptureImpl and use it in VideoCaptureModulePipeWire, allowing us to drop the requirement for unpadded buffers. This notably improves compatibility with libcamera, which supports a wider range of devices than the V4L2 backend - some having hardware requirements for stride-alignment. Extending `ConvertToI420()` in libyuv was rejected on the grounds that there are various approaches to stride handling - using a single stride value for multiple planes, having explicit values for each one etc. - as well as the fact that we might well want to extend the helper further in the future - e.g. in order to better handle color spaces such as BT709 (instead of always assuming BT601). Thus this patch now adds a local copy of `ConvertToI420()`, supporting implicit and a single explicit stride value for now. libyuv CL for context: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/8146821 Bug: chromium:538875176 Change-Id: Ic5781709cf5f20e8c75b9ad09d7052a355fcbec7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/491680 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Jan Grulich <grulja@gmail.com> Commit-Queue: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/main@{#48353}
29 lines
1.1 KiB
Diff
29 lines
1.1 KiB
Diff
From: Andreas Pehrson <apehrson@mozilla.com>
|
|
Date: Mon, 12 Dec 2022 15:47:00 +0000
|
|
Subject: Bug 1451394 - Record video frame captures with PerformanceRecorder in
|
|
the new mac camera backend. r=padenot
|
|
|
|
Also includes:
|
|
Bug 1806605 - Pass TrackingId instead of nsCString to CaptureStage.
|
|
|
|
Differential Revision: https://phabricator.services.mozilla.com/D163687
|
|
Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/a7362238c9e6fbe0d28200f6b41fc40a0c9a2158
|
|
---
|
|
modules/video_capture/video_capture.h | 3 +++
|
|
1 file changed, 3 insertions(+)
|
|
|
|
diff --git a/modules/video_capture/video_capture.h b/modules/video_capture/video_capture.h
|
|
index 9f018e55f2..e04211f2cd 100644
|
|
--- a/modules/video_capture/video_capture.h
|
|
+++ b/modules/video_capture/video_capture.h
|
|
@@ -160,6 +160,9 @@ class VideoCaptureModule : public RefCountInterface {
|
|
virtual void SetStride(int32_t stride) {}
|
|
virtual int32_t GetStride() { return 0; }
|
|
|
|
+ // Mozilla: TrackingId setter for use in profiler markers.
|
|
+ virtual void SetTrackingId(uint32_t aTrackingIdProcId) {}
|
|
+
|
|
protected:
|
|
~VideoCaptureModule() override {}
|
|
};
|