Upstream commit: https://webrtc.googlesource.com/src/+/d370c22579378dca65e514dca5c6944d16bb4fce Hdrext: Replace ABSL_DEPRECATE_AND_INLINE with [[deprecated]] Replaced ABSL_DEPRECATE_AND_INLINE with [[deprecated]] ABSL_REFACTOR_INLINE in api/rtp_parameters.h, modules/rtp_rtcp/include/rtp_header_extension_map.h, and modules/rtp_rtcp/source/rtp_rtcp_interface.h. Bug: webrtc:514817938 Change-Id: I73bb17ea32a6eab44804d284fdeaef130f14fc29 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/477480 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#47911}
172 lines
6.0 KiB
Diff
172 lines
6.0 KiB
Diff
From: Andreas Pehrson <apehrson@mozilla.com>
|
|
Date: Mon, 18 Jan 2021 11:07:00 +0100
|
|
Subject: Bug 1766646 - (fix-ae0d117d51) ifdef our Csrc impl vs upstream's
|
|
impl, see Bug 1771332.
|
|
|
|
---
|
|
modules/rtp_rtcp/source/rtp_header_extensions.cc | 4 ++++
|
|
modules/rtp_rtcp/source/rtp_header_extensions.h | 4 ++++
|
|
modules/rtp_rtcp/source/rtp_packet.cc | 4 ++++
|
|
modules/rtp_rtcp/source/rtp_sender.cc | 4 ++++
|
|
test/fuzzers/rtp_packet_fuzzer.cc | 4 ++++
|
|
5 files changed, 20 insertions(+)
|
|
|
|
diff --git a/modules/rtp_rtcp/source/rtp_header_extensions.cc b/modules/rtp_rtcp/source/rtp_header_extensions.cc
|
|
index 4dd236f58d..6c30b519f8 100644
|
|
--- a/modules/rtp_rtcp/source/rtp_header_extensions.cc
|
|
+++ b/modules/rtp_rtcp/source/rtp_header_extensions.cc
|
|
@@ -182,6 +182,7 @@ bool AudioLevelExtension::Write(std::span<uint8_t> data,
|
|
return true;
|
|
}
|
|
|
|
+#if !defined(WEBRTC_MOZILLA_BUILD)
|
|
// An RTP Header Extension for Mixer-to-Client Audio Level Indication
|
|
//
|
|
// https://tools.ietf.org/html/rfc6465
|
|
@@ -230,6 +231,7 @@ bool CsrcAudioLevel::Write(std::span<uint8_t> data,
|
|
}
|
|
return true;
|
|
}
|
|
+#endif
|
|
|
|
// From RFC 5450: Transmission Time Offsets in RTP Streams.
|
|
//
|
|
@@ -422,6 +424,7 @@ bool PlayoutDelayLimits::Write(std::span<uint8_t> data,
|
|
return true;
|
|
}
|
|
|
|
+#if defined(WEBRTC_MOZILLA_BUILD)
|
|
// CSRCAudioLevel
|
|
// Sample Audio Level Encoding Using the One-Byte Header Format
|
|
// Note that the range of len is 1 to 15 which is encoded as 0 to 14
|
|
@@ -460,6 +463,7 @@ bool CsrcAudioLevel::Write(std::span<uint8_t> data,
|
|
// This extension if used must have at least one audio level
|
|
return csrcAudioLevels.numAudioLevels;
|
|
}
|
|
+#endif
|
|
|
|
// Video Content Type.
|
|
//
|
|
diff --git a/modules/rtp_rtcp/source/rtp_header_extensions.h b/modules/rtp_rtcp/source/rtp_header_extensions.h
|
|
index 12405e1646..b5148dff8c 100644
|
|
--- a/modules/rtp_rtcp/source/rtp_header_extensions.h
|
|
+++ b/modules/rtp_rtcp/source/rtp_header_extensions.h
|
|
@@ -110,6 +110,7 @@ class AudioLevelExtension {
|
|
static bool Write(std::span<uint8_t> data, const AudioLevel& extension);
|
|
};
|
|
|
|
+#if !defined(WEBRTC_MOZILLA_BUILD)
|
|
class CsrcAudioLevel {
|
|
public:
|
|
static constexpr RTPExtensionType kId = kRtpExtensionCsrcAudioLevel;
|
|
@@ -124,6 +125,7 @@ class CsrcAudioLevel {
|
|
static bool Write(std::span<uint8_t> data,
|
|
std::span<const uint8_t> csrc_audio_levels);
|
|
};
|
|
+#endif
|
|
|
|
class TransmissionOffset {
|
|
public:
|
|
@@ -309,6 +311,7 @@ class ColorSpaceExtension {
|
|
static size_t WriteLuminance(uint8_t* data, float f, int denominator);
|
|
};
|
|
|
|
+#if defined(WEBRTC_MOZILLA_BUILD)
|
|
class CsrcAudioLevel {
|
|
public:
|
|
static constexpr RTPExtensionType kId = kRtpExtensionCsrcAudioLevel;
|
|
@@ -324,6 +327,7 @@ class CsrcAudioLevel {
|
|
static bool Write(std::span<uint8_t> data,
|
|
const CsrcAudioLevelList& csrcAudioLevels);
|
|
};
|
|
+#endif
|
|
|
|
// Base extension class for RTP header extensions which are strings.
|
|
// Subclasses must defined kId and kUri static constexpr members.
|
|
diff --git a/modules/rtp_rtcp/source/rtp_packet.cc b/modules/rtp_rtcp/source/rtp_packet.cc
|
|
index 3fc8044d55..ef78a45945 100644
|
|
--- a/modules/rtp_rtcp/source/rtp_packet.cc
|
|
+++ b/modules/rtp_rtcp/source/rtp_packet.cc
|
|
@@ -194,7 +194,9 @@ void RtpPacket::ZeroMutableExtensions() {
|
|
break;
|
|
}
|
|
case RTPExtensionType::kRtpExtensionAudioLevel:
|
|
+#if !defined(WEBRTC_MOZILLA_BUILD)
|
|
case RTPExtensionType::kRtpExtensionCsrcAudioLevel:
|
|
+#endif
|
|
case RTPExtensionType::kRtpExtensionAbsoluteCaptureTime:
|
|
case RTPExtensionType::kRtpExtensionColorSpace:
|
|
case RTPExtensionType::kRtpExtensionCorruptionDetection:
|
|
@@ -213,10 +215,12 @@ void RtpPacket::ZeroMutableExtensions() {
|
|
// Non-mutable extension. Don't change it.
|
|
break;
|
|
}
|
|
+#if defined(WEBRTC_MOZILLA_BUILD)
|
|
case RTPExtensionType::kRtpExtensionCsrcAudioLevel: {
|
|
// TODO: This is a Mozilla addition, we need to add a handler for this.
|
|
RTC_CHECK(false);
|
|
}
|
|
+#endif
|
|
}
|
|
}
|
|
}
|
|
diff --git a/modules/rtp_rtcp/source/rtp_sender.cc b/modules/rtp_rtcp/source/rtp_sender.cc
|
|
index 7293a99aee..5de673c258 100644
|
|
--- a/modules/rtp_rtcp/source/rtp_sender.cc
|
|
+++ b/modules/rtp_rtcp/source/rtp_sender.cc
|
|
@@ -115,7 +115,9 @@ bool IsNonVolatile(RTPExtensionType type) {
|
|
switch (type) {
|
|
case kRtpExtensionTransmissionTimeOffset:
|
|
case kRtpExtensionAudioLevel:
|
|
+#if !defined(WEBRTC_MOZILLA_BUILD)
|
|
case kRtpExtensionCsrcAudioLevel:
|
|
+#endif
|
|
case kRtpExtensionAbsoluteSendTime:
|
|
case kRtpExtensionTransportSequenceNumber:
|
|
case kRtpExtensionTransportSequenceNumber02:
|
|
@@ -140,10 +142,12 @@ bool IsNonVolatile(RTPExtensionType type) {
|
|
case kRtpExtensionNumberOfExtensions:
|
|
RTC_DCHECK_NOTREACHED();
|
|
return false;
|
|
+#if defined(WEBRTC_MOZILLA_BUILD)
|
|
case kRtpExtensionCsrcAudioLevel:
|
|
// TODO: Mozilla implement for CsrcAudioLevel
|
|
RTC_CHECK(false);
|
|
return false;
|
|
+#endif
|
|
}
|
|
RTC_CHECK_NOTREACHED();
|
|
}
|
|
diff --git a/test/fuzzers/rtp_packet_fuzzer.cc b/test/fuzzers/rtp_packet_fuzzer.cc
|
|
index 21479a54ae..4d914ccdfd 100644
|
|
--- a/test/fuzzers/rtp_packet_fuzzer.cc
|
|
+++ b/test/fuzzers/rtp_packet_fuzzer.cc
|
|
@@ -89,11 +89,13 @@ void FuzzOneInput(FuzzDataHelper fuzz_data) {
|
|
packet.GetExtension<AudioLevelExtension>(&audio_level);
|
|
break;
|
|
}
|
|
+#if !defined(WEBRTC_MOZILLA_BUILD)
|
|
case kRtpExtensionCsrcAudioLevel: {
|
|
std::vector<uint8_t> audio_levels;
|
|
packet.GetExtension<CsrcAudioLevel>(&audio_levels);
|
|
break;
|
|
}
|
|
+#endif
|
|
case kRtpExtensionAbsoluteSendTime:
|
|
uint32_t sendtime;
|
|
packet.GetExtension<AbsoluteSendTime>(&sendtime);
|
|
@@ -183,11 +185,13 @@ void FuzzOneInput(FuzzDataHelper fuzz_data) {
|
|
CorruptionDetectionMessage message;
|
|
packet.GetExtension<CorruptionDetectionExtension>(&message);
|
|
break;
|
|
+#if defined(WEBRTC_MOZILLA_BUILD)
|
|
case kRtpExtensionCsrcAudioLevel: {
|
|
CsrcAudioLevelList levels;
|
|
packet.GetExtension<CsrcAudioLevel>(&levels);
|
|
break;
|
|
}
|
|
+#endif
|
|
}
|
|
}
|
|
|