Michael Froman
ee7a181293
Upstream commit: https://webrtc.googlesource.com/src/+/4a5162270501ed2f93d036300bdeadc3a4d03d13 TaskQueueFactory: Add kAudio and kVideo priorities This change introduces specific priority levels for audio and video tasks within the TaskQueueFactory to allow for better platform-specific thread scheduling. Changes: * New field trial WebRTC-MediaTaskQueuePriorities that activates the priority change. * New Priority Enums: Added kVideo and kAudio to TaskQueueFactory::Priority and corresponding kVideo and kAudio to ThreadPriority. * WebRTC platform thread implementation: - Video priority initially maps to high priority. - On Mac/iOS (GCD), both audio and video map to DISPATCH_QUEUE_PRIORITY_HIGH because of API limitation. * Task queue updates: - Updated the audio encoder queue to use kAudio priority. - Updated the video encoder & decoder, incoming video stream, and video frame transformer queues to use kVideo priority. * Queue renaming: Standardized several task queue names by appending "Queue" (e.g., "AudioEncoder" became "AudioEncoderQueue"). Bug: chromium:470337728 Change-Id: I4790990340a72a54945750c2c4e1f97314edf375 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/436580 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Markus Handell <handellm@webrtc.org> Cr-Commit-Position: refs/heads/main@{#46744}
47 lines
1.8 KiB
Diff
47 lines
1.8 KiB
Diff
From: Dan Minor <dminor@mozilla.com>
|
|
Date: Mon, 5 Nov 2018 10:33:00 -0500
|
|
Subject: Bug 1376873 - Reduce thread stack size in platform_thread.cc; r=bwc
|
|
|
|
Summary:
|
|
The current default stack size of 1M results in intermittent OOMs on win32
|
|
builds while running web-platform tests. The value of 256k was chosen for
|
|
consistency with the default value used elsewhere in Gecko, which is defined in
|
|
nsIThreadManager.idl.
|
|
|
|
Reviewers: bwc
|
|
|
|
Tags: #secure-revision
|
|
|
|
Bug #: 1376873
|
|
|
|
Differential Revision: https://phabricator.services.mozilla.com/D11090
|
|
Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/e83c311e5293902be4db4ecea17cff87c633f7cf
|
|
---
|
|
rtc_base/platform_thread.cc | 6 ++++--
|
|
1 file changed, 4 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/rtc_base/platform_thread.cc b/rtc_base/platform_thread.cc
|
|
index 2fee9eb44c..1b2e289779 100644
|
|
--- a/rtc_base/platform_thread.cc
|
|
+++ b/rtc_base/platform_thread.cc
|
|
@@ -204,15 +204,17 @@ PlatformThread PlatformThread::SpawnThread(
|
|
// Set the reserved stack stack size to 1M, which is the default on Windows
|
|
// and Linux.
|
|
DWORD thread_id = 0;
|
|
+ // Mozilla: Set to 256kb for consistency with nsIThreadManager.idl
|
|
PlatformThread::Handle handle = ::CreateThread(
|
|
- nullptr, 1024 * 1024, &RunPlatformThread, start_thread_function_ptr,
|
|
+ nullptr, 256 * 1024, &RunPlatformThread, start_thread_function_ptr,
|
|
STACK_SIZE_PARAM_IS_A_RESERVATION, &thread_id);
|
|
RTC_CHECK(handle) << "CreateThread failed";
|
|
#else
|
|
pthread_attr_t attr;
|
|
pthread_attr_init(&attr);
|
|
// Set the stack stack size to 1M.
|
|
- pthread_attr_setstacksize(&attr, 1024 * 1024);
|
|
+ // Mozilla: Set to 256kb for consistency with nsIThreadManager.idl
|
|
+ pthread_attr_setstacksize(&attr, 256 * 1024);
|
|
pthread_attr_setdetachstate(
|
|
&attr, joinable ? PTHREAD_CREATE_JOINABLE : PTHREAD_CREATE_DETACHED);
|
|
PlatformThread::Handle handle;
|