Michael Froman
551a8b59e0
(skip-generation) Upstream commit: https://webrtc.googlesource.com/src/+/42995c384b59f0da002a6078d4a0320af39a16b8 Add Sframe decryptor implementation Bug: webrtc:479862368 Change-Id: I97f293c4cdfd249ea12dbd279133bb0bfc2e2c06 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/488083 Reviewed-by: Björn Terelius <terelius@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/main@{#48351}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.- Avoid structs in api, prefer classes.
The preferred way for api/ code to access non-api/ code is to call it from a
.cc file, so that users of our API headers won’t transitively #include
non-public headers.
For headers in api/ that need to refer to non-api/ types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.
Avoid defining api with structs as it makes harder for the api to evolve. Your struct may gain invariant, or change how it represents data. Evolving struct from the api is particularly challenging as it is designed to be used in other code bases and thus needs to be updated independently from its usage. Class with accessors and setters makes such migration safer. See Google C++ style guide for more.
If you need to evolve an existing struct in api, prefer first to convert it into a class.