Ryan VanderMeulen
2ef77c8c6d
Rebased onto chromium third_party cd3dd0a61f8. Drops the ABSL_HAVE_THREAD_SANITIZER and ABSL_HAVE_LEAK_SANITIZER disables, which the preceding system-header change makes unnecessary; the -Wsign-compare suppression, which protobuf v36 no longer needs; and the android api < 17 SYS_mmap2 patch, replaced by the next commit. Consolidates the remaining eleven local patches into six. Differential Revision: https://phabricator.services.mozilla.com/D322121
39 lines
1.3 KiB
Diff
39 lines
1.3 KiB
Diff
From: Ryan VanderMeulen <rvandermeulen@mozilla.com>
|
|
Date: Sun, 23 Aug 2026 13:55:24 -0400
|
|
Subject: Bug 1974813, Bug 1965053 - abseil-cpp compiler flag adjustments in
|
|
absl.gni.
|
|
|
|
Drops the prevent_unsafe_narrowing config, which chromium/build now includes
|
|
automatically, and silences -Wcomma and -Wtautological-type-limit-compare.
|
|
Those fire on deliberate comma expressions and on portability range checks that
|
|
are tautological only on 64-bit; abseil does not enable either warning.
|
|
---
|
|
abseil-cpp/absl.gni | 14 ++++++++++++++
|
|
1 file changed, 14 insertions(+)
|
|
|
|
diff --git a/abseil-cpp/absl.gni b/abseil-cpp/absl.gni
|
|
index 3632789e941..8cb6e8b61d4 100644
|
|
--- a/abseil-cpp/absl.gni
|
|
+++ b/abseil-cpp/absl.gni
|
|
@@ -38,6 +38,20 @@ template("absl_source_set") {
|
|
"//abseil-cpp:absl_define_config",
|
|
]
|
|
|
|
+ if (moz_webrtc_build) {
|
|
+ configs -= [ "//chromium/build/config/compiler:prevent_unsafe_narrowing" ]
|
|
+
|
|
+ # Silence -Wcomma / -Wtautological-type-limit-compare spam from
|
|
+ # third-party abseil sources. See bug 1965053.
|
|
+ if (!defined(cflags_cc)) {
|
|
+ cflags_cc = []
|
|
+ }
|
|
+ cflags_cc += [
|
|
+ "-Wno-comma",
|
|
+ "-Wno-tautological-type-limit-compare",
|
|
+ ]
|
|
+ }
|
|
+
|
|
if (!defined(defines)) {
|
|
defines = []
|
|
}
|