Ben Dean-Kawamura
a4d7085661
Make clippy a global linter. This means it only runs once per workspace, which is good because `cargo` handles parallelization internally. There's no reason to split things out into multiple commands. Updated the global linter config handling to pass a list of files. This is needed for clippy and we can just ignore them for the android lints. Updated the clippy linter to work with crates outside of `gkrust`. For these crates, we call `cargo clippy` directly and does not filter by path name. These crates need to be listed in `tools/lint/clippy.yml`, currently this is only `uniffi-bindgen-gecko-js`, but it's easy to add more. Fixed some lint warnings in the `mozlint` package itself. Differential Revision: https://phabricator.services.mozilla.com/D246488
39 lines
1.3 KiB
Python
39 lines
1.3 KiB
Python
# This Source Code Form is subject to the terms of the Mozilla Public
|
|
# License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
|
|
import mozpack.path as mozpath
|
|
from external import external
|
|
from mozpack.files import FileFinder
|
|
|
|
from mozlint import result
|
|
|
|
|
|
def global_payload(_paths, config, **lintargs):
|
|
# A global linter that runs the external linter to actually lint.
|
|
finder = FileFinder(lintargs["root"])
|
|
files = [mozpath.join(lintargs["root"], p) for p, _ in finder.find("files/**")]
|
|
issues = external(files, config, **lintargs)
|
|
for issue in issues:
|
|
# Make issue look like it comes from this linter.
|
|
issue.linter = "global_payload"
|
|
return issues
|
|
|
|
|
|
def global_skipped(config, **lintargs):
|
|
# A global linter that always registers a lint error. Absence of
|
|
# this error shows that the path exclusion mechanism can cause
|
|
# global lint payloads to not be invoked at all. In particular,
|
|
# the `extensions` field means that nothing under `files/**` will
|
|
# match.
|
|
|
|
finder = FileFinder(lintargs["root"])
|
|
files = [mozpath.join(lintargs["root"], p) for p, _ in finder.find("files/**")]
|
|
|
|
issues = []
|
|
issues.append(
|
|
result.from_config(
|
|
config, path=files[0], lineno=1, column=1, rule="not-skipped"
|
|
)
|
|
)
|