Files
Teodor Tanasoaia 81ee9d2ca8 Bug 2066780 - Update wgpu to revision 9b095f553c0701329b92a347f5ab02ec02e133fc. r=webgpu-reviewers,supply-chain-reviewers,nical
Upstream has split the id/registry ("remoting") machinery out of
wgpu-core into two new crates, `wgpu-core-remote` and
`wgpu-core-remote-types`. wgpu-core is now a direct `Arc`-based API, and
only browser-style consumers that have to mediate between an untrusted
content process and the GPU process layer the remoting crates on top.
Most of this patch is adapting Gecko to that split.

The split buys several things:
 - wgpu-core gets simpler for everyone else. wgpu itself and Deno hold
   `Arc`s directly and no longer pay for id indirection they never
   needed.
 - The remoting layer doesn't need to be multi-threaded, so the hub
   sheds the locking wgpu-core's registry needed and is now a plain
   `RefCell<Hub>`.
 - Security hardening. The IPC types Gecko deserialized in the GPU
   process used to be wgpu-core's own public types, so the untrusted
   content process could name native, non-standard wgpu features
   (raytracing, native-only feature bits, arbitrary descriptor fields)
   that WebGPU never exposes. `wgpu-core-remote-types` defines the wire
   types entirely separately, restricted to what standard WebGPU can
   express, so serde deserialization rejects those values outright
   instead of relying on Gecko to never construct them.
 - Firefox and Servo share one implementation of the per-command
   handling instead of each maintaining its own on top of wgpu-core.
 - Owning the hub outside wgpu-core opens the door to a real
   `device_destroy`: remove every child of the device from the hub and
   leave a "lost" sentinel behind, so memory is reclaimed as soon as any
   `Arc`s still held elsewhere are dropped when outstanding submissions
   finish.

gfx/wgpu_bindings:
 - Depend on the two new crates and run cbindgen over those instead of
   `wgpu-core`/`wgpu-hal`, since the FFI-visible types are now the
   purpose-built remoting types rather than wgpu-core internals.
 - The command enums, serializable descriptors and `IdentityHub` were a
   Gecko-local version of what `wgpu_core_remote_types` now provides,
   and the per-command server dispatch is now
   `Global::handle_*_command`. Both are deleted here, along with
   `src/client/render_pass.rs`. Only the `ExternalTextureSource` id
   space, which has no upstream equivalent, stays local.
 - `device_id` is dropped from the encoder, pass and queue-write entry
   points: the remote `Global` resolves an encoder's owning device
   itself, so content no longer needs to be trusted to supply it.
 - Resource teardown moves from `*_drop` to `*_remove` and backend
   handles come from `resolve_*_id().as_hal::<B>()`, matching the new
   hub ownership model.
 - wgpu-core now implements spec-conformant error scopes on `Device`, so
   the parallel Gecko implementation and the `ErrorBuffer` out-parameter
   protocol built around it are replaced by a serializable `GPUError`
   and `Global::device_{push,pop}_error_scope`. Parent-internal
   operations that still need a success/failure answer wrap themselves
   in a single validation error scope and return `bool`; hence the new
   `wgpu_server_submit_copy_texture_to_buffer`, which fuses
   create-encoder/copy/finish/submit/drop into one call and one error
   scope.
 - Uncaptured errors and device loss are raised by wgpu-core callbacks
   now rather than synthesised in C++, so they are reported from Rust
   over the existing `ServerMessage` stream. `WebGPUParentWeakPtr` wraps
   a C++ `WeakPtr<WebGPUParent>` so those async tasks cannot use a
   destroyed parent.

dom/webgpu:
 - The dedicated `PWebGPU::UncapturedError` and `PWebGPU::DeviceLost`
   messages are gone now that both travel in the `ServerMessage` stream;
   the child re-enters via
   `wgpu_child_handle_uncaptured_error`/`_device_lost`. With their last
   consumers gone, `WebGPUSerialize.h` and `PWebGPUTypes.ipdlh` are
   deleted, and `WebGPUParent` sheds the error-scope and device-lost
   machinery that duplicated state that's aleardy in wgpu-core.
 - Zero-sized buffer mappings are allowed, which makes mapped state
   awkward to infer from the mapped range, so `BufferMapData` tracks it
   directly in `mIsMapped`.
 - `SwapChainPresent` now returns the staging buffer id to the available
   pool via a scope guard on every error path, matching what the other
   readback path already did.
 - External texture import no longer raises `GPUInternalError` for
   failures such as a missing VideoBridge, an unsupported surface format
   or a failed fence wait. Per spec `GPUInternalError` is only ever
   generated by pipeline creation, so these were incorrect; they now log
   via `gfxCriticalError`/`NoteOnce`. The usability check in
   `ImportExternalTexture` still raises a validation error, as the spec
   requires.
 - Mechanical fallout from the type move: descriptors picked up an `Ffi`
   prefix, `device_id` is gone from the client-side encoder calls, and
   cbindgen no longer emits `_Sentinel` enum variants so the matching
   switch cases and assertions are dropped.

Differential Revision: https://phabricator.services.mozilla.com/D322889
2026-09-04 17:30:10 +00:00

1065 lines
37 KiB
C++

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "Device.h"
#include "Adapter.h"
#include "BindGroup.h"
#include "Buffer.h"
#include "CommandEncoder.h"
#include "CompilationInfo.h"
#include "ComputePipeline.h"
#include "DeviceLostInfo.h"
#include "ExternalTexture.h"
#include "InternalError.h"
#include "OutOfMemoryError.h"
#include "PipelineLayout.h"
#include "PromiseHelpers.h"
#include "QuerySet.h"
#include "Queue.h"
#include "RenderBundleEncoder.h"
#include "RenderPipeline.h"
#include "Sampler.h"
#include "SupportedFeatures.h"
#include "SupportedLimits.h"
#include "Texture.h"
#include "TextureView.h"
#include "Utility.h"
#include "ValidationError.h"
#include "ipc/WebGPUChild.h"
#include "js/Value.h"
#include "mozilla/Attributes.h"
#include "mozilla/ErrorResult.h"
#include "mozilla/Logging.h"
#include "mozilla/RefPtr.h"
#include "mozilla/dom/Console.h"
#include "mozilla/dom/Promise.h"
#include "mozilla/dom/VideoFrame.h"
#include "mozilla/dom/WebGPUBinding.h"
#include "mozilla/gfx/gfxVars.h"
#include "mozilla/webgpu/ffi/wgpu.h"
#include "nsGlobalWindowInner.h"
namespace mozilla::webgpu {
mozilla::LazyLogModule gWebGPULog("WebGPU");
NS_IMPL_CYCLE_COLLECTION_WEAK_PTR_INHERITED(Device, DOMEventTargetHelper,
mQueue, mFeatures, mLimits,
mAdapterInfo, mLostPromise);
NS_IMPL_ISUPPORTS_CYCLE_COLLECTION_INHERITED_0(Device, DOMEventTargetHelper)
GPU_IMPL_JS_WRAP(Device)
/* static */ CheckedInt<uint32_t> Device::BufferStrideWithMask(
const gfx::IntSize& aSize, const gfx::SurfaceFormat& aFormat) {
constexpr uint32_t kBufferAlignmentMask = 0xff;
return CheckedInt<uint32_t>(aSize.width) * gfx::BytesPerPixel(aFormat) +
kBufferAlignmentMask;
}
Device::Device(Adapter* const aParent, RawId aDeviceId, RawId aQueueId,
RefPtr<SupportedFeatures> aFeatures,
RefPtr<SupportedLimits> aLimits,
RefPtr<webgpu::AdapterInfo> aAdapterInfo,
RefPtr<dom::Promise> aLostPromise)
: DOMEventTargetHelper(aParent->GetParentObject()),
ObjectBase(aParent->GetChild(), aDeviceId, ffi::wgpu_client_drop_device),
mFeatures(std::move(aFeatures)),
mLimits(std::move(aLimits)),
mAdapterInfo(std::move(aAdapterInfo)),
mSupportSharedTextureInSwapChain(
aParent->SupportSharedTextureInSwapChain()),
mLost(false),
mLostPromise(std::move(aLostPromise)),
mQueue(new class Queue(this, aQueueId)) {
GetChild()->RegisterDevice(this);
KeepAliveIfHasListenersFor(nsGkAtoms::onuncapturederror);
}
Device::~Device() { GetChild()->UnregisterDevice(GetId()); }
void Device::TrackBuffer(Buffer* aBuffer) { mTrackedBuffers.Insert(aBuffer); }
void Device::UntrackBuffer(Buffer* aBuffer) { mTrackedBuffers.Remove(aBuffer); }
dom::Promise* Device::GetLost(ErrorResult& aRv) {
aRv = NS_OK;
return mLostPromise;
}
void Device::ResolveLost(dom::GPUDeviceLostReason aReason,
const nsAString& aMessage) {
if (mLost) {
return;
}
mLost = true;
RefPtr<DeviceLostInfo> info =
MakeRefPtr<DeviceLostInfo>(GetParentObject(), aReason, aMessage);
promise::MaybeResolve(RefPtr(mLostPromise), std::move(info));
}
already_AddRefed<Buffer> Device::CreateBuffer(
const dom::GPUBufferDescriptor& aDesc, ErrorResult& aRv) {
return Buffer::Create(this, GetId(), aDesc, aRv);
}
/* static */ dom::GPUTextureDescriptor Device::SwapChainTextureDescriptor(
const dom::GPUCanvasConfiguration& aConfig,
const gfx::IntSize& aCanvasSize) {
dom::GPUTextureDescriptor desc;
desc.mDimension = dom::GPUTextureDimension::_2d;
auto& sizeDict = desc.mSize.SetAsGPUExtent3DDict();
sizeDict.mWidth = aCanvasSize.width;
sizeDict.mHeight = aCanvasSize.height;
sizeDict.mDepthOrArrayLayers = 1;
desc.mFormat = aConfig.mFormat;
desc.mMipLevelCount = 1;
desc.mSampleCount = 1;
desc.mUsage = aConfig.mUsage | dom::GPUTextureUsage_Binding::COPY_SRC;
desc.mViewFormats = aConfig.mViewFormats;
return desc;
}
already_AddRefed<Texture> Device::CreateTextureForSwapChain(
const dom::GPUCanvasConfiguration* const aConfig,
const gfx::IntSize& aCanvasSize, layers::RemoteTextureOwnerId aOwnerId) {
MOZ_ASSERT(aConfig);
return CreateTexture(SwapChainTextureDescriptor(*aConfig, aCanvasSize),
Some(aOwnerId));
}
already_AddRefed<Texture> Device::CreateTexture(
const dom::GPUTextureDescriptor& aDesc) {
return CreateTexture(aDesc, /* aOwnerId */ Nothing());
}
already_AddRefed<Texture> Device::CreateTexture(
const dom::GPUTextureDescriptor& aDesc,
Maybe<layers::RemoteTextureOwnerId> aOwnerId) {
ConvertTextureDescriptor desc(aDesc);
Maybe<ffi::WGPUSwapChainId> ownerId;
if (aOwnerId.isSome()) {
ownerId = Some(ffi::WGPUSwapChainId{aOwnerId->mId});
}
RawId id = ffi::wgpu_client_create_texture(GetClient(), GetId(), desc.Get(),
ownerId.ptrOr(nullptr));
RefPtr<Texture> texture = new Texture(this, id, aDesc);
texture->SetLabel(aDesc.mLabel);
return texture.forget();
}
already_AddRefed<ExternalTexture> Device::ImportExternalTexture(
const dom::GPUExternalTextureDescriptor& aDesc, ErrorResult& aRv) {
if (!gfx::gfxVars::AllowWebGPUExternalTexture()) {
aRv.ThrowNotSupportedError("WebGPU external textures are disabled");
return nullptr;
}
RefPtr<ExternalTexture> externalTexture =
mExternalTextureCache.GetOrCreate(this, aDesc, aRv);
switch (aDesc.mSource.GetType()) {
case dom::OwningHTMLVideoElementOrVideoFrame::Type::eHTMLVideoElement: {
// Add the texture to the list of textures to be expired in the next
// automatic expiry task, scheduling the task if required.
// Using RunInStableState ensures it runs after any microtasks that may
// be scheduled during the current task.
if (mExternalTexturesToExpire.IsEmpty()) {
nsContentUtils::RunInStableState(
NewRunnableMethod("webgpu::Device::ExpireExternalTextures", this,
&Device::ExpireExternalTextures));
}
mExternalTexturesToExpire.AppendElement(externalTexture);
} break;
case dom::OwningHTMLVideoElementOrVideoFrame::Type::eVideoFrame: {
// Ensure the VideoFrame knows about the external texture, so that it can
// expire it when the VideoFrame is closed.
const auto& videoFrame = aDesc.mSource.GetAsVideoFrame();
videoFrame->TrackWebGPUExternalTexture(externalTexture.get());
} break;
}
return externalTexture.forget();
}
void Device::ExpireExternalTextures() {
MOZ_ASSERT(!mExternalTexturesToExpire.IsEmpty(),
"Task should not have been scheduled if there are no external "
"textures to expire");
for (const auto& weakExternalTexture : mExternalTexturesToExpire) {
if (auto* externalTexture = weakExternalTexture.get()) {
externalTexture->Expire();
}
}
mExternalTexturesToExpire.Clear();
}
already_AddRefed<Sampler> Device::CreateSampler(
const dom::GPUSamplerDescriptor& aDesc) {
ffi::WGPUFfiSamplerDescriptor desc = {};
webgpu::StringHelper label(aDesc.mLabel);
desc.label = label.Get();
desc.address_modes[0] = ffi::WGPUAddressMode(aDesc.mAddressModeU);
desc.address_modes[1] = ffi::WGPUAddressMode(aDesc.mAddressModeV);
desc.address_modes[2] = ffi::WGPUAddressMode(aDesc.mAddressModeW);
desc.mag_filter = ffi::WGPUFilterMode(aDesc.mMagFilter);
desc.min_filter = ffi::WGPUFilterMode(aDesc.mMinFilter);
desc.mipmap_filter = ffi::WGPUMipmapFilterMode(aDesc.mMipmapFilter);
desc.lod_min_clamp = aDesc.mLodMinClamp;
desc.lod_max_clamp = aDesc.mLodMaxClamp;
desc.max_anisotropy = aDesc.mMaxAnisotropy;
ffi::WGPUCompareFunction comparison;
if (aDesc.mCompare.WasPassed()) {
comparison = ConvertCompareFunction(aDesc.mCompare.Value());
desc.compare = &comparison;
}
RawId id = ffi::wgpu_client_create_sampler(GetClient(), GetId(), &desc);
RefPtr<Sampler> sampler = new Sampler(this, id);
sampler->SetLabel(aDesc.mLabel);
return sampler.forget();
}
already_AddRefed<CommandEncoder> Device::CreateCommandEncoder(
const dom::GPUCommandEncoderDescriptor& aDesc) {
ffi::WGPUFfiCommandEncoderDescriptor desc = {};
webgpu::StringHelper label(aDesc.mLabel);
desc.label = label.Get();
RawId id =
ffi::wgpu_client_create_command_encoder(GetClient(), GetId(), &desc);
RefPtr<CommandEncoder> encoder = new CommandEncoder(this, id);
encoder->SetLabel(aDesc.mLabel);
return encoder.forget();
}
already_AddRefed<RenderBundleEncoder> Device::CreateRenderBundleEncoder(
const dom::GPURenderBundleEncoderDescriptor& aDesc) {
ffi::WGPUFfiRenderBundleEncoderDescriptor desc = {};
desc.sample_count = aDesc.mSampleCount;
webgpu::StringHelper label(aDesc.mLabel);
desc.label = label.Get();
ffi::WGPUTextureFormat depthStencilFormat;
if (aDesc.mDepthStencilFormat.WasPassed()) {
depthStencilFormat =
ConvertTextureFormat(aDesc.mDepthStencilFormat.Value());
desc.depth_stencil_format = &depthStencilFormat;
}
std::vector<ffi::WGPUFfiOption_TextureFormat> colorFormats = {};
for (const auto i : IntegerRange(aDesc.mColorFormats.Length())) {
ffi::WGPUFfiOption_TextureFormat opt = {};
if (aDesc.mColorFormats[i].IsNull()) {
opt.tag = ffi::WGPUFfiOption_TextureFormat_None_TextureFormat;
} else {
opt.tag = ffi::WGPUFfiOption_TextureFormat_Some_TextureFormat;
opt.some = ConvertTextureFormat(aDesc.mColorFormats[i].Value());
}
colorFormats.push_back(opt);
}
desc.color_formats = {colorFormats.data(), colorFormats.size()};
RawId id = ffi::wgpu_client_create_render_bundle_encoder(GetClient(), GetId(),
&desc);
RefPtr<RenderBundleEncoder> encoder = new RenderBundleEncoder(this, id);
encoder->SetLabel(aDesc.mLabel);
return encoder.forget();
}
already_AddRefed<QuerySet> Device::CreateQuerySet(
const dom::GPUQuerySetDescriptor& aDesc, ErrorResult& aRv) {
ffi::WGPURawQuerySetDescriptor desc = {};
webgpu::StringHelper label(aDesc.mLabel);
desc.label = label.Get();
ffi::WGPURawQueryType type;
switch (aDesc.mType) {
case dom::GPUQueryType::Occlusion:
type = ffi::WGPURawQueryType_Occlusion;
break;
case dom::GPUQueryType::Timestamp:
type = ffi::WGPURawQueryType_Timestamp;
if (!mFeatures->Features().count(dom::GPUFeatureName::Timestamp_query)) {
aRv.ThrowTypeError(
"requested query set of type `timestamp`, but the "
"`timestamp-query` feature is not enabled on the device");
return nullptr;
}
break;
};
desc.ty = type;
desc.count = aDesc.mCount;
RawId id = ffi::wgpu_client_create_query_set(GetClient(), GetId(), &desc);
RefPtr<QuerySet> querySet = new QuerySet(this, aDesc, id);
querySet->SetLabel(aDesc.mLabel);
return querySet.forget();
}
already_AddRefed<BindGroupLayout> Device::CreateBindGroupLayout(
const dom::GPUBindGroupLayoutDescriptor& aDesc) {
struct OptionalData {
ffi::WGPUTextureViewDimension dim;
ffi::WGPURawTextureSampleType type;
ffi::WGPUTextureFormat format;
};
nsTArray<OptionalData> optional(aDesc.mEntries.Length());
for (const auto& entry : aDesc.mEntries) {
OptionalData data = {};
if (entry.mTexture.WasPassed()) {
const auto& texture = entry.mTexture.Value();
data.dim = ffi::WGPUTextureViewDimension(texture.mViewDimension);
switch (texture.mSampleType) {
case dom::GPUTextureSampleType::Float:
data.type = ffi::WGPURawTextureSampleType_Float;
break;
case dom::GPUTextureSampleType::Unfilterable_float:
data.type = ffi::WGPURawTextureSampleType_UnfilterableFloat;
break;
case dom::GPUTextureSampleType::Uint:
data.type = ffi::WGPURawTextureSampleType_Uint;
break;
case dom::GPUTextureSampleType::Sint:
data.type = ffi::WGPURawTextureSampleType_Sint;
break;
case dom::GPUTextureSampleType::Depth:
data.type = ffi::WGPURawTextureSampleType_Depth;
break;
}
}
if (entry.mStorageTexture.WasPassed()) {
const auto& texture = entry.mStorageTexture.Value();
data.dim = ffi::WGPUTextureViewDimension(texture.mViewDimension);
data.format = ConvertTextureFormat(texture.mFormat);
}
optional.AppendElement(data);
}
nsTArray<ffi::WGPUFfiBindGroupLayoutEntry> entries(aDesc.mEntries.Length());
for (size_t i = 0; i < aDesc.mEntries.Length(); ++i) {
const auto& entry = aDesc.mEntries[i];
ffi::WGPUFfiBindGroupLayoutEntry e = {};
e.binding = entry.mBinding;
e.visibility = entry.mVisibility;
size_t numTypesSpecified = 0;
auto markTypeFound = [&numTypesSpecified]() { numTypesSpecified += 1; };
if (entry.mBuffer.WasPassed()) {
markTypeFound();
switch (entry.mBuffer.Value().mType) {
case dom::GPUBufferBindingType::Uniform:
e.ty = ffi::WGPURawBindingType_UniformBuffer;
break;
case dom::GPUBufferBindingType::Storage:
e.ty = ffi::WGPURawBindingType_StorageBuffer;
break;
case dom::GPUBufferBindingType::Read_only_storage:
e.ty = ffi::WGPURawBindingType_ReadonlyStorageBuffer;
break;
}
e.has_dynamic_offset = entry.mBuffer.Value().mHasDynamicOffset;
e.min_binding_size = entry.mBuffer.Value().mMinBindingSize;
}
if (entry.mTexture.WasPassed()) {
markTypeFound();
e.ty = ffi::WGPURawBindingType_SampledTexture;
e.view_dimension = &optional[i].dim;
e.texture_sample_type = &optional[i].type;
e.multisampled = entry.mTexture.Value().mMultisampled;
}
if (entry.mStorageTexture.WasPassed()) {
markTypeFound();
switch (entry.mStorageTexture.Value().mAccess) {
case dom::GPUStorageTextureAccess::Write_only: {
e.ty = ffi::WGPURawBindingType_WriteonlyStorageTexture;
break;
}
case dom::GPUStorageTextureAccess::Read_only: {
e.ty = ffi::WGPURawBindingType_ReadonlyStorageTexture;
break;
}
case dom::GPUStorageTextureAccess::Read_write: {
e.ty = ffi::WGPURawBindingType_ReadWriteStorageTexture;
break;
}
default: {
MOZ_ASSERT_UNREACHABLE();
}
}
e.view_dimension = &optional[i].dim;
e.storage_texture_format = &optional[i].format;
}
if (entry.mSampler.WasPassed()) {
markTypeFound();
e.ty = ffi::WGPURawBindingType_Sampler;
switch (entry.mSampler.Value().mType) {
case dom::GPUSamplerBindingType::Filtering:
e.sampler_filter = true;
break;
case dom::GPUSamplerBindingType::Non_filtering:
break;
case dom::GPUSamplerBindingType::Comparison:
e.sampler_compare = true;
break;
}
}
if (entry.mExternalTexture.WasPassed()) {
markTypeFound();
e.ty = ffi::WGPURawBindingType_ExternalTexture;
}
switch (numTypesSpecified) {
case 1:
// This is what we want. 👍
break;
case 0:
e.ty = ffi::WGPURawBindingType_Error;
e.error_case = ffi::WGPUBindingTypeError_NoneSpecified;
break;
default:
e.ty = ffi::WGPURawBindingType_Error;
e.error_case = ffi::WGPUBindingTypeError_MultipleSpecified;
break;
}
entries.AppendElement(e);
}
ffi::WGPUFfiBindGroupLayoutDescriptor desc = {};
webgpu::StringHelper label(aDesc.mLabel);
desc.label = label.Get();
desc.entries = {entries.Elements(), entries.Length()};
RawId id =
ffi::wgpu_client_create_bind_group_layout(GetClient(), GetId(), &desc);
RefPtr<BindGroupLayout> object = new BindGroupLayout(this, id);
object->SetLabel(aDesc.mLabel);
return object.forget();
}
already_AddRefed<PipelineLayout> Device::CreatePipelineLayout(
const dom::GPUPipelineLayoutDescriptor& aDesc) {
nsTArray<ffi::WGPUBindGroupLayoutId> bindGroupLayouts(
aDesc.mBindGroupLayouts.Length());
for (const auto& layout : aDesc.mBindGroupLayouts) {
bindGroupLayouts.AppendElement(layout ? layout->GetId() : 0);
}
ffi::WGPUFfiPipelineLayoutDescriptor desc = {};
webgpu::StringHelper label(aDesc.mLabel);
desc.label = label.Get();
desc.bind_group_layouts = {bindGroupLayouts.Elements(),
bindGroupLayouts.Length()};
RawId id =
ffi::wgpu_client_create_pipeline_layout(GetClient(), GetId(), &desc);
RefPtr<PipelineLayout> object = new PipelineLayout(this, id);
object->SetLabel(aDesc.mLabel);
return object.forget();
}
already_AddRefed<BindGroup> Device::CreateBindGroup(
const dom::GPUBindGroupDescriptor& aDesc) {
nsTArray<ffi::WGPUFfiBindGroupEntry> entries(aDesc.mEntries.Length());
CanvasContextArray canvasContexts;
nsTArray<RefPtr<ExternalTexture>> externalTextures;
for (const auto& entry : aDesc.mEntries) {
ffi::WGPUFfiBindGroupEntry e = {};
e.binding = entry.mBinding;
auto setTextureViewBinding =
[&e, &canvasContexts](const TextureView& texture_view) {
e.texture_view = texture_view.GetId();
auto context = texture_view.GetTargetContext();
if (context) {
canvasContexts.AppendElement(context);
}
};
if (entry.mResource.IsGPUBuffer()) {
const auto& buffer = entry.mResource.GetAsGPUBuffer();
if (!buffer->GetId()) {
NS_WARNING("Buffer has no id -- ignoring.");
continue;
}
e.buffer = buffer->GetId();
e.offset = 0;
e.size_passed = false;
e.size = 0;
} else if (entry.mResource.IsGPUBufferBinding()) {
const auto& bufBinding = entry.mResource.GetAsGPUBufferBinding();
if (!bufBinding.mBuffer->GetId()) {
NS_WARNING("Buffer binding has no id -- ignoring.");
continue;
}
e.buffer = bufBinding.mBuffer->GetId();
e.offset = bufBinding.mOffset;
e.size_passed = bufBinding.mSize.WasPassed();
if (e.size_passed) {
e.size = bufBinding.mSize.Value();
} else {
e.size = 0;
}
} else if (entry.mResource.IsGPUTexture()) {
auto texture = entry.mResource.GetAsGPUTexture();
const dom::GPUTextureViewDescriptor defaultDesc{};
RefPtr<TextureView> texture_view = texture->CreateView(defaultDesc);
setTextureViewBinding(*texture_view);
} else if (entry.mResource.IsGPUTextureView()) {
auto texture_view = entry.mResource.GetAsGPUTextureView();
setTextureViewBinding(texture_view);
} else if (entry.mResource.IsGPUSampler()) {
e.sampler = entry.mResource.GetAsGPUSampler()->GetId();
} else if (entry.mResource.IsGPUExternalTexture()) {
const RefPtr<ExternalTexture> externalTexture =
entry.mResource.GetAsGPUExternalTexture();
e.external_texture = externalTexture->GetId();
externalTextures.AppendElement(externalTexture);
} else {
// Not a buffer, nor a texture view, nor a sampler, nor an external
// texture. If we pass this to wgpu_client, it'll panic. Log a warning
// instead and ignore this entry.
NS_WARNING("Bind group entry has unknown type.");
continue;
}
entries.AppendElement(e);
}
ffi::WGPUFfiBindGroupDescriptor desc = {};
webgpu::StringHelper label(aDesc.mLabel);
desc.label = label.Get();
desc.layout = aDesc.mLayout->GetId();
desc.entries = {entries.Elements(), entries.Length()};
RawId id = ffi::wgpu_client_create_bind_group(GetClient(), GetId(), &desc);
RefPtr<BindGroup> object = new BindGroup(this, id, std::move(canvasContexts),
std::move(externalTextures));
object->SetLabel(aDesc.mLabel);
return object.forget();
}
void reportCompilationMessagesToConsole(
const RefPtr<ShaderModule>& aShaderModule,
const nsTArray<WebGPUCompilationMessage>& aMessages) {
auto* global = aShaderModule->GetParentObject();
dom::AutoJSAPI api;
if (!api.Init(global)) {
return;
}
const auto& cx = api.cx();
dom::GlobalObject globalObj(cx, global->GetGlobalJSObject());
dom::Sequence<JS::Value> args;
dom::SequenceRooter<JS::Value> msgArgsRooter(cx, &args);
auto SetSingleStrAsArgs =
[&](const nsString& message, dom::Sequence<JS::Value>* args)
MOZ_CAN_RUN_SCRIPT {
args->Clear();
JS::Rooted<JSString*> jsStr(
cx, JS_NewUCStringCopyN(cx, message.Data(), message.Length()));
if (!jsStr) {
return;
}
JS::Rooted<JS::Value> val(cx, JS::StringValue(jsStr));
if (!args->AppendElement(val, fallible)) {
return;
}
};
nsString label;
aShaderModule->GetLabel(label);
auto appendNiceLabelIfPresent = [&label](nsString* buf) MOZ_CAN_RUN_SCRIPT {
if (!label.IsEmpty()) {
buf->AppendLiteral(u" \"");
buf->Append(label);
buf->AppendLiteral(u"\"");
}
};
// We haven't actually inspected a message for severity, but
// it doesn't actually matter, since we don't do anything at
// this level.
auto highestSeveritySeen = WebGPUCompilationMessageType::Info;
uint64_t errorCount = 0;
uint64_t warningCount = 0;
uint64_t infoCount = 0;
for (const auto& message : aMessages) {
bool higherThanSeen =
static_cast<std::underlying_type_t<WebGPUCompilationMessageType>>(
message.messageType) <
static_cast<std::underlying_type_t<WebGPUCompilationMessageType>>(
highestSeveritySeen);
if (higherThanSeen) {
highestSeveritySeen = message.messageType;
}
switch (message.messageType) {
case WebGPUCompilationMessageType::Error:
errorCount += 1;
break;
case WebGPUCompilationMessageType::Warning:
warningCount += 1;
break;
case WebGPUCompilationMessageType::Info:
infoCount += 1;
break;
}
}
switch (highestSeveritySeen) {
case WebGPUCompilationMessageType::Info:
// shouldn't happen, but :shrug:
break;
case WebGPUCompilationMessageType::Warning: {
nsString msg(
u"Encountered one or more warnings while creating shader module");
appendNiceLabelIfPresent(&msg);
SetSingleStrAsArgs(msg, &args);
dom::Console::Warn(globalObj, args);
break;
}
case WebGPUCompilationMessageType::Error: {
nsString msg(
u"Encountered one or more errors while creating shader module");
appendNiceLabelIfPresent(&msg);
SetSingleStrAsArgs(msg, &args);
dom::Console::Error(globalObj, args);
break;
}
}
nsString header;
header.AppendLiteral(u"WebGPU compilation info for shader module");
appendNiceLabelIfPresent(&header);
header.AppendLiteral(u" (");
header.AppendInt(errorCount);
header.AppendLiteral(u" error(s), ");
header.AppendInt(warningCount);
header.AppendLiteral(u" warning(s), ");
header.AppendInt(infoCount);
header.AppendLiteral(u" info)");
SetSingleStrAsArgs(header, &args);
dom::Console::GroupCollapsed(globalObj, args);
for (const auto& message : aMessages) {
SetSingleStrAsArgs(message.message, &args);
switch (message.messageType) {
case WebGPUCompilationMessageType::Error:
dom::Console::Error(globalObj, args);
break;
case WebGPUCompilationMessageType::Warning:
dom::Console::Warn(globalObj, args);
break;
case WebGPUCompilationMessageType::Info:
dom::Console::Info(globalObj, args);
break;
}
}
dom::Console::GroupEnd(globalObj);
}
already_AddRefed<ShaderModule> Device::CreateShaderModule(
const dom::GPUShaderModuleDescriptor& aDesc, ErrorResult& aRv) {
RefPtr<dom::Promise> promise = dom::Promise::Create(GetParentObject(), aRv);
if (NS_WARN_IF(aRv.Failed())) {
return nullptr;
}
webgpu::StringHelper label(aDesc.mLabel);
RawId moduleId = ffi::wgpu_client_create_shader_module(
GetClient(), GetId(), label.Get(), &aDesc.mCode);
RefPtr<ShaderModule> shaderModule = new ShaderModule(this, moduleId, promise);
shaderModule->SetLabel(aDesc.mLabel);
GetChild()->EnqueueCreateShaderModulePromise(
PendingCreateShaderModulePromise{std::move(promise), this, shaderModule});
return shaderModule.forget();
}
RawId CreateComputePipelineImpl(RawId deviceId, WebGPUChild* aChild,
const dom::GPUComputePipelineDescriptor& aDesc,
bool isAsync) {
ffi::WGPUFfiComputePipelineDescriptor desc = {};
nsCString entryPoint;
nsTArray<nsCString> constantKeys;
nsTArray<ffi::WGPUConstantEntry> constants;
webgpu::StringHelper label(aDesc.mLabel);
desc.label = label.Get();
if (aDesc.mLayout.IsGPUAutoLayoutMode()) {
desc.layout = 0;
} else if (aDesc.mLayout.IsGPUPipelineLayout()) {
desc.layout = aDesc.mLayout.GetAsGPUPipelineLayout()->GetId();
} else {
MOZ_ASSERT_UNREACHABLE();
}
desc.stage.module = aDesc.mCompute.mModule->GetId();
if (aDesc.mCompute.mEntryPoint.WasPassed()) {
CopyUTF16toUTF8(aDesc.mCompute.mEntryPoint.Value(), entryPoint);
desc.stage.entry_point = entryPoint.get();
} else {
desc.stage.entry_point = nullptr;
}
if (aDesc.mCompute.mConstants.WasPassed()) {
const auto& descConstants = aDesc.mCompute.mConstants.Value().Entries();
constantKeys.SetCapacity(descConstants.Length());
constants.SetCapacity(descConstants.Length());
for (const auto& entry : descConstants) {
ffi::WGPUConstantEntry constantEntry = {};
nsCString key = NS_ConvertUTF16toUTF8(entry.mKey);
constantKeys.AppendElement(key);
constantEntry.key = key.get();
constantEntry.value = entry.mValue;
constants.AppendElement(constantEntry);
}
desc.stage.constants = {constants.Elements(), constants.Length()};
}
RawId id = ffi::wgpu_client_create_compute_pipeline(aChild->GetClient(),
deviceId, &desc, isAsync);
return id;
}
RawId CreateRenderPipelineImpl(RawId deviceId, WebGPUChild* aChild,
const dom::GPURenderPipelineDescriptor& aDesc,
bool isAsync) {
// A bunch of stack locals that we can have pointers into
nsTArray<ffi::WGPUFfiOption_FfiVertexBufferLayout> vertexBuffers;
nsTArray<ffi::WGPUVertexAttribute> vertexAttributes;
ffi::WGPUFfiRenderPipelineDescriptor desc = {};
nsCString vsEntry, fsEntry;
nsTArray<nsCString> vsConstantKeys, fsConstantKeys;
nsTArray<ffi::WGPUConstantEntry> vsConstants, fsConstants;
ffi::WGPUIndexFormat stripIndexFormat = ffi::WGPUIndexFormat_Uint16;
ffi::WGPUFace cullFace = ffi::WGPUFace_Front;
ffi::WGPUFfiVertexState vertexState = {};
ffi::WGPUFfiFragmentState fragmentState = {};
nsTArray<ffi::WGPUFfiOption_ColorTargetState> colorStates;
webgpu::StringHelper label(aDesc.mLabel);
desc.label = label.Get();
if (aDesc.mLayout.IsGPUAutoLayoutMode()) {
desc.layout = 0;
} else if (aDesc.mLayout.IsGPUPipelineLayout()) {
desc.layout = aDesc.mLayout.GetAsGPUPipelineLayout()->GetId();
} else {
MOZ_ASSERT_UNREACHABLE();
}
{
const auto& stage = aDesc.mVertex;
vertexState.stage.module = stage.mModule->GetId();
if (stage.mEntryPoint.WasPassed()) {
CopyUTF16toUTF8(stage.mEntryPoint.Value(), vsEntry);
vertexState.stage.entry_point = vsEntry.get();
} else {
vertexState.stage.entry_point = nullptr;
}
if (stage.mConstants.WasPassed()) {
const auto& descConstants = stage.mConstants.Value().Entries();
vsConstantKeys.SetCapacity(descConstants.Length());
vsConstants.SetCapacity(descConstants.Length());
for (const auto& entry : descConstants) {
ffi::WGPUConstantEntry constantEntry = {};
nsCString key = NS_ConvertUTF16toUTF8(entry.mKey);
vsConstantKeys.AppendElement(key);
constantEntry.key = key.get();
constantEntry.value = entry.mValue;
vsConstants.AppendElement(constantEntry);
}
vertexState.stage.constants = {vsConstants.Elements(),
vsConstants.Length()};
}
for (const auto& vertex_desc : stage.mBuffers) {
ffi::WGPUFfiOption_FfiVertexBufferLayout opt_vb_desc = {};
if (vertex_desc.IsNull()) {
opt_vb_desc.tag =
ffi::WGPUFfiOption_FfiVertexBufferLayout_None_FfiVertexBufferLayout;
} else {
ffi::WGPUFfiVertexBufferLayout vb_desc = {};
const auto& vd = vertex_desc.Value();
vb_desc.array_stride = vd.mArrayStride;
vb_desc.step_mode = ffi::WGPUVertexStepMode(vd.mStepMode);
// Note: we are setting the length but not the pointer
vb_desc.attributes = {nullptr, vd.mAttributes.Length()};
for (const auto& vat : vd.mAttributes) {
ffi::WGPUVertexAttribute ad = {};
ad.offset = vat.mOffset;
ad.format = ConvertVertexFormat(vat.mFormat);
ad.shader_location = vat.mShaderLocation;
vertexAttributes.AppendElement(ad);
}
opt_vb_desc.tag =
ffi::WGPUFfiOption_FfiVertexBufferLayout_Some_FfiVertexBufferLayout;
opt_vb_desc.some = vb_desc;
}
vertexBuffers.AppendElement(opt_vb_desc);
}
// Now patch up all the pointers to attribute lists.
size_t numAttributes = 0;
for (auto& vb_desc : vertexBuffers) {
if (vb_desc.tag ==
ffi::WGPUFfiOption_FfiVertexBufferLayout_Some_FfiVertexBufferLayout) {
vb_desc.some.attributes.data =
vertexAttributes.Elements() + numAttributes;
numAttributes += vb_desc.some.attributes.length;
}
}
vertexState.buffers = {vertexBuffers.Elements(), vertexBuffers.Length()};
desc.vertex = &vertexState;
}
if (aDesc.mFragment.WasPassed()) {
const auto& stage = aDesc.mFragment.Value();
fragmentState.stage.module = stage.mModule->GetId();
if (stage.mEntryPoint.WasPassed()) {
CopyUTF16toUTF8(stage.mEntryPoint.Value(), fsEntry);
fragmentState.stage.entry_point = fsEntry.get();
} else {
fragmentState.stage.entry_point = nullptr;
}
if (stage.mConstants.WasPassed()) {
const auto& descConstants = stage.mConstants.Value().Entries();
fsConstantKeys.SetCapacity(descConstants.Length());
fsConstants.SetCapacity(descConstants.Length());
for (const auto& entry : descConstants) {
ffi::WGPUConstantEntry constantEntry = {};
nsCString key = NS_ConvertUTF16toUTF8(entry.mKey);
fsConstantKeys.AppendElement(key);
constantEntry.key = key.get();
constantEntry.value = entry.mValue;
fsConstants.AppendElement(constantEntry);
}
fragmentState.stage.constants = {fsConstants.Elements(),
fsConstants.Length()};
}
for (const auto& colorStateOrNull : stage.mTargets) {
ffi::WGPUFfiOption_ColorTargetState opt = {};
if (colorStateOrNull.IsNull()) {
opt.tag = ffi::WGPUFfiOption_ColorTargetState_None_ColorTargetState;
colorStates.AppendElement(opt);
continue;
}
const auto& colorState = colorStateOrNull.Value();
ffi::WGPUColorTargetState desc = {};
desc.format = ConvertTextureFormat(colorState.mFormat);
if (colorState.mBlend.WasPassed()) {
const auto& blend = colorState.mBlend.Value();
desc.blend.tag = ffi::WGPUFfiOption_BlendState_Some_BlendState;
desc.blend.some.alpha = ConvertBlendComponent(blend.mAlpha);
desc.blend.some.color = ConvertBlendComponent(blend.mColor);
} else {
desc.blend.tag = ffi::WGPUFfiOption_BlendState_None_BlendState;
}
desc.write_mask = colorState.mWriteMask;
opt.tag = ffi::WGPUFfiOption_ColorTargetState_Some_ColorTargetState;
opt.some = desc;
colorStates.AppendElement(opt);
}
fragmentState.targets = {colorStates.Elements(), colorStates.Length()};
desc.fragment = &fragmentState;
}
{
const auto& prim = aDesc.mPrimitive;
desc.primitive.topology = ffi::WGPUPrimitiveTopology(prim.mTopology);
if (prim.mStripIndexFormat.WasPassed()) {
stripIndexFormat = ffi::WGPUIndexFormat(prim.mStripIndexFormat.Value());
desc.primitive.strip_index_format = &stripIndexFormat;
}
desc.primitive.front_face = ffi::WGPUFrontFace(prim.mFrontFace);
if (prim.mCullMode != dom::GPUCullMode::None) {
cullFace = prim.mCullMode == dom::GPUCullMode::Front ? ffi::WGPUFace_Front
: ffi::WGPUFace_Back;
desc.primitive.cull_mode = &cullFace;
}
desc.primitive.unclipped_depth = prim.mUnclippedDepth;
}
desc.multisample = ConvertMultisampleState(aDesc.mMultisample);
ffi::WGPUDepthStencilState depthStencilState = {};
if (aDesc.mDepthStencil.WasPassed()) {
depthStencilState = ConvertDepthStencilState(aDesc.mDepthStencil.Value());
desc.depth_stencil = &depthStencilState;
}
RawId id = ffi::wgpu_client_create_render_pipeline(aChild->GetClient(),
deviceId, &desc, isAsync);
return id;
}
already_AddRefed<ComputePipeline> Device::CreateComputePipeline(
const dom::GPUComputePipelineDescriptor& aDesc) {
RawId pipelineId =
CreateComputePipelineImpl(GetId(), GetChild(), aDesc, false);
RefPtr<ComputePipeline> object = new ComputePipeline(this, pipelineId);
object->SetLabel(aDesc.mLabel);
return object.forget();
}
already_AddRefed<RenderPipeline> Device::CreateRenderPipeline(
const dom::GPURenderPipelineDescriptor& aDesc) {
RawId pipelineId =
CreateRenderPipelineImpl(GetId(), GetChild(), aDesc, false);
RefPtr<RenderPipeline> object = new RenderPipeline(this, pipelineId);
object->SetLabel(aDesc.mLabel);
return object.forget();
}
already_AddRefed<dom::Promise> Device::CreateComputePipelineAsync(
const dom::GPUComputePipelineDescriptor& aDesc, ErrorResult& aRv) {
RefPtr<dom::Promise> promise = dom::Promise::Create(GetParentObject(), aRv);
if (NS_WARN_IF(aRv.Failed())) {
return nullptr;
}
RawId pipelineId =
CreateComputePipelineImpl(GetId(), GetChild(), aDesc, true);
GetChild()->EnqueueCreatePipelinePromise(PendingCreatePipelinePromise{
promise, this, false, pipelineId, aDesc.mLabel});
return promise.forget();
}
already_AddRefed<dom::Promise> Device::CreateRenderPipelineAsync(
const dom::GPURenderPipelineDescriptor& aDesc, ErrorResult& aRv) {
RefPtr<dom::Promise> promise = dom::Promise::Create(GetParentObject(), aRv);
if (NS_WARN_IF(aRv.Failed())) {
return nullptr;
}
RawId pipelineId = CreateRenderPipelineImpl(GetId(), GetChild(), aDesc, true);
GetChild()->EnqueueCreatePipelinePromise(PendingCreatePipelinePromise{
promise, this, true, pipelineId, aDesc.mLabel});
return promise.forget();
}
already_AddRefed<Texture> Device::InitSwapChain(
const dom::GPUCanvasConfiguration* const aConfig,
const layers::RemoteTextureOwnerId aOwnerId,
bool aUseSharedTextureInSwapChain, gfx::SurfaceFormat aFormat,
gfx::IntSize aCanvasSize) {
MOZ_ASSERT(aConfig);
// Check that aCanvasSize and aFormat will generate a texture stride
// within limits.
const auto bufferStrideWithMask = BufferStrideWithMask(aCanvasSize, aFormat);
if (!bufferStrideWithMask.isValid()) {
return nullptr;
}
const layers::RGBDescriptor rgbDesc(aCanvasSize, aFormat,
gfx::ColorSpace2::SRGB,
gfx::TransferFunction::SRGB);
auto textureDesc = SwapChainTextureDescriptor(*aConfig, aCanvasSize);
ConvertTextureDescriptor ffiDesc(textureDesc);
ffi::wgpu_client_create_swap_chain(
GetClient(), GetId(), mQueue->GetId(), ffiDesc.Get(),
(int8_t)rgbDesc.format(), aOwnerId.mId, aUseSharedTextureInSwapChain);
// TODO: `mColorSpace`: <https://bugzilla.mozilla.org/show_bug.cgi?id=1846608>
// TODO: `mAlphaMode`: <https://bugzilla.mozilla.org/show_bug.cgi?id=1846605>
return CreateTexture(textureDesc, Some(aOwnerId));
}
bool Device::CheckNewWarning(const nsACString& aMessage) {
return mKnownWarnings.EnsureInserted(aMessage);
}
void Device::Destroy() {
// Unmap all buffers from this device, as specified by
// https://gpuweb.github.io/gpuweb/#dom-gpudevice-destroy.
dom::AutoJSAPI jsapi;
if (jsapi.Init(GetRelevantGlobal())) {
IgnoredErrorResult rv;
for (const auto& buffer : mTrackedBuffers) {
buffer->Unmap(jsapi.cx(), rv);
}
mTrackedBuffers.Clear();
}
ffi::wgpu_client_destroy_device(GetClient(), GetId());
if (!mLost) {
mLost = true;
GetChild()->RegisterDeviceLostPromise(GetId(), mLostPromise);
}
}
void Device::PushErrorScope(const dom::GPUErrorFilter& aFilter) {
ffi::WGPUFfiErrorFilter filter;
switch (aFilter) {
case dom::GPUErrorFilter::Validation:
filter = ffi::WGPUFfiErrorFilter_Validation;
break;
case dom::GPUErrorFilter::Out_of_memory:
filter = ffi::WGPUFfiErrorFilter_OutOfMemory;
break;
case dom::GPUErrorFilter::Internal:
filter = ffi::WGPUFfiErrorFilter_Internal;
break;
}
ffi::wgpu_client_push_error_scope(GetClient(), GetId(), filter);
}
already_AddRefed<dom::Promise> Device::PopErrorScope(ErrorResult& aRv) {
RefPtr<dom::Promise> promise = dom::Promise::Create(GetParentObject(), aRv);
if (NS_WARN_IF(aRv.Failed())) {
return nullptr;
}
ffi::wgpu_client_pop_error_scope(GetClient(), GetId());
GetChild()->EnqueuePopErrorScopePromise(
PendingPopErrorScopePromise{promise, this});
return promise.forget();
}
} // namespace mozilla::webgpu