From a2ae8bedb33cbab69a4dff4afd39c2b2c0009638 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20Qu=C3=A8ze?= Date: Sat, 5 Sep 2026 06:07:44 +0000 Subject: [PATCH] Bug 2069345 - Remove test.wait300msAfterTabSwitch from tests fixed by waiting for the tab to be reflowed. r=firefox-desktop-core-reviewers ,search-reviewers,tabbrowser-reviewers,layout-reviewers,nsharpley,dshin,scunnane,Gijs Depends on D323604 Differential Revision: https://phabricator.services.mozilla.com/D323605 --- .../content/test/contextMenu/browser_contextmenu_inspect.js | 6 ------ .../test/contextMenu/browser_contextmenu_save_blocked.js | 6 ------ .../content/test/contextMenu/browser_copy_canvas_image.js | 6 ------ .../content/test/contextMenu/browser_strip_on_share_link.js | 5 +---- .../test/contextMenu/browser_strip_on_share_nested_link.js | 5 +---- browser/base/content/test/forms/browser_selectpopup.js | 5 +---- .../content/test/forms/browser_selectpopup_color_scheme.js | 5 +---- .../base/content/test/forms/browser_selectpopup_colors.js | 5 +---- .../test/forms/browser_selectpopup_display_inherit.js | 6 ------ .../base/content/test/forms/browser_selectpopup_focus.js | 6 ------ .../content/test/forms/browser_selectpopup_option_in_div.js | 5 +---- .../content/test/forms/browser_selectpopup_searchfocus.js | 5 +---- .../test/forms/browser_selectpopup_text_transform.js | 6 ------ .../content/test/forms/browser_selectpopup_user_input.js | 5 +---- .../base/content/test/forms/browser_selectpopup_width.js | 5 +---- .../base/content/test/forms/browser_selectpopup_xhtml.js | 6 ------ browser/base/content/test/general/browser_bug710878.js | 6 ------ .../base/content/test/general/browser_contentAltClick.js | 6 ------ .../content/test/general/browser_middleMouse_noJSPaste.js | 6 +----- .../base/content/test/general/browser_newwindow_focus.js | 6 ------ .../downloads/test/browser/browser_image_mimetype_issues.js | 6 ------ .../browser/browser_policy_block_set_desktop_background.js | 4 ---- .../extensions/test/browser/browser_ext_user_events.js | 6 ------ .../genai/tests/browser/browser_chat_contextmenu.js | 6 ------ browser/components/genai/tests/browser/browser_chat_page.js | 6 ------ .../places/tests/browser/browser_bookmark_remove_tags.js | 4 ---- .../test/browser/browser_roundedWindow_open_min_inner.js | 6 ------ .../screenshots/tests/browser/browser_keyboard_shortcuts.js | 5 +---- .../screenshots/tests/browser/browser_keyboard_tests.js | 1 - .../components/search/test/browser/browser_contextmenu.js | 4 ---- .../tabs/browser_e10s_about_page_triggeringprincipal.js | 5 +---- ...rowser_link_in_tab_title_and_url_prefilled_new_window.js | 6 ------ .../test/browser/tabs/browser_new_tab_insert_position.js | 6 ------ .../test/browser/tabs/browser_tab_groups_keyboard_focus.js | 5 +---- .../test/browser/tabs/browser_window_open_modifiers.js | 6 ------ .../test/navigation/browser_test-content-chromeflags.js | 5 +---- dom/base/test/browser_form_validity_popup_submit.js | 6 ------ dom/base/test/browser_outline_refocus.js | 6 ------ dom/events/test/browser_mouseout_notification_panel.js | 1 - dom/tests/browser/browser_pointerlock_warning.js | 6 ------ .../tests/browser_onbeforeunload_only_after_interaction.js | 6 ------ .../base/tests/browser_select_popup_from_background_tab.js | 4 ---- .../places/tests/browser/browser_visituri_restriction.js | 1 - .../printing/tests/browser_print_bcg_id_overflow.js | 6 ------ .../thumbnails/test/browser_thumbnails_capture.js | 6 ------ .../thumbnails/test/browser_thumbnails_capture_svg.js | 6 ------ .../components/viewsource/test/browser/browser_srcdoc.js | 6 ------ .../windowwatcher/test/browser_new_remote_window_flags.js | 5 +---- .../browser/browser_default_image_filename_redirect.js | 6 ------ .../modules/tests/browser/browser_toTopLevelWidgetRect.js | 6 +----- .../tests/mochitest/browser_txt_download_save_as.js | 1 - 51 files changed, 16 insertions(+), 248 deletions(-) diff --git a/browser/base/content/test/contextMenu/browser_contextmenu_inspect.js b/browser/base/content/test/contextMenu/browser_contextmenu_inspect.js index dd5050575e93..94241e9e1f70 100644 --- a/browser/base/content/test/contextMenu/browser_contextmenu_inspect.js +++ b/browser/base/content/test/contextMenu/browser_contextmenu_inspect.js @@ -3,12 +3,6 @@ "use strict"; -add_setup(async function () { - await SpecialPowers.pushPrefEnv({ - set: [["test.wait300msAfterTabSwitch", true]], - }); -}); - /** * Check that we show the inspect item(s) as appropriate. */ diff --git a/browser/base/content/test/contextMenu/browser_contextmenu_save_blocked.js b/browser/base/content/test/contextMenu/browser_contextmenu_save_blocked.js index b6a45e8efd43..0ad0e0d4313a 100644 --- a/browser/base/content/test/contextMenu/browser_contextmenu_save_blocked.js +++ b/browser/base/content/test/contextMenu/browser_contextmenu_save_blocked.js @@ -19,12 +19,6 @@ function mockPromptService() { return promptService; } -add_setup(async function () { - await SpecialPowers.pushPrefEnv({ - set: [["test.wait300msAfterTabSwitch", true]], - }); -}); - add_task(async function test_save_link_blocked_by_extension() { let ext = ExtensionTestUtils.loadExtension({ manifest: { diff --git a/browser/base/content/test/contextMenu/browser_copy_canvas_image.js b/browser/base/content/test/contextMenu/browser_copy_canvas_image.js index ba5871fb8af3..b449e696e4a1 100644 --- a/browser/base/content/test/contextMenu/browser_copy_canvas_image.js +++ b/browser/base/content/test/contextMenu/browser_copy_canvas_image.js @@ -4,12 +4,6 @@ "use strict"; -add_setup(async function () { - await SpecialPowers.pushPrefEnv({ - set: [["test.wait300msAfterTabSwitch", true]], - }); -}); - // Adapted from widget/tests/file_test_clipboard_pngPreservesTransparency.js async function getPNGFromClipboard(clipboard) { let trans = Cc["@mozilla.org/widget/transferable;1"].createInstance( diff --git a/browser/base/content/test/contextMenu/browser_strip_on_share_link.js b/browser/base/content/test/contextMenu/browser_strip_on_share_link.js index c56b8bbb379b..f69bae90c12c 100644 --- a/browser/base/content/test/contextMenu/browser_strip_on_share_link.js +++ b/browser/base/content/test/contextMenu/browser_strip_on_share_link.js @@ -10,10 +10,7 @@ let url = add_setup(async function () { await SpecialPowers.pushPrefEnv({ - set: [ - ["test.wait300msAfterTabSwitch", true], - ["privacy.query_stripping.strip_list", "stripParam"], - ], + set: [["privacy.query_stripping.strip_list", "stripParam"]], }); // Get the list service so we can wait for it to be fully initialized before running tests. diff --git a/browser/base/content/test/contextMenu/browser_strip_on_share_nested_link.js b/browser/base/content/test/contextMenu/browser_strip_on_share_nested_link.js index 83758a71d775..230be7e1e8ec 100644 --- a/browser/base/content/test/contextMenu/browser_strip_on_share_nested_link.js +++ b/browser/base/content/test/contextMenu/browser_strip_on_share_nested_link.js @@ -10,10 +10,7 @@ const TEST_URL = add_setup(async function () { await SpecialPowers.pushPrefEnv({ - set: [ - ["test.wait300msAfterTabSwitch", true], - ["privacy.query_stripping.strip_list", "stripParam"], - ], + set: [["privacy.query_stripping.strip_list", "stripParam"]], }); // Get the list service so we can wait for it to be fully initialized before running tests. diff --git a/browser/base/content/test/forms/browser_selectpopup.js b/browser/base/content/test/forms/browser_selectpopup.js index 15510d569daf..6ff868b4eb01 100644 --- a/browser/base/content/test/forms/browser_selectpopup.js +++ b/browser/base/content/test/forms/browser_selectpopup.js @@ -288,10 +288,7 @@ async function doSelectTests(contentType, content) { add_setup(async function () { await SpecialPowers.pushPrefEnv({ - set: [ - ["test.wait300msAfterTabSwitch", true], - ["dom.forms.select.customstyling", true], - ], + set: [["dom.forms.select.customstyling", true]], }); }); diff --git a/browser/base/content/test/forms/browser_selectpopup_color_scheme.js b/browser/base/content/test/forms/browser_selectpopup_color_scheme.js index a09b43b99175..4d6feb9f1e32 100644 --- a/browser/base/content/test/forms/browser_selectpopup_color_scheme.js +++ b/browser/base/content/test/forms/browser_selectpopup_color_scheme.js @@ -15,10 +15,7 @@ const TESTS = [ add_setup(async function () { await SpecialPowers.pushPrefEnv({ - set: [ - ["test.wait300msAfterTabSwitch", true], - ["dom.forms.select.customstyling", true], - ], + set: [["dom.forms.select.customstyling", true]], }); }); diff --git a/browser/base/content/test/forms/browser_selectpopup_colors.js b/browser/base/content/test/forms/browser_selectpopup_colors.js index 074ebeafbe1d..baea65cfffe2 100644 --- a/browser/base/content/test/forms/browser_selectpopup_colors.js +++ b/browser/base/content/test/forms/browser_selectpopup_colors.js @@ -475,10 +475,7 @@ let kDefaultSelectStyles = {}; add_setup(async function () { await SpecialPowers.pushPrefEnv({ - set: [ - ["test.wait300msAfterTabSwitch", true], - ["dom.forms.select.customstyling", true], - ], + set: [["dom.forms.select.customstyling", true]], }); kDefaultSelectStyles = await BrowserTestUtils.withNewTab( `data:text/html, `; -add_setup(async function () { - await SpecialPowers.pushPrefEnv({ - set: [["test.wait300msAfterTabSwitch", true]], - }); -}); - add_task(async function () { const url = "data:text/html," + encodeURI(PAGE); await BrowserTestUtils.withNewTab({ gBrowser, url }, async function () { diff --git a/browser/base/content/test/forms/browser_selectpopup_focus.js b/browser/base/content/test/forms/browser_selectpopup_focus.js index 0a663a3fb755..24ff947c505f 100644 --- a/browser/base/content/test/forms/browser_selectpopup_focus.js +++ b/browser/base/content/test/forms/browser_selectpopup_focus.js @@ -12,12 +12,6 @@ function tick() { ); } -add_setup(async function () { - await SpecialPowers.pushPrefEnv({ - set: [["test.wait300msAfterTabSwitch", true]], - }); -}); - add_task(async function () { const url = "data:text/html," + encodeURI(PAGE); await BrowserTestUtils.withNewTab( diff --git a/browser/base/content/test/forms/browser_selectpopup_option_in_div.js b/browser/base/content/test/forms/browser_selectpopup_option_in_div.js index c6e927baa4c3..bee60a8e11e1 100644 --- a/browser/base/content/test/forms/browser_selectpopup_option_in_div.js +++ b/browser/base/content/test/forms/browser_selectpopup_option_in_div.js @@ -12,10 +12,7 @@ const PAGE_CONTENT = ` // select is enabled, so the dropdown has to list every