diff --git a/dom/ipc/ContentParent.cpp b/dom/ipc/ContentParent.cpp index 3fbaa6041e35..e477daf3cb6d 100644 --- a/dom/ipc/ContentParent.cpp +++ b/dom/ipc/ContentParent.cpp @@ -6889,10 +6889,10 @@ mozilla::ipc::IPCResult ContentParent::RecvAddOrRemovePageAwakeRequest( #if defined(XP_WIN) mozilla::ipc::IPCResult ContentParent::RecvGetModulesTrust( - ModulePaths&& aModPaths, bool aRunAtNormalPriority, + ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority, GetModulesTrustResolver&& aResolver) { RefPtr dllSvc(DllServices::Get()); - dllSvc->GetModulesTrust(std::move(aModPaths), aRunAtNormalPriority) + dllSvc->GetModulesTrust(std::move(aModIdents), aRunAtNormalPriority) ->Then( GetMainThreadSerialEventTarget(), __func__, [aResolver](ModulesMapResult&& aResult) { diff --git a/dom/ipc/ContentParent.h b/dom/ipc/ContentParent.h index 630641d87277..46c69a212703 100644 --- a/dom/ipc/ContentParent.h +++ b/dom/ipc/ContentParent.h @@ -1275,7 +1275,7 @@ class ContentParent final : public PContentParent, #if defined(XP_WIN) mozilla::ipc::IPCResult RecvGetModulesTrust( - ModulePaths&& aModPaths, bool aRunAtNormalPriority, + ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority, GetModulesTrustResolver&& aResolver); #endif // defined(XP_WIN) diff --git a/dom/ipc/PContent.ipdl b/dom/ipc/PContent.ipdl index 00715397e55e..72146a14dd82 100644 --- a/dom/ipc/PContent.ipdl +++ b/dom/ipc/PContent.ipdl @@ -137,7 +137,7 @@ using mozilla::dom::PermissionState from "mozilla/dom/PermissionMessageUtils.h"; #if defined(XP_WIN) [MoveOnly] using mozilla::UntrustedModulesData from "mozilla/UntrustedModulesData.h"; -[MoveOnly] using mozilla::ModulePaths from "mozilla/UntrustedModulesData.h"; +[MoveOnly] using mozilla::ModuleIdentifiers from "mozilla/UntrustedModulesData.h"; [MoveOnly] using mozilla::ModulesMapResult from "mozilla/UntrustedModulesData.h"; #endif // defined(XP_WIN) @@ -1790,7 +1790,7 @@ parent: * trustworthiness. This API asks the chrome process to perform that * evaluation. */ - async GetModulesTrust(ModulePaths aModPaths, bool aRunAtNormalPriority) + async GetModulesTrust(ModuleIdentifiers aModIdents, bool aRunAtNormalPriority) returns (ModulesMapResult? modMapResult); #endif // defined(XP_WIN) diff --git a/dom/media/gmp/GMPParent.cpp b/dom/media/gmp/GMPParent.cpp index 580d9a396101..6d2b89322933 100644 --- a/dom/media/gmp/GMPParent.cpp +++ b/dom/media/gmp/GMPParent.cpp @@ -497,21 +497,22 @@ mozilla::ipc::IPCResult GMPParent::RecvFOGData(ByteBuf&& aBuf) { #if defined(XP_WIN) mozilla::ipc::IPCResult GMPParent::RecvGetModulesTrust( - ModulePaths&& aModPaths, bool aRunAtNormalPriority, + ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority, GetModulesTrustResolver&& aResolver) { class ModulesTrustRunnable final : public Runnable { public: - ModulesTrustRunnable(ModulePaths&& aModPaths, bool aRunAtNormalPriority, + ModulesTrustRunnable(ModuleIdentifiers&& aModIdents, + bool aRunAtNormalPriority, GetModulesTrustResolver&& aResolver) : Runnable("GMPParent::RecvGetModulesTrust::ModulesTrustRunnable"), - mModPaths(std::move(aModPaths)), + mModIdents(std::move(aModIdents)), mResolver(std::move(aResolver)), mEventTarget(GetCurrentSerialEventTarget()), mRunAtNormalPriority(aRunAtNormalPriority) {} NS_IMETHOD Run() override { RefPtr dllSvc(DllServices::Get()); - dllSvc->GetModulesTrust(std::move(mModPaths), mRunAtNormalPriority) + dllSvc->GetModulesTrust(std::move(mModIdents), mRunAtNormalPriority) ->Then( mEventTarget, __func__, [self = RefPtr{this}](ModulesMapResult&& aResult) { @@ -526,14 +527,14 @@ mozilla::ipc::IPCResult GMPParent::RecvGetModulesTrust( private: ~ModulesTrustRunnable() override = default; - ModulePaths mModPaths; + ModuleIdentifiers mModIdents; GetModulesTrustResolver mResolver; nsCOMPtr mEventTarget; bool mRunAtNormalPriority; }; NS_DispatchToMainThread(MakeAndAddRef( - std::move(aModPaths), aRunAtNormalPriority, std::move(aResolver))); + std::move(aModIdents), aRunAtNormalPriority, std::move(aResolver))); return IPC_OK(); } #endif // defined(XP_WIN) diff --git a/dom/media/gmp/GMPParent.h b/dom/media/gmp/GMPParent.h index ab4b28858643..43c5af336e0c 100644 --- a/dom/media/gmp/GMPParent.h +++ b/dom/media/gmp/GMPParent.h @@ -175,7 +175,7 @@ class GMPParent final : public PGMPParent, #if defined(XP_WIN) mozilla::ipc::IPCResult RecvGetModulesTrust( - ModulePaths&& aModPaths, bool aRunAtNormalPriority, + ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority, GetModulesTrustResolver&& aResolver); #endif // defined(XP_WIN) diff --git a/dom/media/gmp/GMPPlatform.cpp b/dom/media/gmp/GMPPlatform.cpp index 80bc22bb85c5..fdee0b2e243c 100644 --- a/dom/media/gmp/GMPPlatform.cpp +++ b/dom/media/gmp/GMPPlatform.cpp @@ -251,7 +251,7 @@ void SendFOGData(ipc::ByteBuf&& buf) { #ifdef XP_WIN RefPtr SendGetModulesTrust( - ModulePaths&& aModules, bool aRunAtNormalPriority) { + ModuleIdentifiers&& aModules, bool aRunAtNormalPriority) { if (!sChild) { return PGMPChild::GetModulesTrustPromise::CreateAndReject( ipc::ResponseRejectReason::SendError, __func__); diff --git a/dom/media/gmp/GMPPlatform.h b/dom/media/gmp/GMPPlatform.h index 709a3995aa9f..54b51bdfb0d9 100644 --- a/dom/media/gmp/GMPPlatform.h +++ b/dom/media/gmp/GMPPlatform.h @@ -11,7 +11,7 @@ namespace mozilla { #ifdef XP_WIN -struct ModulePaths; +struct ModuleIdentifiers; #endif namespace ipc { @@ -46,7 +46,7 @@ void SendFOGData(ipc::ByteBuf&& buf); #ifdef XP_WIN RefPtr SendGetModulesTrust( - ModulePaths&& aModules, bool aRunNormal); + ModuleIdentifiers&& aModules, bool aRunNormal); #endif } // namespace gmp diff --git a/dom/media/gmp/PGMP.ipdl b/dom/media/gmp/PGMP.ipdl index 2e97546256ed..f7814b31b731 100644 --- a/dom/media/gmp/PGMP.ipdl +++ b/dom/media/gmp/PGMP.ipdl @@ -12,7 +12,7 @@ include protocol PProfiler; #if defined(XP_WIN) [MoveOnly] using mozilla::UntrustedModulesData from "mozilla/UntrustedModulesData.h"; -[MoveOnly] using mozilla::ModulePaths from "mozilla/UntrustedModulesData.h"; +[MoveOnly] using mozilla::ModuleIdentifiers from "mozilla/UntrustedModulesData.h"; [MoveOnly] using mozilla::ModulesMapResult from "mozilla/UntrustedModulesData.h"; #endif @@ -42,7 +42,7 @@ parent: async FOGData(ByteBuf buf); #if defined(XP_WIN) - async GetModulesTrust(ModulePaths aModPaths, bool aRunAtNormalPriority) + async GetModulesTrust(ModuleIdentifiers aModIdents, bool aRunAtNormalPriority) returns (ModulesMapResult? modMapResult); #endif // defined(XP_WIN) diff --git a/dom/media/ipc/PRDD.ipdl b/dom/media/ipc/PRDD.ipdl index 650b5d98dde6..c3f964b280c4 100644 --- a/dom/media/ipc/PRDD.ipdl +++ b/dom/media/ipc/PRDD.ipdl @@ -30,7 +30,7 @@ using mozilla::Telemetry::DiscardedData from "mozilla/TelemetryComms.h"; #if defined(XP_WIN) [MoveOnly] using mozilla::UntrustedModulesData from "mozilla/UntrustedModulesData.h"; -[MoveOnly] using mozilla::ModulePaths from "mozilla/UntrustedModulesData.h"; +[MoveOnly] using mozilla::ModuleIdentifiers from "mozilla/UntrustedModulesData.h"; [MoveOnly] using mozilla::ModulesMapResult from "mozilla/UntrustedModulesData.h"; #endif // defined(XP_WIN) @@ -102,7 +102,7 @@ child: async AddMemoryReport(MemoryReport aReport); #if defined(XP_WIN) - async GetModulesTrust(ModulePaths aModPaths, bool aRunAtNormalPriority) + async GetModulesTrust(ModuleIdentifiers aModIdents, bool aRunAtNormalPriority) returns (ModulesMapResult? modMapResult); #endif // defined(XP_WIN) diff --git a/dom/media/ipc/RDDChild.cpp b/dom/media/ipc/RDDChild.cpp index c2a7d01badf5..b06e94a99b9f 100644 --- a/dom/media/ipc/RDDChild.cpp +++ b/dom/media/ipc/RDDChild.cpp @@ -131,10 +131,10 @@ mozilla::ipc::IPCResult RDDChild::RecvAddMemoryReport( #if defined(XP_WIN) mozilla::ipc::IPCResult RDDChild::RecvGetModulesTrust( - ModulePaths&& aModPaths, bool aRunAtNormalPriority, + ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority, GetModulesTrustResolver&& aResolver) { RefPtr dllSvc(DllServices::Get()); - dllSvc->GetModulesTrust(std::move(aModPaths), aRunAtNormalPriority) + dllSvc->GetModulesTrust(std::move(aModIdents), aRunAtNormalPriority) ->Then( GetMainThreadSerialEventTarget(), __func__, [aResolver](ModulesMapResult&& aResult) { diff --git a/dom/media/ipc/RDDChild.h b/dom/media/ipc/RDDChild.h index 0acff8794f37..d1fd64ec6539 100644 --- a/dom/media/ipc/RDDChild.h +++ b/dom/media/ipc/RDDChild.h @@ -44,7 +44,7 @@ class RDDChild final : public PRDDChild, mozilla::ipc::IPCResult RecvAddMemoryReport(const MemoryReport& aReport); #if defined(XP_WIN) mozilla::ipc::IPCResult RecvGetModulesTrust( - ModulePaths&& aModPaths, bool aRunAtNormalPriority, + ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority, GetModulesTrustResolver&& aResolver); #endif // defined(XP_WIN) mozilla::ipc::IPCResult RecvUpdateMediaCodecsSupported( diff --git a/ipc/glue/PUtilityProcess.ipdl b/ipc/glue/PUtilityProcess.ipdl index 66dcefa97ced..32dd0d19e652 100644 --- a/ipc/glue/PUtilityProcess.ipdl +++ b/ipc/glue/PUtilityProcess.ipdl @@ -42,7 +42,7 @@ using mozilla::Telemetry::DiscardedData from "mozilla/TelemetryComms.h"; #if defined(XP_WIN) [MoveOnly] using mozilla::UntrustedModulesData from "mozilla/UntrustedModulesData.h"; -[MoveOnly] using mozilla::ModulePaths from "mozilla/UntrustedModulesData.h"; +[MoveOnly] using mozilla::ModuleIdentifiers from "mozilla/UntrustedModulesData.h"; [MoveOnly] using mozilla::ModulesMapResult from "mozilla/UntrustedModulesData.h"; #endif // defined(XP_WIN) @@ -70,7 +70,7 @@ parent: async GeckoTraceExport(ByteBuf aBuf); #if defined(XP_WIN) - async GetModulesTrust(ModulePaths aModPaths, bool aRunAtNormalPriority) + async GetModulesTrust(ModuleIdentifiers aModIdents, bool aRunAtNormalPriority) returns (ModulesMapResult? modMapResult); #endif // defined(XP_WIN) diff --git a/ipc/glue/UtilityProcessParent.cpp b/ipc/glue/UtilityProcessParent.cpp index ee2ff711d94e..b0c55f1d2adb 100644 --- a/ipc/glue/UtilityProcessParent.cpp +++ b/ipc/glue/UtilityProcessParent.cpp @@ -75,10 +75,10 @@ mozilla::ipc::IPCResult UtilityProcessParent::RecvGeckoTraceExport( #if defined(XP_WIN) mozilla::ipc::IPCResult UtilityProcessParent::RecvGetModulesTrust( - ModulePaths&& aModPaths, bool aRunAtNormalPriority, + ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority, GetModulesTrustResolver&& aResolver) { RefPtr dllSvc(DllServices::Get()); - dllSvc->GetModulesTrust(std::move(aModPaths), aRunAtNormalPriority) + dllSvc->GetModulesTrust(std::move(aModIdents), aRunAtNormalPriority) ->Then( GetMainThreadSerialEventTarget(), __func__, [aResolver](ModulesMapResult&& aResult) { diff --git a/ipc/glue/UtilityProcessParent.h b/ipc/glue/UtilityProcessParent.h index 259d441ce6b2..dbd3e195d70f 100644 --- a/ipc/glue/UtilityProcessParent.h +++ b/ipc/glue/UtilityProcessParent.h @@ -42,7 +42,7 @@ class UtilityProcessParent final #if defined(XP_WIN) mozilla::ipc::IPCResult RecvGetModulesTrust( - ModulePaths&& aModPaths, bool aRunAtNormalPriority, + ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority, GetModulesTrustResolver&& aResolver); #endif // defined(XP_WIN) diff --git a/netwerk/ipc/PSocketProcess.ipdl b/netwerk/ipc/PSocketProcess.ipdl index aa9384ff1813..8168d164d782 100644 --- a/netwerk/ipc/PSocketProcess.ipdl +++ b/netwerk/ipc/PSocketProcess.ipdl @@ -50,7 +50,7 @@ using nsIDNSService::DNSFlags from "nsIDNSService.h"; #if defined(XP_WIN) [MoveOnly] using mozilla::UntrustedModulesData from "mozilla/UntrustedModulesData.h"; -[MoveOnly] using mozilla::ModulePaths from "mozilla/UntrustedModulesData.h"; +[MoveOnly] using mozilla::ModuleIdentifiers from "mozilla/UntrustedModulesData.h"; [MoveOnly] using mozilla::ModulesMapResult from "mozilla/UntrustedModulesData.h"; #endif // defined(XP_WIN) @@ -149,7 +149,7 @@ parent: async AppleFastDatapathProbeResult(bool aAvailable); #endif #if defined(XP_WIN) - async GetModulesTrust(ModulePaths aModPaths, bool aRunAtNormalPriority) + async GetModulesTrust(ModuleIdentifiers aModIdents, bool aRunAtNormalPriority) returns (ModulesMapResult? modMapResult); #endif // defined(XP_WIN) diff --git a/netwerk/ipc/SocketProcessParent.cpp b/netwerk/ipc/SocketProcessParent.cpp index a4d342387d31..06997b2d8e1f 100644 --- a/netwerk/ipc/SocketProcessParent.cpp +++ b/netwerk/ipc/SocketProcessParent.cpp @@ -363,10 +363,10 @@ mozilla::ipc::IPCResult SocketProcessParent::RecvSSLTokensCacheData( #if defined(XP_WIN) mozilla::ipc::IPCResult SocketProcessParent::RecvGetModulesTrust( - ModulePaths&& aModPaths, bool aRunAtNormalPriority, + ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority, GetModulesTrustResolver&& aResolver) { RefPtr dllSvc(DllServices::Get()); - dllSvc->GetModulesTrust(std::move(aModPaths), aRunAtNormalPriority) + dllSvc->GetModulesTrust(std::move(aModIdents), aRunAtNormalPriority) ->Then( GetMainThreadSerialEventTarget(), __func__, [aResolver](ModulesMapResult&& aResult) { diff --git a/netwerk/ipc/SocketProcessParent.h b/netwerk/ipc/SocketProcessParent.h index bdbaa5c24361..78f3ec67f6e1 100644 --- a/netwerk/ipc/SocketProcessParent.h +++ b/netwerk/ipc/SocketProcessParent.h @@ -105,7 +105,7 @@ class SocketProcessParent final #endif #if defined(XP_WIN) mozilla::ipc::IPCResult RecvGetModulesTrust( - ModulePaths&& aModPaths, bool aRunAtNormalPriority, + ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority, GetModulesTrustResolver&& aResolver); #endif // defined(XP_WIN) diff --git a/toolkit/xre/dllservices/UntrustedModulesData.h b/toolkit/xre/dllservices/UntrustedModulesData.h index 5cbddc374cca..4964b2c9b1ea 100644 --- a/toolkit/xre/dllservices/UntrustedModulesData.h +++ b/toolkit/xre/dllservices/UntrustedModulesData.h @@ -109,22 +109,22 @@ class ModuleRecord final { * serialized from either representation into a common format over the wire. * Deserialization always uses the Vector representation. */ -struct ModulePaths final { +struct ModuleIdentifiers final { using SetType = nsTHashtable; using VecType = Vector; Variant mModuleNtPaths; template - explicit ModulePaths(T&& aPaths) + explicit ModuleIdentifiers(T&& aPaths) : mModuleNtPaths(AsVariant(std::forward(aPaths))) {} - ModulePaths() : mModuleNtPaths(VecType()) {} + ModuleIdentifiers() : mModuleNtPaths(VecType()) {} - ModulePaths(const ModulePaths& aOther) = delete; - ModulePaths(ModulePaths&& aOther) = default; - ModulePaths& operator=(const ModulePaths&) = delete; - ModulePaths& operator=(ModulePaths&&) = default; + ModuleIdentifiers(const ModuleIdentifiers& aOther) = delete; + ModuleIdentifiers(ModuleIdentifiers&& aOther) = default; + ModuleIdentifiers& operator=(const ModuleIdentifiers&) = delete; + ModuleIdentifiers& operator=(ModuleIdentifiers&&) = default; }; class ProcessedModuleLoadEvent final { @@ -392,8 +392,8 @@ struct ParamTraits { }; template <> -struct ParamTraits { - typedef mozilla::ModulePaths paramType; +struct ParamTraits { + typedef mozilla::ModuleIdentifiers paramType; static void Write(MessageWriter* aWriter, const paramType& aParam) { aParam.mModuleNtPaths.match( @@ -409,8 +409,8 @@ struct ParamTraits { return false; } - // As noted in the comments for ModulePaths, we only deserialize using the - // Vector representation. + // As noted in the comments for ModuleIdentifiers, we only deserialize using + // the Vector representation. auto& vec = aResult->mModuleNtPaths.as(); if (!vec.reserve(len)) { return false; @@ -632,7 +632,7 @@ namespace mozilla { // For compiling IPDL on non-Windows platforms using UntrustedModulesData = uint32_t; -using ModulePaths = uint32_t; +using ModuleIdentifiers = uint32_t; using ModulesMapResult = uint32_t; } // namespace mozilla diff --git a/toolkit/xre/dllservices/UntrustedModulesProcessor.cpp b/toolkit/xre/dllservices/UntrustedModulesProcessor.cpp index c8054be2cda5..6238f06901ac 100644 --- a/toolkit/xre/dllservices/UntrustedModulesProcessor.cpp +++ b/toolkit/xre/dllservices/UntrustedModulesProcessor.cpp @@ -379,7 +379,7 @@ RefPtr UntrustedModulesProcessor::GetProcessedData() { } RefPtr UntrustedModulesProcessor::GetModulesTrust( - ModulePaths&& aModPaths, bool aRunAtNormalPriority) { + ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority) { MOZ_ASSERT(XRE_IsParentProcess() && NS_IsMainThread()); if (!IsReadyForBackgroundProcessing()) { @@ -388,9 +388,9 @@ RefPtr UntrustedModulesProcessor::GetModulesTrust( } RefPtr self(this); - auto run = [self = std::move(self), modPaths = std::move(aModPaths), + auto run = [self = std::move(self), modIdents = std::move(aModIdents), runNormal = aRunAtNormalPriority]() mutable { - return self->GetModulesTrustInternal(std::move(modPaths), runNormal); + return self->GetModulesTrustInternal(std::move(modIdents), runNormal); }; if (aRunAtNormalPriority) { @@ -733,14 +733,14 @@ void UntrustedModulesProcessor::ProcessModuleLoadQueue() { template static RefPtr SendGetModulesTrust( - ActorT* aActor, ModulePaths&& aModPaths, bool aRunAtNormalPriority) { + ActorT* aActor, ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority) { MOZ_ASSERT(NS_IsMainThread()); - return aActor->SendGetModulesTrust(std::move(aModPaths), + return aActor->SendGetModulesTrust(std::move(aModIdents), aRunAtNormalPriority); } RefPtr -UntrustedModulesProcessor::SendGetModulesTrust(ModulePaths&& aModules, +UntrustedModulesProcessor::SendGetModulesTrust(ModuleIdentifiers&& aModules, Priority aPriority) { MOZ_ASSERT(NS_IsMainThread()); bool runNormal = aPriority == Priority::Default; @@ -833,7 +833,7 @@ UntrustedModulesProcessor::ProcessModuleLoadQueueChildProcess( return GetModulesTrustPromise::CreateAndResolve(Nothing(), __func__); } - ModulePaths moduleNtPaths(std::move(moduleNtPathSet)); + ModuleIdentifiers moduleNtPaths(std::move(moduleNtPathSet)); if (!IsReadyForBackgroundProcessing()) { return GetModulesTrustPromise::CreateAndReject( @@ -992,7 +992,7 @@ void UntrustedModulesProcessor::CompleteProcessing( // The thread priority of this job should match the priority that the child // process is running with, as specified by |aRunAtNormalPriority|. RefPtr UntrustedModulesProcessor::GetModulesTrustInternal( - ModulePaths&& aModPaths, bool aRunAtNormalPriority) { + ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority) { MOZ_ASSERT(XRE_IsParentProcess()); AssertRunningOnLazyIdleThread(); @@ -1002,18 +1002,18 @@ RefPtr UntrustedModulesProcessor::GetModulesTrustInternal( } if (aRunAtNormalPriority) { - return GetModulesTrustInternal(std::move(aModPaths)); + return GetModulesTrustInternal(std::move(aModIdents)); } BackgroundPriorityRegion bgRgn; - return GetModulesTrustInternal(std::move(aModPaths)); + return GetModulesTrustInternal(std::move(aModIdents)); } -// For each module in |aModPaths|, evaluate its trustworthiness and only send +// For each module in |aModIdents|, evaluate its trustworthiness and only send // ModuleRecords for untrusted modules back to the child process. We also save // XUL's ModuleRecord so that the child process may report XUL's load time. RefPtr UntrustedModulesProcessor::GetModulesTrustInternal( - ModulePaths&& aModPaths) { + ModuleIdentifiers&& aModIdents) { MOZ_ASSERT(XRE_IsParentProcess()); AssertRunningOnLazyIdleThread(); @@ -1029,7 +1029,7 @@ RefPtr UntrustedModulesProcessor::GetModulesTrustInternal( } for (auto& resolvedNtPath : - aModPaths.mModuleNtPaths.as()) { + aModIdents.mModuleNtPaths.as()) { if (!IsReadyForBackgroundProcessing()) { return ModulesTrustPromise::CreateAndReject( NS_ERROR_ILLEGAL_DURING_SHUTDOWN, __func__); diff --git a/toolkit/xre/dllservices/UntrustedModulesProcessor.h b/toolkit/xre/dllservices/UntrustedModulesProcessor.h index d9844436fe07..9fa456f663c2 100644 --- a/toolkit/xre/dllservices/UntrustedModulesProcessor.h +++ b/toolkit/xre/dllservices/UntrustedModulesProcessor.h @@ -73,7 +73,7 @@ class UntrustedModulesProcessor final : public nsIObserver, // Called by IPC actors in the parent process to evaluate module trust // on behalf of child processes - RefPtr GetModulesTrust(ModulePaths&& aModPaths, + RefPtr GetModulesTrust(ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority); UntrustedModulesProcessor(const UntrustedModulesProcessor&) = delete; @@ -129,8 +129,9 @@ class UntrustedModulesProcessor final : public nsIObserver, RefPtr GetProcessedDataInternalChildProcess(); RefPtr GetModulesTrustInternal( - ModulePaths&& aModPaths, bool aRunAtNormalPriority); - RefPtr GetModulesTrustInternal(ModulePaths&& aModPaths); + ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority); + RefPtr GetModulesTrustInternal( + ModuleIdentifiers&& aModIdents); // This function is only called by the parent process RefPtr GetOrAddModuleRecord(const ModuleEvaluator& aModEval, @@ -141,8 +142,8 @@ class UntrustedModulesProcessor final : public nsIObserver, const ModulesMap& aModules, const glue::EnhancedModuleLoadInfo& aModuleLoadInfo); - RefPtr SendGetModulesTrust(ModulePaths&& aModules, - Priority aPriority); + RefPtr SendGetModulesTrust( + ModuleIdentifiers&& aModules, Priority aPriority); void CompleteProcessing(ModulesMapResultWithLoads&& aModulesAndLoads); RefPtr GetAllProcessedData(StaticString aSource); diff --git a/toolkit/xre/dllservices/WinDllServices.cpp b/toolkit/xre/dllservices/WinDllServices.cpp index ca2865680f23..3178b28b29fb 100644 --- a/toolkit/xre/dllservices/WinDllServices.cpp +++ b/toolkit/xre/dllservices/WinDllServices.cpp @@ -79,13 +79,13 @@ void DllServices::DisableFull() { } RefPtr DllServices::GetModulesTrust( - ModulePaths&& aModPaths, bool aRunAtNormalPriority) { + ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority) { if (!mUntrustedModulesProcessor) { return ModulesTrustPromise::CreateAndReject(NS_ERROR_NOT_IMPLEMENTED, __func__); } - return mUntrustedModulesProcessor->GetModulesTrust(std::move(aModPaths), + return mUntrustedModulesProcessor->GetModulesTrust(std::move(aModIdents), aRunAtNormalPriority); } diff --git a/toolkit/xre/dllservices/WinDllServices.h b/toolkit/xre/dllservices/WinDllServices.h index 93b698959147..cd0c7b096984 100644 --- a/toolkit/xre/dllservices/WinDllServices.h +++ b/toolkit/xre/dllservices/WinDllServices.h @@ -18,7 +18,7 @@ class UntrustedModulesProcessor; using UntrustedModulesPromise = MozPromise, nsresult, true>; -struct ModulePaths; +struct ModuleIdentifiers; class ModulesMapResult; using ModulesTrustPromise = MozPromise; @@ -37,7 +37,7 @@ class DllServices final : public glue::DllServices { RefPtr GetUntrustedModulesData(); - RefPtr GetModulesTrust(ModulePaths&& aModPaths, + RefPtr GetModulesTrust(ModuleIdentifiers&& aModIdents, bool aRunAtNormalPriority); private: