Bug 2071176 - Only capitalize a bug reference where a sentence or a commit subject starts. r=padenot,ai4dev-reviewers DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D325249
This commit is contained in:
committed by
dgottwald@mozilla.com
parent
6f7068b2be
commit
4d90f4a736
@@ -66,7 +66,7 @@ You can find the review identifier by inspecting the commit log with:
|
|||||||
- Running tests with `--headless` is preferred if possible for the patch.
|
- Running tests with `--headless` is preferred if possible for the patch.
|
||||||
- Never submit patches to Phabricator without explicit user approval.
|
- Never submit patches to Phabricator without explicit user approval.
|
||||||
- In commit messages, group reviewers use a `#` prefix: `r?#group-name` (e.g. `r?#linter-reviewers`), while individual reviewers do not: `r?username`
|
- In commit messages, group reviewers use a `#` prefix: `r?#group-name` (e.g. `r?#linter-reviewers`), while individual reviewers do not: `r?username`
|
||||||
- Refer to a bug as `Bug NNNNNN`, and to one of its comments as `Bug NNNNNN comment N`; Bugzilla and Phabricator both auto-link that form. A bare `comment N` only resolves within the bug it belongs to, so spell the bug number out in commit messages, review comments and other bugs. Comment numbering is 0-based with the description as comment 0: take the number from a comment's `count` field rather than counting the comments you fetched.
|
- Refer to a bug by number as `bug NNNNNN`, and to one of its comments as `bug NNNNNN comment N`; Bugzilla and Phabricator auto-link that form case-insensitively, so capitalize where a sentence or commit subject starts. A bare `comment N` only resolves within the bug it belongs to, so spell the bug number out in commit messages, review comments and other bugs. Comment numbering is 0-based with the description as comment 0: take the number from a comment's `count` field rather than counting the comments you fetched.
|
||||||
- Never put `DONTBUILD` (or `CLOSED TREE`) in the `-m` message of `mach try fuzzy` / `mach try compare` when you want builds to actually run. The Gecko decision task scans the message and on `DONTBUILD` strips every task from the graph: the decision task itself succeeds (Treeherder shows green) but no builds are scheduled.
|
- Never put `DONTBUILD` (or `CLOSED TREE`) in the `-m` message of `mach try fuzzy` / `mach try compare` when you want builds to actually run. The Gecko decision task scans the message and on `DONTBUILD` strips every task from the graph: the decision task itself succeeds (Treeherder shows green) but no builds are scheduled.
|
||||||
- When doing Android and Desktop front-end-only changes, use the special `./mach build faster` to skip all C++/Rust compilation.
|
- When doing Android and Desktop front-end-only changes, use the special `./mach build faster` to skip all C++/Rust compilation.
|
||||||
- Conversely, for C/C++/Obj-C/Rust only changes you can use the special `./mach build binaries` to skip all front-end-related tasks.
|
- Conversely, for C/C++/Obj-C/Rust only changes you can use the special `./mach build binaries` to skip all front-end-related tasks.
|
||||||
|
|||||||
Reference in New Issue
Block a user